From nobody@FreeBSD.org  Tue Jan  9 14:15:57 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 421E937B400
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  9 Jan 2001 14:15:57 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f09MFvV42053;
	Tue, 9 Jan 2001 14:15:57 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200101092215.f09MFvV42053@freefall.freebsd.org>
Date: Tue, 9 Jan 2001 14:15:57 -0800 (PST)
From: tmoestl@gmx.net
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] bug in isdnd config file scanner (breaks the ppp-expect-password option)
X-Send-Pr-Version: www-1.0

>Number:         24206
>Category:       bin
>Synopsis:       [PATCH] bug in isdnd config file scanner (breaks the ppp-expect-password option)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 09 14:20:01 PST 2001
>Closed-Date:    Fri Jan 12 08:32:56 PST 2001
>Last-Modified:  Fri Jan 12 08:33:50 PST 2001
>Originator:     Thomas Moestl
>Release:        FreeBSD 5.0-CURRENT
>Organization:
>Environment:
FreeBSD raven.local 5.0-CURRENT FreeBSD 5.0-CURRENT #31: 
Sun Jan  7 20:06:10 CET 2001     
thomas@raven.local:/usr/src/sys/compile/RAVEN  i386

>Description:
A small bug in the config file scanner breaks the ppp-expect-password
option (it is interpreted like the ppp-expect-name option).

>How-To-Repeat:
E.g., give the following options:
	ppp-expect-auth = pap
	ppp-expect-name = foo
	ppp-expect-password = bar
in your isdnd.rc. isdnd will complain about a missing password.
>Fix:
Apply the following patch (if it gets mangled, it is also available
at http://www.tu-bs.de/~y0015675/isdnd.diff).

*** src/usr.sbin/i4b/isdnd/rc_scan.l~   Mon Oct  9 16:22:39 2000
--- src/usr.sbin/i4b/isdnd/rc_scan.l    Thu Jan  4 00:29:44 2001
***************
*** 149,155 ****
  ppp-auth-paranoid             { return PPP_AUTH_PARANOID; }
  ppp-expect-auth                       { return PPP_EXPECT_AUTH; }
  ppp-expect-name                       { return PPP_EXPECT_NAME; }
! ppp-expect-password           { return PPP_EXPECT_NAME; }
  ppp-send-auth                 { return PPP_SEND_AUTH; }
  ppp-send-name                 { return PPP_SEND_NAME; }
  ppp-send-password             { return PPP_SEND_PASSWORD; }
--- 149,155 ----
  ppp-auth-paranoid             { return PPP_AUTH_PARANOID; }
  ppp-expect-auth                       { return PPP_EXPECT_AUTH; }
  ppp-expect-name                       { return PPP_EXPECT_NAME; }
! ppp-expect-password           { return PPP_EXPECT_PASSWORD; }
  ppp-send-auth                 { return PPP_SEND_AUTH; }
  ppp-send-name                 { return PPP_SEND_NAME; }
  ppp-send-password             { return PPP_SEND_PASSWORD; }


>Release-Note:
>Audit-Trail:

From: Thomas Moestl <tmoestl@gmx.net>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/24206: [PATCH] bug in isdnd config file scanner (breaks the ppp-expect-password option)
Date: Fri, 12 Jan 2001 18:01:12 +0100

 Hi,
 
 > >Number:         24206
 > >Category:       bin
 > >Synopsis:       [PATCH] bug in isdnd config file scanner (breaks the ppp-expect-password option)
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       low
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          sw-bug
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Tue Jan 09 14:20:01 PST 2001
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Thomas Moestl
 Could this PR please be closed? The patch has been committed to -current
 and does not apply to stable.
 
 	- thomas
 
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Fri Jan 12 08:32:56 PST 2001 
State-Changed-Why:  
Closed at submitters request as patch has been applied. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=24206 
>Unformatted:
