From nobody@FreeBSD.org  Mon Jan  8 02:18:34 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id F3B3637B6A6
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  8 Jan 2001 02:18:14 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f08AIEV05738;
	Mon, 8 Jan 2001 02:18:14 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200101081018.f08AIEV05738@freefall.freebsd.org>
Date: Mon, 8 Jan 2001 02:18:14 -0800 (PST)
From: thz@lennartz-electronic.de
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: indent broken by commit from 09/12/2000
X-Send-Pr-Version: www-1.0

>Number:         24146
>Category:       bin
>Synopsis:       indent broken by commit from 09/12/2000
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 08 02:20:01 PST 2001
>Closed-Date:    Fri Apr 20 00:43:03 PDT 2001
>Last-Modified:  Mon Dec 10 13:30:01 PST 2001
>Originator:     Thomas Zenker
>Release:        4.2-STABLE
>Organization:
>Environment:
FreeBSD mezcal.tue.le 4.2-STABLE FreeBSD 4.2-STABLE #0: Fri Dec 22 14:39:49 CET 2000     thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL  i386
>Description:
The commit from 9. dec. 2000 to `indent' broke the formatting of
functions with structure pointer in the prototype.
>How-To-Repeat:
Format the following function with indent after 9. december:

void
foo(struct bar *bar)
{
    return 0;
}

>Fix:
Reinserting of two of lines removed by the commit from 9/12/2000
allows again for a correct formatting of this type of functions.


Index: lexi.c
===================================================================
RCS file: /usr/cvs/FreeBSD/src/usr.bin/indent/lexi.c,v
retrieving revision 1.3.6.1
diff -u -r1.3.6.1 lexi.c
--- lexi.c      2000/12/09 19:05:05     1.3.6.1
+++ lexi.c      2000/12/21 11:54:15
@@ -261,6 +261,8 @@
                return (casestmt);

            case 3:             /* a "struct" */
+               if (ps.p_l_follow)
+                   break;      /* inside parens: cast */
                /*
                 * Next time around, we may want to know that we have had a
                 * 'struct'



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Mon Jan 8 07:43:38 PST 2001 
Responsible-Changed-Why:  
David O'Brien made quite a lot of recent changes to ident. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=24146 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Fri Apr 20 00:43:03 PDT 2001 
State-Changed-Why:  
Committed.  Thanks!! 
(sorry for the slow responce) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=24146 

From: "Thomas Sandford" <thomas@paradisegreen.co.uk>
To: <freebsd-gnats-submit@FreeBSD.org>, <thz@lennartz-electronic.de>
Cc:  
Subject: Re: bin/24146: indent broken by commit from 09/12/2000
Date: Mon, 10 Dec 2001 16:17:40 -0000

 This is _still_ broken in 4.4-RELEASE. Can someone migrate the fix into
 the -STABLE tree as well please!
 
 --
 Thomas Sandford | thomas@paradisegreen.co.uk
 
>Unformatted:
