From aaron@midgard.eazel.com  Tue Dec 26 15:14:21 2000
Return-Path: <aaron@midgard.eazel.com>
Received: from midgard.eazel.com (eazel130.eazel.com [64.0.4.130])
	by hub.freebsd.org (Postfix) with ESMTP id 2136137B400
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Dec 2000 15:14:21 -0800 (PST)
Received: (from aaron@localhost)
	by midgard.eazel.com (8.9.3/8.9.3) id PAA99428;
	Tue, 26 Dec 2000 15:14:20 -0800 (PST)
	(envelope-from aaron)
Message-Id: <200012262314.PAA99428@midgard.eazel.com>
Date: Tue, 26 Dec 2000 15:14:20 -0800 (PST)
From: aaron@eazel.com
Sender: aaron@midgard.eazel.com
Reply-To: aaron@eazel.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: ncal
X-Send-Pr-Version: 3.2

>Number:         23866
>Category:       bin
>Synopsis:       patch for pointing out current date
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    dwmalone
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 26 15:20:01 PST 2000
>Closed-Date:    Tue Feb 08 09:31:59 GMT 2005
>Last-Modified:  Tue Feb 08 09:31:59 GMT 2005
>Originator:     
>Release:        
>Organization:
>Environment:
>Description:
	this patch adds the option -h, which highlights the current
	date in a calendar listing by parenthesizing it.

	the patch is two diffs - .c and .1. since this program doesn't
	appear to support attaching files, i have posted a 1K tarball
	of my changes at: http://lithic.org/aaron/ncal-diffs.tar.gz

	please contact me by email if there are any problems or questions
	about my patch. thanks!



>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Tue Dec 26 15:53:15 PST 2000 
Responsible-Changed-Why:  
I'm having a look at the patch. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23866 

From: David Malone <dwmalone@maths.tcd.ie>
To: aaron@eazel.com
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: bin/23866: ncal
Date: Tue, 26 Dec 2000 23:52:41 +0000

 On Tue, Dec 26, 2000 at 03:14:20PM -0800, aaron@eazel.com wrote:
 
 > 	the patch is two diffs - .c and .1. since this program doesn't
 > 	appear to support attaching files, i have posted a 1K tarball
 > 	of my changes at: http://lithic.org/aaron/ncal-diffs.tar.gz
 
 I'm having a look at your patch - the idea seems nice, but the
 code has some serious style and whitespace issues. Have you
 done "man 9 style" to read about the style usually used for
 FreeBSD code? Also, we usually use unified diffs (diff -u)
 as they are easier to read through.
 
 I'll let you know when I've a better look.
 
 	David.
 
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Tue Feb 8 09:30:21 GMT 2005 
State-Changed-Why:  
I never managed to take any action on this PR (there were some 
style issues and layout of the output problems). The patch is 
no longer available either, so close this PR. 

David. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23866 
>Unformatted:
