From sanewo@ba2.so-net.ne.jp  Mon Nov 27 05:00:37 2000
Return-Path: <sanewo@ba2.so-net.ne.jp>
Received: from mgate07.so-net.ne.jp (mgate07.so-net.ne.jp [210.139.254.154])
	by hub.freebsd.org (Postfix) with ESMTP id 819C237B479
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Nov 2000 05:00:36 -0800 (PST)
Received: from mail.ba2.so-net.ne.jp (mail.ba2.so-net.ne.jp [210.139.254.21])
	by mgate07.so-net.ne.jp (8.8.8+3.0Wbeta9/3.6W00111614) with ESMTP id WAA24347
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Nov 2000 22:00:29 +0900 (JST)
Received: from ba2.so-net.ne.jp (pd5e0fe.tokynt01.ap.so-net.ne.jp [202.213.224.254])
	by mail.ba2.so-net.ne.jp (8.8.8/3.7W99081617) with ESMTP id WAA23028
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Nov 2000 22:00:27 +0900 (JST)
Received: (from sanewo@localhost)
	by ba2.so-net.ne.jp (8.11.1/8.11.1) id eARCxur77219;
	Mon, 27 Nov 2000 21:59:56 +0900 (JST)
	(envelope-from sanewo)
Message-Id: <200011271259.eARCxur77219@ba2.so-net.ne.jp>
Date: Mon, 27 Nov 2000 21:59:56 +0900 (JST)
From: sanewo@ba2.so-net.ne.jp
To: FreeBSD-gnats-submit@freebsd.org
Subject: libfetch doesn't behave as documented about FTP_PROXY
X-Send-Pr-Version: 3.2

>Number:         23128
>Category:       bin
>Synopsis:       libfetch doesn't behave as documented about FTP_PROXY
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 27 05:10:01 PST 2000
>Closed-Date:    Fri Dec 1 03:11:54 PST 2000
>Last-Modified:  Fri Dec 01 03:12:07 PST 2000
>Originator:     Takanori Saneto
>Release:        FreeBSD 4.2-STABLE i386 & 5.0-CURRENT
>Organization:
an individual
>Environment:

FreeBSD 4.2-STABLE & 5.0-CURRENT as of 27/Nov/2000

>Description:

On FTP_PROXY environment variable, fetch(3) says "if no scheme is specified, FTP is assumed."
But lib/libfetch/ftp.c sets default scheme as HTTP.

   872  _ftp_get_proxy(void)
	:
   879          if (!*purl->scheme)
   880              strcpy(purl->scheme, SCHEME_HTTP);

>How-To-Repeat:

Put just a hostname to FTP_PROXY and invoke fetch. You will see fetch trying to
connect proxy via http port (80).

>Fix:

Change the source as documented, or change the document as source behaves.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Mon Nov 27 05:23:17 PST 2000 
Responsible-Changed-Why:  
Des owns libfecth. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23128 

From: Dag-Erling Smorgrav <des@ofug.org>
To: sanewo@ba2.so-net.ne.jp
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/23128: libfetch doesn't behave as documented about FTP_PROXY
Date: 27 Nov 2000 14:26:04 +0100

 sanewo@ba2.so-net.ne.jp writes:
 > On FTP_PROXY environment variable, fetch(3) says "if no scheme is
 > specified, FTP is assumed." But lib/libfetch/ftp.c sets default
 > scheme as HTTP.
 
 I'm aware of this problem, and will fix it very soon.
 
 DES
 -- 
 Dag-Erling Smorgrav - des@ofug.org
 

From: Dag-Erling Smorgrav <des@ofug.org>
To: sanewo@ba2.so-net.ne.jp
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/23128: libfetch doesn't behave as documented about FTP_PROXY
Date: 27 Nov 2000 14:29:48 +0100

 I should elaborate a little more - I got a report of the opposite bug
 (defaulting to FTP where it previously defaulted to HTTP) shortly
 before 4.2-RELEASE, and in the rush to get it fixed in time for the
 release, I fixed it the wrong way. The following patch should correct
 the problem:
 
 Index: ftp.c
 ===================================================================
 RCS file: /home/ncvs/src/lib/libfetch/ftp.c,v
 retrieving revision 1.16.2.14
 diff -u -r1.16.2.14 ftp.c
 --- ftp.c	2000/11/27 10:15:09	1.16.2.14
 +++ ftp.c	2000/11/27 13:27:02
 @@ -877,7 +877,10 @@
      if (((p = getenv("FTP_PROXY")) || (p = getenv("HTTP_PROXY"))) &&
  	*p && (purl = fetchParseURL(p)) != NULL) {
  	if (!*purl->scheme)
 -	    strcpy(purl->scheme, SCHEME_HTTP);
 +	    if (getenv("FTP_PROXY"))
 +		strcpy(purl->scheme, SCHEME_FTP);
 +	    else
 +		strcpy(purl->scheme, SCHEME_HTTP);
  	if (!purl->port)
  	    purl->port = _fetch_default_proxy_port(purl->scheme);
  	if (strcasecmp(purl->scheme, SCHEME_FTP) == 0 ||
 
 
 DES
 -- 
 Dag-Erling Smorgrav - des@ofug.org
 
State-Changed-From-To: open->feedback 
State-Changed-By: des 
State-Changed-When: Tue Nov 28 01:21:06 PST 2000 
State-Changed-Why:  
Fixed in -CURRENT, awaiting MFC. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23128 
State-Changed-From-To: feedback->closed 
State-Changed-By: des 
State-Changed-When: Fri Dec 1 03:11:54 PST 2000 
State-Changed-Why:  
MFCed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=23128 
>Unformatted:
