From nobody@FreeBSD.ORG  Thu Nov 16 02:26:01 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A987237B4CF; Thu, 16 Nov 2000 02:26:01 -0800 (PST)
Message-Id: <20001116102601.A987237B4CF@hub.freebsd.org>
Date: Thu, 16 Nov 2000 02:26:01 -0800 (PST)
From: olgeni@uli.it
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: savecore dumps core at boot
X-Send-Pr-Version: www-1.0

>Number:         22886
>Category:       bin
>Synopsis:       savecore dumps core at boot
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    adrian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 16 02:30:01 PST 2000
>Closed-Date:    Thu Nov 16 10:54:10 PST 2000
>Last-Modified:  Thu Nov 16 10:55:20 PST 2000
>Originator:     Jimmy Olgeni
>Release:        4.2 BETA (i386)
>Organization:
Colby
>Environment:
FreeBSD dev1.localdomain.net 4.2-BETA FreeBSD 4.2-BETA #0: Mon Nov 13 13:48:12 CET 2000     root@dev1.localdomain.net:/usr/obj/usr/src/sys/BSDBOX  i386

>Description:
The "savecore" command dumps core at boot, leaving savecore.core in the root directory.

The same problem occurs when invoked manually, I tried on 2 4.2-BETA boxes.

In both cases I didn't have a core image in swap.
>How-To-Repeat:
dev1# swapinfo
Device          1K-blocks     Used    Avail Capacity  Type
/dev/ad0s1b        262016        0   262016     0%    Interleaved
dev1# cat /etc/fstab | grep swa
/dev/ad0s1b             none            swap    sw              0       0
dev1# cat /etc/rc.conf |grep dumpdev
dumpdev="/dev/ad0s1b"           # Device name to crashdump to (or NO).

(it looks properly configured)

dev1# savecore /var/crash
Bus error (core dumped)
dev1# ls *core
savecore.core
dev1#

>Fix:


>Release-Note:
>Audit-Trail:

From: Akio Morita <amorita@meadow.scphys.kyoto-u.ac.jp>
To: freebsd-gnats-submit@FreeBSD.org, olgeni@uli.it
Cc: Akio Morita <amorita@meadow.scphys.kyoto-u.ac.jp>
Subject: Re: bin/22886: savecore dumps core at boot
Date: 16 Nov 2000 20:33:56 +0900

 I found the reason of savecore's core dump problem(PR bin/22886).
 
 [Reason]
 See compile log in src/sbin/savecore.
 `ld' reports the symbol conflict `dirname'.
 In savecore.c, dirname symbol is local pointer of char.
 In libc/gen/dirname.c, dirname symbol is function.
 --- Log
 misao% make
 cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress   -c /usr/SRC/src/sbin/savecore/savecore.c
 cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress   -c /usr/SRC/src/sbin/savecore/../../usr.bin/compress/zopen.c
 cc -O -pipe -I/usr/SRC/src/sbin/savecore/../../usr.bin/compress    -static -o savecore savecore.o zopen.o  
 /usr/libexec/elf/ld: Warning: size of symbol `dirname' changed from 4 to 206 in dirname.o
 /usr/libexec/elf/ld: Warning: type of symbol `dirname' changed from 1 to 2 in dirname.o
 gzip -cn /usr/SRC/src/sbin/savecore/savecore.8 > savecore.8.gz
 --- Log
 
 [Quick Hack]
 Apply below patch to src/sbin/savecore/savecore.c.
 --- patch
 diff -d -u -r1.28.2.3 savecore.c
 --- savecore.c	2000/07/04 01:17:47	1.28.2.3
 +++ savecore.c	2000/11/16 11:12:25
 @@ -108,7 +108,7 @@
  int	dumpsize;			/* amount of memory dumped */
  
  char	*kernel;
 -char	*dirname;			/* directory to save dumps in */
 +static char	*dirname;			/* directory to save dumps in */
  char	*ddname;			/* name of dump device */
  dev_t	dumpdev;			/* dump device */
  int	dumpfd;				/* read/write descriptor on char dev */
 --- patch
 
 --
 Akio Morita
 
Responsible-Changed-From-To: freebsd-bugs->adrian 
Responsible-Changed-By: tanimura 
Responsible-Changed-When: Thu Nov 16 03:45:32 PST 2000 
Responsible-Changed-Why:  
adrian is asking jkh for approval to fix this bug. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22886 
State-Changed-From-To: open->closed 
State-Changed-By: adrian 
State-Changed-When: Thu Nov 16 10:54:10 PST 2000 
State-Changed-Why:  
Fixed in rev 1.28.2.4 of src/sbin/savecore.c . 

Thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=22886 
>Unformatted:
