From nobody@FreeBSD.ORG  Fri Oct 20 00:36:20 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D9ED737B4D7; Fri, 20 Oct 2000 00:36:20 -0700 (PDT)
Message-Id: <20001020073620.D9ED737B4D7@hub.freebsd.org>
Date: Fri, 20 Oct 2000 00:36:20 -0700 (PDT)
From: sethk@osd.bsdi.com
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] wicontrol(9)
X-Send-Pr-Version: www-1.0

>Number:         22143
>Category:       bin
>Synopsis:       [PATCH] wicontrol(9)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    wpaul
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 20 00:40:01 PDT 2000
>Closed-Date:    Mon Oct 30 08:35:46 PST 2000
>Last-Modified:  Mon Oct 30 08:40:01 PST 2000
>Originator:     Seth Kingsley
>Release:        5.0-CURRENT
>Organization:
>Environment:
FreeBSD veritech.osd.bsdi.com 5.0-CURRENT FreeBSD 5.0-CURRENT #4: 
Thu Oct 19 00:14:24 PDT 2000
root@veritech:/usr/src/sys/compile/VERITECH  i386
>Description:
The wicontrol utility fails to detect that no interface has been
specified when using the -e option as it does for other options.
Pretty self-explanitory.
>How-To-Repeat:
wicontrol -e 1
>Fix:
===================================================================
RCS file: /ncvs/src/usr.sbin/wicontrol/wicontrol.c,v
retrieving revision 1.13
diff -u -r1.13 wicontrol.c
--- wicontrol.c 2000/09/21 00:25:07     1.13
+++ wicontrol.c 2000/10/20 06:58:14
@@ -208,6 +208,9 @@
 {
        struct wi_req           wreq;
 
+       if (iface == NULL)
+               errx(1, "must specify interface name");
+
        bzero((char *)&wreq, sizeof(wreq));
 
        wreq.wi_type = code;

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->wpaul 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Fri Oct 20 08:00:44 PDT 2000 
Responsible-Changed-Why:  
Bill Paul wrote wicontrol - this looks like a simple patch though. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22143 
State-Changed-From-To: open->closed 
State-Changed-By: joe 
State-Changed-When: Mon Oct 30 08:35:46 PST 2000 
State-Changed-Why:  
This is no longer a problem.  The default behaviour is now 
to use wi0 if no interface is specified. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=22143 

From: Josef Karthauser <joe@pavilion.net>
To: sethk@osd.bsdi.com
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: bin/22143: [PATCH] wicontrol(9)
Date: Mon, 30 Oct 2000 16:39:03 +0000

 On Fri, Oct 20, 2000 at 12:36:20AM -0700, sethk@osd.bsdi.com wrote:
 > FreeBSD veritech.osd.bsdi.com 5.0-CURRENT FreeBSD 5.0-CURRENT #4: 
 > Thu Oct 19 00:14:24 PDT 2000
 > root@veritech:/usr/src/sys/compile/VERITECH  i386
 > >Description:
 > The wicontrol utility fails to detect that no interface has been
 > specified when using the -e option as it does for other options.
 > Pretty self-explanitory.
 
 I committed something this week that fixes this.  In an interface
 name isn't specified it defaults to wi0.  There's a similar fix in
 to ancontrol.
 
 This was MFC'd yesterday.
 
 Joe
 -- 
 Josef Karthauser	FreeBSD: How many times have you booted today?
 Technical Manager	Viagra for your server (http://www.uk.freebsd.org)
 Pavilion Internet plc.  [joe@pavilion.net, joe@uk.freebsd.org, joe@tao.org.uk]
 
>Unformatted:
