From bonk1138@msn.com  Wed Sep 20 20:18:04 2000
Return-Path: <bonk1138@msn.com>
Received: from smtp.email.msn.com (cpimssmtpu03.email.msn.com [207.46.181.19])
	by hub.freebsd.org (Postfix) with ESMTP id F2EC137B423
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 20 Sep 2000 20:18:03 -0700 (PDT)
Received: from anakin - 63.15.0.110 by email.msn.com with Microsoft SMTPSVC;
	 Wed, 20 Sep 2000 20:17:14 -0700
Message-Id: <KJEDKFEKMMFFMPFPBLJHEEDPDBAA.bonk1138@msn.com>
Date: Wed, 20 Sep 2000 20:18:02 -0700
From: "James Johnson" <bonk1138@msn.com>
To: <FreeBSD-gnats-submit@freebsd.org>
Subject: pkg_install will not compile w/o warnings

>Number:         21436
>Category:       bin
>Synopsis:       pkg_install will not compile without errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 20 20:20:00 PDT 2000
>Closed-Date:    Wed Aug 15 07:27:53 PDT 2001
>Last-Modified:  Wed Aug 15 07:28:25 PDT 2001
>Originator:     James Johnson
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
NonYa
>Environment:

FreeBSD obiwan 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Tue Sep 19 00:22:29 PDT
2000     jsj@obiwan:/usr/obj/usr/src2/src/sys/obiwan  i386

>Description:

	Attempting to compile usr.sbin/pkg_install with -Werror and -Wall
will fail

>How-To-Repeat:

	Try compiling usr.sbin/pkg_install with -Wall and -Werror

>Fix:

Index: extract.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/add/extract.c,v
retrieving revision 1.25
diff -u -r1.25 extract.c
--- extract.c   1999/08/28 01:17:55     1.25
+++ extract.c   2000/09/21 03:08:27
@@ -249,6 +249,14 @@
        case PLIST_IGNORE:
            p = p->next;
            break;
+       case PLIST_UNEXEC:
+       case PLIST_SRC:
+       case PLIST_DISPLAY:
+       case PLIST_PKGDEP:
+       case PLIST_MTREE:
+       case PLIST_DIR_RM:
+       case PLIST_IGNORE_INST:
+       case PLIST_OPTION:
        }
        p = p->next;
     }



Index: file.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/pkg_install/lib/file.c,v
retrieving revision 1.43
diff -u -r1.43 file.c
--- file.c      2000/09/18 07:41:48     1.43
+++ file.c      2000/09/21 03:09:16
@@ -142,14 +142,12 @@
 char *
 fileGetURL(char *base, char *spec)
 {
-    char host[HOSTNAME_MAX], file[FILENAME_MAX];
-    char pword[HOSTNAME_MAX + 40], *uname, *cp, *rp;
+    char *cp, *rp;
     char fname[FILENAME_MAX];
     char pen[FILENAME_MAX];
-    struct passwd *pw;
     FILE *ftp;
     pid_t tpid;
-    int i, status;
+    int i;
     char *hint;
 
     rp = NULL;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: sobomax 
State-Changed-When: Wed Aug 15 07:27:53 PDT 2001 
State-Changed-Why:  
The problems in question already fixed. Thank you for submission anyway! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=21436 
>Unformatted:
