From fanf@dotat.at  Mon Jul 31 19:16:06 2000
Return-Path: <fanf@dotat.at>
Received: from hand.dotat.at (sfo-gw.covalent.net [207.44.198.62])
	by hub.freebsd.org (Postfix) with ESMTP id 71E5937BDB4
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Jul 2000 19:16:05 -0700 (PDT)
	(envelope-from fanf@dotat.at)
Received: from fanf by hand.dotat.at with local (Exim 3.15 #3)
	id 13JRbD-0001xv-00
	for FreeBSD-gnats-submit@freebsd.org; Tue, 01 Aug 2000 02:16:07 +0000
Message-Id: <E13JRbD-0001xv-00@hand.dotat.at>
Date: Tue, 01 Aug 2000 02:16:07 +0000
From: Tony Finch <dot@dotat.at>
Sender: fanf@dotat.at
Reply-To: Tony Finch <dot@dotat.at>
To: FreeBSD-gnats-submit@freebsd.org
Subject: dhclient configures the broadcast address incorrectly
X-Send-Pr-Version: 3.2

>Number:         20331
>Category:       bin
>Synopsis:       dhclient configures the broadcast address incorrectly
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 31 19:20:01 PDT 2000
>Closed-Date:    Thu Aug 10 03:29:31 PDT 2000
>Last-Modified:  Thu Aug 10 03:29:50 PDT 2000
>Originator:     Tony Finch <dot@dotat.at>
>Release:        FreeBSD 4.1-STABLE-20000729 i386
>Organization:
dotat
>Environment:

FreeBSD hand.dotat.at 4.1-STABLE-20000729 FreeBSD 4.1-STABLE-20000729 #0: Sun Jul 30 00:30:12 UTC 2000     root@hand.dotat.at:/other/obj/other/src/sys/DELL-Latitude-CPx  i386

>Description:

dhclient configures the broadcast address of an interface to the
subnet's base address

>How-To-Repeat:

This is the situation on my machine right now.

fanf@hand.dotat.at:~
:; ifconfig -a
lo0: flags=8049<UP,LOOPBACK,RUNNING,MULTICAST> mtu 16384
        inet6 fe80::1%lo0 prefixlen 64 scopeid 0x1 
        inet6 ::1 prefixlen 128 
        inet 127.0.0.1 netmask 0xff000000 
ed0: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        inet6 fe80::280:c8ff:fe87:ec91%ed0 prefixlen 64 scopeid 0x2 
        inet 10.0.0.35 netmask 0xffffff00 broadcast 10.0.0.0
        ether 00:80:c8:87:ec:91 
fanf@hand.dotat.at:~
:; ps aux | grep dhc 
fanf  7528  0.0  0.4  1036  512  p1  S+    2:14AM   0:00.00 grep dhc
root  1277  0.0  0.2   536  280  ??  Is    4:45AM   0:00.00 /sbin/dhclient ed0
fanf@hand.dotat.at:~
:; 


>Fix:

Fortunately it's just a simple cut & paste coding error.

--- dhclient.c.orig	Thu Jul 20 20:29:53 2000
+++ dhclient.c	Tue Aug  1 02:11:22 2000
@@ -1972,7 +1972,7 @@
 				if (broadcast.len) {
 				    client_envadd (ip -> client,
 						   prefix, "broadcast_address",
-						   "%s", piaddr (subnet));
+						   "%s", piaddr (broadcast));
 				}
 			}
 		}

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Aug 1 01:31:45 PDT 2000 
Responsible-Changed-Why:  
David, this one contains a patch. :-) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20331 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Thu Aug 10 03:29:31 PDT 2000 
State-Changed-Why:  
fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20331 
>Unformatted:
