From ambrisko@whistle.com  Mon Jul 10 14:15:07 2000
Return-Path: <ambrisko@whistle.com>
Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38])
	by hub.freebsd.org (Postfix) with ESMTP id CF9F537B7A9
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Jul 2000 14:15:04 -0700 (PDT)
	(envelope-from ambrisko@whistle.com)
Received: from whistle.com (crab.whistle.com [207.76.205.112])
	by alpo.whistle.com (8.9.1a/8.9.1) with ESMTP id OAA41517
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Jul 2000 14:11:36 -0700 (PDT)
Received: (from ambrisko@localhost)
	by whistle.com (8.9.3/8.9.1) id OAA15710;
	Mon, 10 Jul 2000 14:11:25 -0700 (PDT)
	(envelope-from ambrisko)
Message-Id: <200007102111.OAA15710@whistle.com>
Date: Mon, 10 Jul 2000 14:11:25 -0700 (PDT)
From: ambrisko@whistle.com
Reply-To: ambrisko@whistle.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: telnet -X SRA core dump
X-Send-Pr-Version: 3.2

>Number:         19835
>Category:       bin
>Synopsis:       Fix core dump when disabling SRA authentication (telnet -X SRA)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    nsayer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 10 14:20:01 PDT 2000
>Closed-Date:    Tue Jul 11 08:04:26 PDT 2000
>Last-Modified:  Tue Jul 11 08:05:04 PDT 2000
>Originator:     Doug Ambrisko
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Whistle/IBM
>Environment:
US release

>Description:

"telnet -X SRA" results in a core dump.  This is due to a NULL pointer
passed to strcasecmp in libtelnet.  So this also effect telnetd as well.

>How-To-Repeat:

	

>Fix:

	

Index: auth.c
===================================================================
RCS file: /cvs/freebsd/src/crypto/telnet/libtelnet/auth.c,v
retrieving revision 1.3
diff -c -r1.3 auth.c
*** auth.c	1999/08/16 11:24:25	1.3
--- auth.c	2000/07/10 21:03:07
***************
*** 249,255 ****
  {
  	int x;
  	for (x = 0; x < AUTHTYPE_CNT; ++x) {
! 		if (!strcasecmp(name, AUTHTYPE_NAME(x))) {
  			i_wont_support |= typemask(x);
  			break;
  		}
--- 249,255 ----
  {
  	int x;
  	for (x = 0; x < AUTHTYPE_CNT; ++x) {
! 		if (AUTHTYPE_NAME(x) && !strcasecmp(name, AUTHTYPE_NAME(x))) {
  			i_wont_support |= typemask(x);
  			break;
  		}

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->nsayer 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Jul 11 01:41:29 PDT 2000 
Responsible-Changed-Why:  
Nick brought in the SRA authentication. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19835 
State-Changed-From-To: open->closed 
State-Changed-By: nsayer 
State-Changed-When: Tue Jul 11 08:04:26 PDT 2000 
State-Changed-Why:  
Committed patch to -current. Will MFC after feedback. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=19835 
>Unformatted:
