From mb@bagheera.thgwf.de  Sun Jul  2 12:29:56 2000
Return-Path: <mb@bagheera.thgwf.de>
Received: from miraculix.thg.wf.ni.schule.de (miraculix.thg.wf.ni.schule.de [141.41.62.2])
	by hub.freebsd.org (Postfix) with ESMTP id 202D337BE73
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 Jul 2000 12:29:54 -0700 (PDT)
	(envelope-from mb@bagheera.thgwf.de)
Received: (from uucp@localhost)
	by miraculix.thg.wf.ni.schule.de (8.9.3/8.9.3) with UUCP id VAA01964
	for FreeBSD-gnats-submit@freebsd.org; Sun, 2 Jul 2000 21:29:55 +0200 (CEST)
	(envelope-from mb@bagheera.thgwf.de)
Received: (from mb@localhost)
	by bagheera.thgwf.de (8.9.3/8.9.3) id VAA01192;
	Sun, 2 Jul 2000 21:29:19 +0200 (CEST)
	(envelope-from mb)
Message-Id: <200007021929.VAA01192@bagheera.thgwf.de>
Date: Sun, 2 Jul 2000 21:29:19 +0200 (CEST)
From: Martin Butkus <mb@bagheera.thgwf.de>
Reply-To: m.butkus@tu-bs.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: ``pw usermod -n user -d /new/homedir'' does nothing
X-Send-Pr-Version: 3.2

>Number:         19649
>Category:       bin
>Synopsis:       ``pw usermod -n user -d /new/homedir'' does nothing
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    davidn
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 02 12:30:01 PDT 2000
>Closed-Date:    Mon Jul 3 22:14:00 EST 2000
>Last-Modified:  Fri Jul 14 07:50:02 PDT 2000
>Originator:     Martin Butkus
>Release:        FreeBSD 4.0-STABLE i386
>Organization:
TU Braunschweig
>Environment:

	FreeBSD 4.0-STABLE as of Wed Jun 21 07:49:53 CEST 2000.
	"cd /usr/src/usr.sbin/pw ; ident *.[ch]" gives this result:

	bitmap.c: $FreeBSD: src/usr.sbin/pw/bitmap.c,v 1.5 1999/08/28 01:19:15 peter Exp $

	bitmap.h:
	     $FreeBSD: src/usr.sbin/pw/bitmap.h,v 1.4 1999/08/28 01:19:16 peter Exp $

	cpdir.c:
	     $FreeBSD: src/usr.sbin/pw/cpdir.c,v 1.5 1999/08/28 01:19:16 peter Exp $

	edgroup.c:
	     $FreeBSD: src/usr.sbin/pw/edgroup.c,v 1.8 1999/08/28 01:19:16 peter Exp $

	fileupd.c:
	     $FreeBSD: src/usr.sbin/pw/fileupd.c,v 1.9 1999/10/26 04:27:13 davidn Exp $

	grupd.c:
	     $FreeBSD: src/usr.sbin/pw/grupd.c,v 1.8 1999/10/26 04:27:14 davidn Exp $

	psdate.c:
	     $FreeBSD: src/usr.sbin/pw/psdate.c,v 1.6 1999/08/28 01:19:17 peter Exp $

	psdate.h:
	     $FreeBSD: src/usr.sbin/pw/psdate.h,v 1.4 1999/08/28 01:19:17 peter Exp $

	pw.c:
	     $FreeBSD: src/usr.sbin/pw/pw.c,v 1.18.2.1 2000/06/18 05:45:10 davidn Exp $

	pw.h:
	     $FreeBSD: src/usr.sbin/pw/pw.h,v 1.10 1999/10/26 08:34:08 davidn Exp $

	pw_conf.c:
	     $FreeBSD: src/usr.sbin/pw/pw_conf.c,v 1.10 1999/08/28 01:19:19 peter Exp $

	pw_group.c:
	     $FreeBSD: src/usr.sbin/pw/pw_group.c,v 1.12 2000/01/15 00:20:20 davidn Exp $

	pw_log.c:
	     $FreeBSD: src/usr.sbin/pw/pw_log.c,v 1.5 1999/08/28 01:19:20 peter Exp $

	pw_nis.c:
	     $FreeBSD: src/usr.sbin/pw/pw_nis.c,v 1.6 1999/08/28 01:19:20 peter Exp $

	pw_user.c:
	     $FreeBSD: src/usr.sbin/pw/pw_user.c,v 1.34.2.1 2000/06/18 05:45:10 davidn Exp $

	pw_vpw.c:
	     $FreeBSD: src/usr.sbin/pw/pw_vpw.c,v 1.3 2000/01/15 00:20:21 davidn Exp $

	pwupd.c:
	     $FreeBSD: src/usr.sbin/pw/pwupd.c,v 1.12.2.1 2000/06/18 05:45:11 davidn Exp $

	pwupd.h:
	     $FreeBSD: src/usr.sbin/pw/pwupd.h,v 1.7 2000/01/15 00:20:22 davidn Exp $

	rm_r.c:
	     $FreeBSD: src/usr.sbin/pw/rm_r.c,v 1.5 1999/08/28 01:19:22 peter Exp $
	
	
	This bug is also present on another system (3.5-STABLE cvsupped 
	today). The ident output on this system is:

	bitmap.c:
	     $FreeBSD: src/usr.sbin/pw/bitmap.c,v 1.4.2.2 2000/06/28 22:48:14 ache Exp $

	bitmap.h:
	     $FreeBSD: src/usr.sbin/pw/bitmap.h,v 1.3.2.2 2000/06/28 22:48:14 ache Exp $

	cpdir.c:
	     $FreeBSD: src/usr.sbin/pw/cpdir.c,v 1.4.2.2 2000/06/28 22:48:14 ache Exp $

	edgroup.c:
	     $FreeBSD: src/usr.sbin/pw/edgroup.c,v 1.6.2.3 2000/06/28 22:48:14 ache Exp $

	fileupd.c:
	     $FreeBSD: src/usr.sbin/pw/fileupd.c,v 1.6.2.4 2000/06/28 22:48:14 ache Exp $

	grupd.c:
	     $FreeBSD: src/usr.sbin/pw/grupd.c,v 1.5.2.4 2000/06/28 22:48:14 ache Exp $

	psdate.c:
	     $FreeBSD: src/usr.sbin/pw/psdate.c,v 1.4.2.3 2000/06/28 22:48:14 ache Exp $

	psdate.h:
	     $FreeBSD: src/usr.sbin/pw/psdate.h,v 1.3.2.2 2000/06/28 22:48:14 ache Exp $

	pw.c:
	     $FreeBSD: src/usr.sbin/pw/pw.c,v 1.11.2.4 2000/06/28 22:48:14 ache Exp $

	pw.h:
	     $FreeBSD: src/usr.sbin/pw/pw.h,v 1.7.2.4 2000/06/28 22:48:14 ache Exp $

	pw_conf.c:
	     $FreeBSD: src/usr.sbin/pw/pw_conf.c,v 1.7.2.3 2000/06/28 22:48:14 ache Exp $

	pw_group.c:
	     $FreeBSD: src/usr.sbin/pw/pw_group.c,v 1.7.2.4 2000/06/28 22:48:14 ache Exp $

	pw_log.c:
	     $FreeBSD: src/usr.sbin/pw/pw_log.c,v 1.4.2.2 2000/06/28 22:48:14 ache Exp $

	pw_nis.c:
	     $FreeBSD: src/usr.sbin/pw/pw_nis.c,v 1.4.2.3 2000/06/28 22:48:14 ache Exp $

	pw_user.c:
	     $FreeBSD: src/usr.sbin/pw/pw_user.c,v 1.25.2.5 2000/06/28 22:48:14 ache Exp $

	pw_vpw.c:
	     $FreeBSD: src/usr.sbin/pw/pw_vpw.c,v 1.2.2.3 2000/06/28 22:48:15 ache Exp $

	pwupd.c:
	     $FreeBSD: src/usr.sbin/pw/pwupd.c,v 1.7.2.5 2000/06/28 22:48:15 ache Exp $

	pwupd.h:
	     $FreeBSD: src/usr.sbin/pw/pwupd.h,v 1.4.2.4 2000/06/28 22:48:15 ache Exp $

	rm_r.c:
	     $FreeBSD: src/usr.sbin/pw/rm_r.c,v 1.4.2.2 2000/06/28 22:48:15 ache Exp $



>Description:

	When you try changing the home directory of an account 
	with "pw usermod -d ...", the home directory is *not* 
	changed. This used to work in earlier 4-STABLEs.

>How-To-Repeat:

	root@bagheera# pw usershow mb
	mb:*:1001:1001::0:0:Martin Butkus:/home/mb:/usr/local/bin/zsh

	root@bagheera# pw usermod -n mb -d /

	root@bagheera# pw usershow mb
	mb:*:1001:1001::0:0:Martin Butkus:/home/mb:/usr/local/bin/zsh

	root@bagheera# grep "^mb:" /etc/passwd 
	mb:*:1001:1001:Martin Butkus:/home/mb:/usr/local/bin/zsh

>Fix:

	None known, sorry.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->davidn 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Jul 3 02:13:44 PDT 2000 
Responsible-Changed-Why:  
David's interested in these. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19649 
State-Changed-From-To: open->closed 
State-Changed-By: davidn 
State-Changed-When: Mon Jul 3 22:14:00 EST 2000 
State-Changed-Why:  
Fixed in rev. 1.39 of pw_user.c in -current, and MFC to 
4.0-stable shortly. Thanks for the bug report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19649 

From: Peter Pentchev <roam@orbitel.bg>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: bin/19649: ``pw usermod -n user -d /new/homedir'' does nothing
Date: Fri, 14 Jul 2000 17:28:58 +0300

 The attached patch solves this problem for me; IMHO, there's
 no reason not to commit it to RELENG_4 before 4.1-RELEASE.
 
 G'luck,
 Peter Pentchev
 
 ----------------------------------------------
 This would easier understand fewer had omitted.
 
 diff -u src/usr.sbin/pw/pw_user.c mysrc/usr.sbin/pw/pw_user.c
 --- src/usr.sbin/pw/pw_user.c	Mon Jul  3 11:47:50 2000
 +++ mysrc/usr.sbin/pw/pw_user.c	Mon Jul  3 11:46:56 2000
 @@ -537,6 +537,7 @@
  				  warnx("WARNING: home `%s' does not exist", pwd->pw_dir);
  			} else if (!S_ISDIR(st.st_mode))
  				warnx("WARNING: home `%s' is not a directory", pwd->pw_dir);
 +			edited = 1;
  		}
  
  		if ((arg = getarg(args, 'w')) != NULL && getarg(args, 'h') == NULL) {
 

From: Peter Pentchev <roam@orbitel.bg>
To: freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: bin/19649: ``pw usermod -n user -d /new/homedir'' does nothing
Date: Fri, 14 Jul 2000 17:41:44 +0300

 Hmm sorry for the last post; never noticed the person responsible
 had actually fixed this in -current :(
 Still, this does look like a pretty strong MFC candidate to me.
 
 G'luck,
 Peter
 
 ----------------------------------------------
 This sentence was in the past tense.
 
>Unformatted:
