From nobody@FreeBSD.ORG  Mon Jun  5 05:25:52 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0EEC137B581; Mon,  5 Jun 2000 05:25:52 -0700 (PDT)
Message-Id: <20000605122552.0EEC137B581@hub.freebsd.org>
Date: Mon,  5 Jun 2000 05:25:52 -0700 (PDT)
From: mdiers@web.de
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: RELENG_2/syslogd: bad MFC breaks buildworld
X-Send-Pr-Version: www-1.0

>Number:         19015
>Category:       bin
>Synopsis:       RELENG_2/syslogd: bad MFC breaks buildworld
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 05 05:30:01 PDT 2000
>Closed-Date:    Mon Jun 5 13:07:54 PDT 2000
>Last-Modified:  Mon Jun 05 13:09:10 PDT 2000
>Originator:     Michael Diers
>Release:        RELENG_2 2000-06-05
>Organization:
>Environment:
>Description:
syslogd.c

revision 1.12.2.19
date: 2000/06/02 01:38:13;  author: peter;  state: Exp;  lines: +3 -3
MFC rev 1.54: Fix page fault in -vv mode.

The change 1.12.2.18/1.12.2.19 doesn't match 1.53/1.54.
>How-To-Repeat:
# make buildworld

[...]
===> usr.sbin/syslogd
cc -nostdinc -O -pipe   -I/usr/obj/usr/src/tmp/usr/include -c /usr/src/usr.sbin/
syslogd/syslogd.c
/usr/src/usr.sbin/syslogd/syslogd.c: In function `fprintlog':
/usr/src/usr.sbin/syslogd/syslogd.c:822: structure has no member named `name'
/usr/src/usr.sbin/syslogd/syslogd.c:828: structure has no member named `name'
*** Error code 1

Stop.

>Fix:
Index: syslogd.c
===================================================================
RCS file: /home/ncvs/src/usr.sbin/syslogd/syslogd.c,v
retrieving revision 1.12.2.19
diff -u -r1.12.2.19 syslogd.c
--- syslogd.c	2000/06/02 01:38:13	1.12.2.19
+++ syslogd.c	2000/06/05 11:02:35
@@ -819,13 +819,13 @@
 		if (LogFacPri > 1) {
 		  CODE *c;
 
-		  for (c = facilitynames; c->name; c++) {
+		  for (c = facilitynames; c->c_name; c++) {
 		    if (c->c_val == fac) {
 		      f_s = c->c_name;
 		      break;
 		    }
 		  }
-		  for (c = prioritynames; c->name; c++) {
+		  for (c = prioritynames; c->c_name; c++) {
 		    if (c->c_val == pri) {
 		      p_s = c->c_name;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: nrahlstr 
State-Changed-When: Mon Jun 5 13:07:54 PDT 2000 
State-Changed-Why:  
Fixed in revision 1.12.2.20 of syslogd.c by Peter. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=19015 
>Unformatted:
