From serg@bcs3.bcs.zp.ua  Mon May 22 02:30:58 2000
Return-Path: <serg@bcs3.bcs.zp.ua>
Received: from relay1.bcs.zp.ua (bcs-mgts.bcs.zp.ua [212.8.35.251])
	by hub.freebsd.org (Postfix) with ESMTP id 22C3137BA36
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 May 2000 02:30:34 -0700 (PDT)
	(envelope-from serg@bcs3.bcs.zp.ua)
Received: from bcs3.bcs.zp.ua (bcs3.bcs.zp.ua [212.8.35.73])
	by relay1.bcs.zp.ua (8.9.3/8.9.3) with ESMTP id MAA68610
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 22 May 2000 12:30:09 +0300 (EEST)
Received: (from serg@localhost)
	by bcs3.bcs.zp.ua (8.9.3/8.9.3) id MAA51189;
	Mon, 22 May 2000 12:30:09 +0300 (EEST)
	(envelope-from serg)
Message-Id: <200005220930.MAA51189@bcs3.bcs.zp.ua>
Date: Mon, 22 May 2000 12:30:09 +0300 (EEST)
From: Sergey Shkonda <serg@bcs.zp.ua>
Sender: serg@bcs3.bcs.zp.ua
Reply-To: serg@bcs.zp.ua
To: FreeBSD-gnats-submit@freebsd.org
Subject: times.allow in login.conf
X-Send-Pr-Version: 3.2

>Number:         18742
>Category:       bin
>Synopsis:       [patch] times.allow field parsed incorrectly
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    linimon
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 22 02:40:01 PDT 2000
>Closed-Date:    Mon Apr 03 21:54:48 GMT 2006
>Last-Modified:  Mon Apr 03 21:54:48 GMT 2006
>Originator:     Sergey Shkonda
>Release:        FreeBSD
>Organization:
Business Computer Service
>Environment:

	

>Description:

	times.allow incorrectly handled in case of
		2200-0700
	
>How-To-Repeat:
>Fix:
	
	
	a) Document this
	b) Change login_times.c:
	parse_lt():

	if (*p == '-')
		p = parse_time(++p, &m.lt_end);
	else
		m.lt_end = 1440;
+	if (m.lt_end < m.lt_start)
+		m.lt_end += 1440;

	t = m;
    }
    return t;
}

--
Sergey Shkonda           <serg@bcs.zp.ua>

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: mike 
State-Changed-When: Sat Jul 21 19:42:50 PDT 2001 
State-Changed-Why:  

Does this problem still occur in newer versions of FreeBSD, 
such as 4.3-RELEASE? 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=18742 

From: Mike Barcroft <mike@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: bin/18742: times.allow field parsed incorrectly
Date: Mon, 23 Jul 2001 12:34:25 -0400

 Adding to Audit-Trail.
 
 ----- Forwarded message from Sergey Shkonda <serg@bcs.zp.ua> -----
 
 Delivered-To: mike@freebsd.org
 From: Sergey Shkonda <serg@bcs.zp.ua>
 Subject: Re: bin/18742: times.allow field parsed incorrectly
 X-ELM-OSV: (Our standard violations) hdr-charset=KOI8-U
 In-Reply-To: <200107220243.f6M2hCN83847@freefall.freebsd.org>
  "from mike@FreeBSD.org at Jul 21, 2001 07:43:12 pm"
 To: mike@FreeBSD.org
 Date: Mon, 23 Jul 2001 12:17:07 +0300 (EEST)
 X-Mailer: ELM [version 2.4ME+ PL88 (25)]
 
 > Synopsis: times.allow field parsed incorrectly
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: mike
 > State-Changed-When: Sat Jul 21 19:42:50 PDT 2001
 > State-Changed-Why: 
 > 
 > Does this problem still occur in newer versions of FreeBSD,
 > such as 4.3-RELEASE?
   Yes. There is the patch:
 
 --- login_times.c	1999/08/28 00:05:48	1.7
 +++ login_times.c	2001/07/23 09:12:58
 @@ -99,6 +99,8 @@
  	    p = parse_time(++p, &m.lt_end);
  	else
  	    m.lt_end = 1440;
 +	if (m.lt_end < m.lt_start)
 +	    m_lt_end += 1440;
  
  	t = m;
      }
 
 
 --
 Sergey Shkonda           <serg@bcs.zp.ua>
 
 ----- End forwarded message -----
State-Changed-From-To: feedback->suspended 
State-Changed-By: mike 
State-Changed-When: Mon Jul 23 16:57:06 PDT 2001 
State-Changed-Why:  

Still a problem. 


Responsible-Changed-From-To: freebsd-bugs->mike 
Responsible-Changed-By: mike 
Responsible-Changed-When: Mon Jul 23 16:57:06 PDT 2001 
Responsible-Changed-Why:  

I'll take a look at this one. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=18742 
State-Changed-From-To: suspended->feedback 
State-Changed-By: linimon 
State-Changed-When: Mon Apr 3 21:26:29 UTC 2006 
State-Changed-Why:  
Is this still a problem with recent versions of FreeBSD? 


Responsible-Changed-From-To: mike->linimon 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Apr 3 21:26:29 UTC 2006 
Responsible-Changed-Why:  
Reset PR assigned to inactive committer who has not responded to email. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=18742 
State-Changed-From-To: feedback->closed 
State-Changed-By: linimon 
State-Changed-When: Mon Apr 3 21:54:36 UTC 2006 
State-Changed-Why:  
Submitter's email address bounces. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=18742 
>Unformatted:
