From jhs@berklix.com  Tue Dec 10 00:55:32 2013
Return-Path: <jhs@berklix.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 5D9E5A77
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Dec 2013 00:55:32 +0000 (UTC)
Received: from land.berklix.org (land.berklix.org [144.76.10.75])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id D929D114F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 10 Dec 2013 00:55:31 +0000 (UTC)
Received: from mart.js.berklix.net (p57BCFB4E.dip0.t-ipconnect.de [87.188.251.78])
	(authenticated bits=128)
	by land.berklix.org (8.14.5/8.14.5) with ESMTP id rBA0tJ3V004178;
	Tue, 10 Dec 2013 00:55:20 GMT
	(envelope-from jhs@berklix.com)
Received: from lapr.js.berklix.net (lapr.js.berklix.net [192.168.91.68])
	by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id rBA0tFtq059601;
	Tue, 10 Dec 2013 01:55:15 +0100 (CET)
	(envelope-from jhs@lapr.js.berklix.net)
Received: from lapr.js.berklix.net (localhost.js.berklix.net [127.0.0.1])
	by lapr.js.berklix.net (8.14.7/8.14.7) with ESMTP id rBA0t5Dj001689;
	Tue, 10 Dec 2013 00:55:10 GMT
	(envelope-from jhs@lapr.js.berklix.net)
Received: (from jhs@localhost)
	by lapr.js.berklix.net (8.14.7/8.14.7/Submit) id rBA0ssvP001663;
	Tue, 10 Dec 2013 01:54:54 +0100 (CET)
	(envelope-from jhs)
Message-Id: <201312100054.rBA0ssvP001663@lapr.js.berklix.net>
Date: Tue, 10 Dec 2013 01:54:54 +0100 (CET)
From: "Julian H. Stacey" <jhs@berklix.com>
Reply-To: "Julian H. Stacey" <jhs@berklix.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: "Julian H. Stacey" <jhs@berklix.com>
Subject: Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4
X-Send-Pr-Version: 3.114
X-GNATS-Notify:

>Number:         184648
>Category:       bin
>Synopsis:       Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 10 01:00:00 UTC 2013
>Closed-Date:    Sat Mar 15 21:14:36 UTC 2014
>Last-Modified:  Sat Mar 15 21:14:36 UTC 2014
>Originator:     Julian H. Stacey
>Release:        FreeBSD 10.0-BETA4 amd64
>Organization:
/home/jhs/.organization
>Environment:
System: FreeBSD lapr.js.berklix.net 10.0-BETA4 FreeBSD 10.0-BETA4 #0: Tue Dec 3 20:11:41 CET 2013 jhs@lapr.js.berklix.net:/usr/src/sys/amd64/compile/LAPR.small amd64


	
>Description:
	Regression: some comments in calendar OK in 9.1, fail in 10.0-BETA4

>How-To-Repeat:
	
	Put this in your ~/.calendar/calendar 
	(Either do not use a mouse to copy, or if you do, repair tabs after)
--- cut --- Start of Input Test Data
Wednesday	Test 1
/* Test 1, First of 2 lines of comments beginning on left margin
  Test 1, second of 2 lines, beginning with 2 spaces */

Wednesday	Test 2
/* Test 2, First of 2 lines of comments beginning on left margin 
	Test 2, second of 2 lines, beginning with 1 tab */

Wednesday	Test 3
  /* Test 3, First of 2 lines of comments beginning with 2 spaces
  Test 3, second of 2 lines, beginning with 2 spaces 3 */

Wednesday	Test 4
	/* Test 4, First of 2 lines of comments beginning with 1 tab
  Test 4, second of 2 lines, beginning with 2 spaces */

Wednesday	Test 5
	/* Test 5, First of 2 lines of comments beginning with 1 tab
	Test 5, second of 2 lines, beginning with 1 tab */
--- cut --- End Of Input Test Data, + Start of good output from 9.1-RELEASE
Dec 11* Test 5
Dec 11* Test 4
Dec 11* Test 3
Dec 11* Test 2
Dec 11* Test 1
--- cut --- Start of bad output from 10.0-BETA4
Dec 11*	Test 5
	/* Test 5, First of 2 lines of comments beginning with 1 tab
	Test 5, second of 2 lines, beginning with 1 tab */
Dec 11*	Test 4
	/* Test 4, First of 2 lines of comments beginning with 1 tab
Dec 11*	Test 3
Dec 11*	Test 2
	Test 2, second of 2 lines, beginning with 1 tab */
Dec 11*	Test 1
--- cut ---

>Fix:

	
I assume it's yet another problem from changing the compiler & thus cpp.
It only fails wth a leading tab, not leading spaces.

One could weasel out by quoting man calendar text
	"If the first character in the line is a <tab>
	character, it is treated as a continuation of the
	previous line"
which preceeds
	"Empty lines and lines pro- tected by the C commenting
	syntax (/* ... */) are ignored."
But it used to work, & the manual has not changed its wording,
just the binary now functions worse.

I'll keep a note of this send-pr at:
http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.comments_delimiting+cpp.no_customise
>Release-Note:
>Audit-Trail:

From: Eitan Adler <lists@eitanadler.com>
To: "Julian H. Stacey" <jhs@berklix.com>, Diane Bruce <db@db.net>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/184648: Regression: some comments in calendar OK in 9.1, fail
 in 10.0-BETA4
Date: Mon, 9 Dec 2013 20:08:08 -0500

 On Mon, Dec 9, 2013 at 7:54 PM, Julian H. Stacey <jhs@berklix.com> wrote:
 >...
 > I assume it's yet another problem from changing the compiler & thus cpp.
 
 This assumption is wrong.  It likely originates from the addition of
 cpp like behavior to calendar itself.
 
 db@, can you please have a look?
 
 
 -- 
 Eitan Adler

From: "Matthew D. Fuller" <fullermd@over-yonder.net>
To: "Julian H. Stacey" <jhs@berklix.com>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: bin/184648: Regression: some comments in calendar OK in 9.1,
 fail in 10.0-BETA4
Date: Mon, 9 Dec 2013 19:12:14 -0600

 > I assume it's yet another problem from changing the compiler & thus
 > cpp.
 
 Technically, it's due to no longer using cpp at all, but implementing
 pieces of it internally in
 
 <http://svnweb.freebsd.org/base?view=revision&revision=255715>
 
 X-ref a mail I sent to -current about hiccups it left, including a
 comment-related one:
 
 <http://lists.freebsd.org/pipermail/freebsd-current/2013-October/045829.html>

From: oliver <oliver@beefrankly.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/184648: Regression: some comments in calendar OK in 9.1,
 fail in 10.0-BETA4
Date: Sat, 15 Mar 2014 19:11:53 +0100

 Duplicate / same issue as bin/186294
 
 A patch that fixes this issue can be found there.
 
 Greetings, oliver
 
 
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Sat Mar 15 21:14:16 UTC 2014 
State-Changed-Why:  
see bin/186294. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=184648 
>Unformatted:
