From nobody@FreeBSD.org  Wed Nov 20 12:23:33 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTPS id 108E059B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Nov 2013 12:23:33 +0000 (UTC)
Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id DAEDE266D
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Nov 2013 12:23:32 +0000 (UTC)
Received: from oldred.freebsd.org ([127.0.1.6])
	by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id rAKCNWju046976
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Nov 2013 12:23:32 GMT
	(envelope-from nobody@oldred.freebsd.org)
Received: (from nobody@localhost)
	by oldred.freebsd.org (8.14.5/8.14.5/Submit) id rAKCNWNu046960;
	Wed, 20 Nov 2013 12:23:32 GMT
	(envelope-from nobody)
Message-Id: <201311201223.rAKCNWNu046960@oldred.freebsd.org>
Date: Wed, 20 Nov 2013 12:23:32 GMT
From: Tomasz CEDRO <cederom@tlen.pl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dhclient does not parse /etc/dhclient.conf correctly
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         184117
>Category:       bin
>Synopsis:       dhclient(8): dhclient does not parse /etc/dhclient.conf correctly
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 20 12:30:01 UTC 2013
>Closed-Date:    
>Last-Modified:  Thu Nov 21 06:20:00 UTC 2013
>Originator:     Tomasz CEDRO
>Release:        9.2-RELEASE
>Organization:
CeDeROM
>Environment:
FreeBSD mercury.rd.tp.pl 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013     root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
I need to send additional options with dhcp request, so I add "send"
option for an interface in /etc/dhclient.conf, however options are non-
standard and they are not sent in dhcp request. I have noticed that
other options with names known to dhcp-options and other decimal numbers
are sent correctly...

These options work with isc-42-dhcp-client port as they know the string
alias for the option number...

I would expect base dhclient to work with any "option-nnn" decimal value
provided, no matter if the string alias is defined for this option or not
and what is the current IETF document release based upon :-)


Accorging to dhcp-options manual:

     The documentation for the various options mentioned below is taken from
     the IETF draft document on DHCP options, RFC 2132.  Options which are not
     listed by name may be defined by the name option-nnn, where nnn is the
     decimal number of the option code.  These options may be followed either
     by a string, enclosed in quotes, or by a series of octets, expressed as
     two-digit hexadecimal numbers separated by colons.  For example:

           option option-133 "my-option-133-text";
           option option-129 1:54:c9:2b:47;

     Because dhcpd(8) does not know the format of these undefined option
     codes, no checking is done to ensure the correctness of the entered data.

>How-To-Repeat:
Here is my example /etc/dhclient.conf configuation:

interface "em0"{
 send option-060 "vendor"; <-- does not go out in dhcp request
 send option-077 "user"; <-- does not go out in dhcp request
 send option-123 "blah123"; <-- goes out in dhcp request
 send root-path "blahroot"; <-- goes out in dhcp request
}
>Fix:
I expect dhclient to work with any "option-nnn" decimal value provided,
no matter if the string alias is defined for this option or not and what
is the current IETF document release based upon, that would make software
more versatile and consistent :-) Thank you :-)

>Release-Note:
>Audit-Trail:

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/184117: dhclient does not parse /etc/dhclient.conf correctly
Date: Thu, 21 Nov 2013 00:19:51 -0600

 ----- Forwarded message from Lowell Gilbert <freebsd-bugs-local@be-well.ilk.org> -----
 
 Date: Wed, 20 Nov 2013 09:57:53 -0500
 From: Lowell Gilbert <freebsd-bugs-local@be-well.ilk.org>
 To: freebsd-bugs@freebsd.org
 Subject: Re: misc/184117: dhclient does not parse /etc/dhclient.conf correctly
 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
 
 Making all options work with the "option-nnn" syntax would best be done
 by importing a newer version of the ISC code. For defined option types,
 it's better to use the official names because that way type handling is
 enabled as well.
 
 The user-class option is not in the dhcp_option_default_priority_list
 array in sbin/dhclient/tables.c. Adding it (DHO_DHCP_USER_CLASS_ID) will
 make the user-class option work. I.E.:
 
 --- tables.c.~1~    2013-11-20 09:52:25.521743815 -0500
 +++ tables.c        2013-11-20 09:53:33.733663843 -0500
 @@ -365,6 +365,7 @@
 	DHO_INTERFACE_MTU,
 	DHO_ALL_SUBNETS_LOCAL,
 	DHO_BROADCAST_ADDRESS,
 +        DHO_DHCP_USER_CLASS_ID
 	DHO_PERFORM_MASK_DISCOVERY,
 	DHO_MASK_SUPPLIER,
 	DHO_ROUTER_DISCOVERY,
 
 _______________________________________________
 freebsd-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
 To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
 
 
 ----- End forwarded message -----
>Unformatted:
