From BM-2cXppXU4T67w7j6NCir9T1WdzBHmFgBnLj@bitmessage.ch  Wed Oct 30 19:11:58 2013
Return-Path: <BM-2cXppXU4T67w7j6NCir9T1WdzBHmFgBnLj@bitmessage.ch>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 681B9FE3
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 Oct 2013 19:11:58 +0000 (UTC)
	(envelope-from BM-2cXppXU4T67w7j6NCir9T1WdzBHmFgBnLj@bitmessage.ch)
Received: from mail.bitmessage.ch (mail.bitmessage.ch [146.228.112.252])
	by mx1.freebsd.org (Postfix) with SMTP id CB1EC2C34
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 Oct 2013 19:11:57 +0000 (UTC)
Received: from nil ([127.0.0.1])
	by mail.bitmessage.ch
	; Wed, 30 Oct 2013 20:11:45 +0100
Message-Id: <20131030.86txfyh8vf@bitmessage.ch>
Date: Wed, 30 Oct 2013 20:11:16 +0100
From: Stefan Neudorf <BM-2cXppXU4T67w7j6NCir9T1WdzBHmFgBnLj@bitmessage.ch>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [PATCH] usr.bin/limits: cannot set kqueues limit
X-GNATS-Notify: kib@FreeBSD.org

>Number:         183494
>Category:       bin
>Synopsis:       [PATCH] limits(1): usr.bin/limits: cannot set kqueues limit
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 30 19:20:00 UTC 2013
>Closed-Date:    
>Last-Modified:  Sun May 04 03:38:49 UTC 2014
>Originator:     Stefan Neudorf
>Release:        
>Organization:
>Environment:
>Description:
r256850 added kqueues limit but failed to update getopt() call leading
to -k option (similar to sh's ulimit -k) not being recognized.
>How-To-Repeat:
 $ limits -k 5
 usage: limits [-C class|-P pid|-U user] [-eaSHBE] [-bcdflmnstuvpw [val]] [[name=val ...] cmd]
>Fix:
--- kqueues_limit.diff begins here ---
Index: usr.bin/limits/limits.c
===================================================================
--- usr.bin/limits/limits.c	(revision 257346)
+++ usr.bin/limits/limits.c	(working copy)
@@ -248,7 +249,7 @@ static struct {
  * to be modified accordingly!
  */
 
-#define RCS_STRING  "tfdscmlunbvpw"
+#define RCS_STRING  "tfdscmlunbvpwk"
 
 static rlim_t resource_num(int which, int ch, const char *str);
 static void usage(void);
@@ -287,7 +288,7 @@ main(int argc, char *argv[])
 
     pid = -1;
     optarg = NULL;
-    while ((ch = getopt(argc, argv, ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:")) != -1) {
+    while ((ch = getopt(argc, argv, ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:k:")) != -1) {
 	switch(ch) {
 	case 'a':
 	    doall = 1;
@@ -544,7 +545,7 @@ usage(void)
 {
     (void)fprintf(stderr,
 	"usage: limits [-C class|-P pid|-U user] [-eaSHBE] "
-	"[-bcdflmnstuvpw [val]] [[name=val ...] cmd]\n");
+	"[-bcdflmnstuvpwk [val]] [[name=val ...] cmd]\n");
     exit(EXIT_FAILURE);
 }
 
--- kqueues_limit.diff ends here ---

>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/183494: commit references a PR
Date: Thu, 31 Oct 2013 09:03:50 +0000 (UTC)

 Author: kib
 Date: Thu Oct 31 09:03:42 2013
 New Revision: 257428
 URL: http://svnweb.freebsd.org/changeset/base/257428
 
 Log:
   Fix long line and record proper commit message for r257427:
   Add the '-k' option for getopt() call and usage.
   
   Submitted by:	Stefan Neudorf
   PR:	bin/183494
   MFC after:	1 week
 
 Modified:
   head/usr.bin/limits/limits.c
 
 Modified: head/usr.bin/limits/limits.c
 ==============================================================================
 --- head/usr.bin/limits/limits.c	Thu Oct 31 08:58:32 2013	(r257427)
 +++ head/usr.bin/limits/limits.c	Thu Oct 31 09:03:42 2013	(r257428)
 @@ -287,7 +287,8 @@ main(int argc, char *argv[])
  
      pid = -1;
      optarg = NULL;
 -    while ((ch = getopt(argc, argv, ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:k:")) != -1) {
 +    while ((ch = getopt(argc, argv,
 +      ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:k:")) != -1) {
  	switch(ch) {
  	case 'a':
  	    doall = 1;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
