From pi@home.opsec.eu  Sun Aug 25 18:51:41 2013
Return-Path: <pi@home.opsec.eu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by hub.freebsd.org (Postfix) with ESMTP id 69FA1EE8;
	Sun, 25 Aug 2013 18:51:41 +0000 (UTC)
	(envelope-from pi@home.opsec.eu)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.freebsd.org (Postfix) with ESMTPS id 2805E2C5B;
	Sun, 25 Aug 2013 18:51:39 +0000 (UTC)
Received: from pi by home.opsec.eu with local (Exim 4.80.1 (FreeBSD))
	(envelope-from <pi@home.opsec.eu>)
	id 1VDfPW-000MD0-6C; Sun, 25 Aug 2013 20:51:38 +0200
Message-Id: <E1VDfPW-000MD0-6C@home.opsec.eu>
Date: Sun, 25 Aug 2013 20:51:38 +0200
From: Kurt Jaeger <fbsd-pr@opsec.eu>
Reply-To: Kurt Jaeger <fbsd-pr@opsec.eu>
To: FreeBSD-gnats-submit@freebsd.org
Cc: pawel@FreeBSD.org
Subject: 'route get' without destination gives misleading error message 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         181532
>Category:       bin
>Synopsis:       [patch] route(8): 'route get' without destination gives misleading error message
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    glebius
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 25 19:00:00 UTC 2013
>Closed-Date:    Wed Jan 22 09:42:36 UTC 2014
>Last-Modified:  Wed Jan 22 09:42:36 UTC 2014
>Originator:     Kurt Jaeger
>Release:        FreeBSD 9.1-RELEASE amd64
>Organization:
-
>Environment:
System: FreeBSD home.opsec.eu 9.1-RELEASE FreeBSD 9.1-RELEASE #0 r243825: Tue Dec 4 09:23:10 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64


>Description:

If you type

route get

the error message is strange/misleading:

route: writing to routing socket: Invalid argument

The patch changes this to:

route get requires a parameter, try 'default'

>How-To-Repeat:
	route get

>Fix:

--- route.c	2012-12-03 19:43:01.000000000 +0100
+++ /usr/home/pi/src/route/route.c	2013-08-25 20:46:13.000000000 +0200
@@ -1229,6 +1229,11 @@
 
 	if (rtm_addrs & RTA_NETMASK)
 		mask_addr();
+	if ( so_dst.sa.sa_len == 0 && cmd == RTM_GET ) {
+		fprintf(stderr,
+			"route get requires a parameter, try 'default'\n");
+		exit(1);
+	}
 	NEXTADDR(RTA_DST, so_dst);
 	NEXTADDR(RTA_GATEWAY, so_gate);
 	NEXTADDR(RTA_NETMASK, so_mask);

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: glebius 
State-Changed-When: Tue Oct 8 08:15:29 UTC 2013 
State-Changed-Why:  
Fixed in head/. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181532 
Responsible-Changed-From-To: freebsd-bugs->glebius 
Responsible-Changed-By: glebius 
Responsible-Changed-When: Tue Oct 8 08:16:53 UTC 2013 
Responsible-Changed-Why:  
Track it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181532 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/181532: commit references a PR
Date: Tue,  8 Oct 2013 08:16:25 +0000 (UTC)

 Author: glebius
 Date: Tue Oct  8 08:16:17 2013
 New Revision: 256137
 URL: http://svnweb.freebsd.org/changeset/base/256137
 
 Log:
     When destination parameter is missing, exit with a clear synopsis,
   instead of writing to kernel and printing EINVAL description.
   
   PR:		bin/181532
   Submitted by:	Kurt Jaeger <fbsd-pr opsec.eu>
   Approved by:	re (hrs)
 
 Modified:
   head/sbin/route/route.c
 
 Modified: head/sbin/route/route.c
 ==============================================================================
 --- head/sbin/route/route.c	Tue Oct  8 07:02:23 2013	(r256136)
 +++ head/sbin/route/route.c	Tue Oct  8 08:16:17 2013	(r256137)
 @@ -928,6 +928,11 @@ newroute(int argc, char **argv)
  		}
  	}
  
 +	if (so[RTAX_DST].ss_len == 0) {
 +		warnx("destination parameter required");
 +		usage(NULL);
 +	}
 +
  	if (nrflags & F_FORCEHOST) {
  		nrflags |= F_ISHOST;
  #ifdef INET6
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Wed Jan 22 09:42:25 UTC 2014 
State-Changed-Why:  
Fixed in 10.0-RELEASE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=181532 
>Unformatted:
