From nobody@FreeBSD.org  Sun Apr  9 03:22:09 2000
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 5AC2537B667
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  9 Apr 2000 03:22:09 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id DAA36316;
	Sun, 9 Apr 2000 03:22:09 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Message-Id: <200004091022.DAA36316@freefall.freebsd.org>
Date: Sun, 9 Apr 2000 03:22:09 -0700 (PDT)
From: pius@zyan.com
Sender: nobody@FreeBSD.org
To: freebsd-gnats-submit@FreeBSD.org
Subject: Cannot change login group with "pw usermod -g" (on FreeBSD 4.0 only)
X-Send-Pr-Version: www-1.0

>Number:         17877
>Category:       bin
>Synopsis:       Cannot change login group with "pw usermod -g" (on FreeBSD 4.0 only)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    davidn
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Apr  9 03:30:01 PDT 2000
>Closed-Date:    Sun Jun 18 12:48:54 EST 2000
>Last-Modified:  Sun Jun 18 12:49:53 EST 2000
>Originator:     Pius Fischer
>Release:        4.0-20000208-CURRENT
>Organization:
Zyan Communications
>Environment:
FreeBSD axilla2.zyan.com 4.0-20000208-CURRENT FreeBSD 4.0-20000208-CURRENT #0: Fri Feb 18 14:54:38 PST 2000     pius@axilla2.zyan.com:/usr/src/sys/compile/AXILLA2  i386

>Description:
Due to the changes made in revision 1.33 of pw_user.c,
"pw usermod <user> -g <group>" can no longer be used to change
a user's login group.

>How-To-Repeat:
On a FreeBSD 4.0 system, try to use "pw usermod <user> -g <group>"
to change the login group of a user.

>Fix:
A simple patch:

=cut=
--- usr.sbin/pw/pw_user.c.orig	Fri Jan 14 16:20:21 2000
+++ usr.sbin/pw/pw_user.c	Sat Apr  8 23:41:26 2000
@@ -468,7 +468,7 @@
 			gid_t newgid = (gid_t) GETGRNAM(cnf->default_group)->gr_gid;
 			if (newgid != pwd->pw_gid) {
 				edited = 1;
-				pwd->pw_gid = pwd->pw_gid;
+				pwd->pw_gid = newgid;
 			}
 		}
 
=cut=


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->davidn 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Tue Apr 11 07:11:09 PDT 2000 
Responsible-Changed-Why:  
David, could you take a look at this one? 
State-Changed-From-To: open->closed 
State-Changed-By: davidn 
State-Changed-When: Sun Jun 18 12:48:54 EST 2000 
State-Changed-Why:  
Fixed in: 
/home/ncvs/src/usr.sbin/pw/pw_user.c,v  <--  pw_user.c 
new revision: 1.36; previous revision: 1.35 
Will be merged into 3.X/4.X shortly. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=17877 
>Unformatted:
