From nobody@FreeBSD.org  Sat Feb  9 00:18:41 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id 077129A7
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  9 Feb 2013 00:18:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D70CEB23
	for <freebsd-gnats-submit@FreeBSD.org>; Sat,  9 Feb 2013 00:18:40 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r190IeJP093091
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 9 Feb 2013 00:18:40 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r190Iewu093090;
	Sat, 9 Feb 2013 00:18:40 GMT
	(envelope-from nobody)
Message-Id: <201302090018.r190Iewu093090@red.freebsd.org>
Date: Sat, 9 Feb 2013 00:18:40 GMT
From: William Ahern <william@25thandclement.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Typo in hexdump/conv.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175975
>Category:       bin
>Synopsis:       hexdump(1): typo in hexdump/conv.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Feb 09 00:20:00 UTC 2013
>Closed-Date:    Tue Apr 30 02:08:04 UTC 2013
>Last-Modified:  Tue Apr 30 02:08:04 UTC 2013
>Originator:     William Ahern
>Release:        9.0-RELEASE
>Organization:
>Environment:
FreeBSD fbsd 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:46:30 UTC 2012     root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
usr.bin/hexdump/conv.c contains a typo at line 154. Instead of "dc1", there's "dcl". That is, it contains the letter "l" instead of the number "1". The man page correctly documents "dc1". This is fixed for OS X. I discovered this when testing my own implementation of hexdump at http://25thandclement.com/~william/projects/hexdump.c.html


>How-To-Repeat:
hexdump -e '16 "%3_u " "\n"' /dev/urandom | grep -e dcl -e dc1 | head

>Fix:
Fix the typo.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sat Feb 9 00:21:08 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175975 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Sat Feb 9 00:22:20 UTC 2013 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175975 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/175975: commit references a PR
Date: Mon,  4 Mar 2013 02:21:23 +0000 (UTC)

 Author: eadler
 Date: Mon Mar  4 02:21:06 2013
 New Revision: 247753
 URL: http://svnweb.freebsd.org/changeset/base/247753
 
 Log:
   Fix typo ('1' != 'l')
   
   PR:		bin/175975
   Submitted by:	William Ahern <william@25thandclement.com>
   Approved by:	cperciva (mentor)
 
 Modified:
   head/usr.bin/hexdump/conv.c
 
 Modified: head/usr.bin/hexdump/conv.c
 ==============================================================================
 --- head/usr.bin/hexdump/conv.c	Mon Mar  4 02:21:03 2013	(r247752)
 +++ head/usr.bin/hexdump/conv.c	Mon Mar  4 02:21:06 2013	(r247753)
 @@ -151,7 +151,7 @@ conv_u(PR *pr, u_char *p)
  	static char const * list[] = {
  		"nul", "soh", "stx", "etx", "eot", "enq", "ack", "bel",
  		 "bs",  "ht",  "lf",  "vt",  "ff",  "cr",  "so",  "si",
 -		"dle", "dcl", "dc2", "dc3", "dc4", "nak", "syn", "etb",
 +		"dle", "dc1", "dc2", "dc3", "dc4", "nak", "syn", "etb",
  		"can",  "em", "sub", "esc",  "fs",  "gs",  "rs",  "us",
  	};
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Mon Mar 4 02:44:22 UTC 2013 
State-Changed-Why:  
committed in r247753 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175975 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Apr 30 02:08:01 UTC 2013 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175975 
>Unformatted:
