From nobody@FreeBSD.org  Fri Feb  8 23:18:54 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id BF2A6B53
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Feb 2013 23:18:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F119902
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Feb 2013 23:18:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r18NIsKm094981
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Feb 2013 23:18:54 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r18NIsI3094980;
	Fri, 8 Feb 2013 23:18:54 GMT
	(envelope-from nobody)
Message-Id: <201302082318.r18NIsI3094980@red.freebsd.org>
Date: Fri, 8 Feb 2013 23:18:54 GMT
From: Sascha Wildner <swildner@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: logic issue in ppp(8)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175974
>Category:       bin
>Synopsis:       ppp(8): logic issue
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-net
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Feb 08 23:20:00 UTC 2013
>Closed-Date:    Wed Oct 16 02:58:21 UTC 2013
>Last-Modified:  Wed Oct 16 03:00:00 UTC 2013
>Originator:     Sascha Wildner
>Release:        seen on current
>Organization:
DragonFly BSD
>Environment:
>Description:
usr.sbin/ppp/mppe.c has the following check in line 171:

if (*proto < 0x21 && *proto > 0xFA) {

My assumption is that it should be an || but I lack the MPPE clue to verify it.

Best regards,
Sascha

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-net 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Feb 8 23:52:20 UTC 2013 
Responsible-Changed-Why:  
change synopsis and assign 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175974 
State-Changed-From-To: open->closed 
State-Changed-By: kevlo 
State-Changed-When: Wed Oct 16 02:55:50 UTC 2013 
State-Changed-Why:  
Fixed.  Your assumption is correct.  Only protocol numbers 0x21 through 0xFA  
would be encrypted. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175974 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/175974: commit references a PR
Date: Wed, 16 Oct 2013 02:55:39 +0000 (UTC)

 Author: kevlo
 Date: Wed Oct 16 02:55:31 2013
 New Revision: 256574
 URL: http://svnweb.freebsd.org/changeset/base/256574
 
 Log:
   Fix logic error.  MPPE only accepts protocol numbers 0x21 through 0xFA.
   
   PR:	bin/175974
 
 Modified:
   head/usr.sbin/ppp/mppe.c
 
 Modified: head/usr.sbin/ppp/mppe.c
 ==============================================================================
 --- head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:46:00 2013	(r256573)
 +++ head/usr.sbin/ppp/mppe.c	Wed Oct 16 02:55:31 2013	(r256574)
 @@ -168,7 +168,7 @@ MPPEOutput(void *v, struct ccp *ccp, str
    dictinit = 0;
  
    log_Printf(LogDEBUG, "MPPE: Output: Proto %02x (%d bytes)\n", *proto, ilen);
 -  if (*proto < 0x21 && *proto > 0xFA) {
 +  if (*proto < 0x21 || *proto > 0xFA) {
      log_Printf(LogDEBUG, "MPPE: Output: Not encrypting\n");
      ccp->compout += ilen;
      ccp->uncompout += ilen;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
