From nobody@FreeBSD.org  Wed Jan 16 00:49:50 2013
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1])
	by hub.freebsd.org (Postfix) with ESMTP id B5949419
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Jan 2013 00:49:50 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 985119AD
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Jan 2013 00:49:50 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r0G0nm6Y021026
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 16 Jan 2013 00:49:48 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id r0G0nm7s021025;
	Wed, 16 Jan 2013 00:49:48 GMT
	(envelope-from nobody)
Message-Id: <201301160049.r0G0nm7s021025@red.freebsd.org>
Date: Wed, 16 Jan 2013 00:49:48 GMT
From: Marcus Reid <marcus@blazingdot.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ldd runs linux binaries instead of printing shared library dependencies
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         175339
>Category:       bin
>Synopsis:       ldd(1) runs linux binaries instead of printing shared library dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markj
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 16 00:50:01 UTC 2013
>Closed-Date:    Wed Aug 07 00:37:52 UTC 2013
>Last-Modified:  Wed Aug 07 00:37:52 UTC 2013
>Originator:     Marcus Reid
>Release:        9.0-STABLE
>Organization:
>Environment:
FreeBSD seabug 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Jan  9 10:53:27 PST 2012     root@seabug:/usr/obj/usr/src/sys/FARK  amd64
>Description:
ldd runs linux binaries instead of printing shared library dependencies.
For example, with linux-f10-flashplugin11 installed,
'ldd /usr/local/bin/flash-player-properties' will launch the flash player
preferences dialog in X.

This is confusing when using ldd systemwide to search for broken library
dependencies for example.
>How-To-Repeat:
ldd /usr/local/bin/flash-player-properties
>Fix:
Don't know, but ldd apparently passes something to rtld when it execs
the binary that the linux rtld doesn't understand.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->analyzed 
State-Changed-By: markj 
State-Changed-When: Mon Feb 18 05:03:50 UTC 2013 
State-Changed-Why:  
I'll take it. 


Responsible-Changed-From-To: freebsd-bugs->markj 
Responsible-Changed-By: markj 
Responsible-Changed-When: Mon Feb 18 05:03:50 UTC 2013 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175339 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/175339: commit references a PR
Date: Wed,  7 Aug 2013 00:28:30 +0000 (UTC)

 Author: markj
 Date: Wed Aug  7 00:28:17 2013
 New Revision: 254018
 URL: http://svnweb.freebsd.org/changeset/base/254018
 
 Log:
   Pass variables prefixed with both LD_ and LD_32_ to the run-time linker.
   This prevents unintentional execution of programs when running ldd(1) on
   32-bit Linux binaries.
   
   PR:		175339, 127276
   Suggested by:	kib, rstone
   Reviewed by:	kib
   MFC after:	2 weeks
 
 Modified:
   head/usr.bin/ldd/ldd.c
 
 Modified: head/usr.bin/ldd/ldd.c
 ==============================================================================
 --- head/usr.bin/ldd/ldd.c	Wed Aug  7 00:20:30 2013	(r254017)
 +++ head/usr.bin/ldd/ldd.c	Wed Aug  7 00:28:17 2013	(r254018)
 @@ -49,12 +49,6 @@ __FBSDID("$FreeBSD$");
  
  #include "extern.h"
  
 -#ifdef COMPAT_32BIT
 -#define	LD_	"LD_32_"
 -#else
 -#define	LD_	"LD_"
 -#endif
 -
  /*
   * 32-bit ELF data structures can only be used if the system header[s] declare
   * them.  There is no official macro for determining whether they are declared,
 @@ -64,6 +58,16 @@ __FBSDID("$FreeBSD$");
  #define	ELF32_SUPPORTED
  #endif
  
 +#define	LDD_SETENV(name, value, overwrite) do {		\
 +	setenv("LD_" name, value, overwrite);		\
 +	setenv("LD_32_" name, value, overwrite);	\
 +} while (0)
 +
 +#define	LDD_UNSETENV(name) do {		\
 +	unsetenv("LD_" name);		\
 +	unsetenv("LD_32_" name);	\
 +} while (0)
 +
  static int	is_executable(const char *fname, int fd, int *is_shlib,
  		    int *type);
  static void	usage(void);
 @@ -82,7 +86,7 @@ execldd32(char *file, char *fmt1, char *
  	char *argv[8];
  	int i, rval, status;
  
 -	unsetenv(LD_ "TRACE_LOADED_OBJECTS");
 +	LDD_UNSETENV("TRACE_LOADED_OBJECTS");
  	rval = 0;
  	i = 0;
  	argv[i++] = strdup(_PATH_LDD32);
 @@ -121,7 +125,7 @@ execldd32(char *file, char *fmt1, char *
  	}
  	while (i--)
  		free(argv[i]);
 -	setenv(LD_ "TRACE_LOADED_OBJECTS", "yes", 1);
 +	LDD_SETENV("TRACE_LOADED_OBJECTS", "yes", 1);
  	return (rval);
  }
  #endif
 @@ -210,15 +214,15 @@ main(int argc, char *argv[])
  		}
  
  		/* ld.so magic */
 -		setenv(LD_ "TRACE_LOADED_OBJECTS", "yes", 1);
 +		LDD_SETENV("TRACE_LOADED_OBJECTS", "yes", 1);
  		if (fmt1 != NULL)
 -			setenv(LD_ "TRACE_LOADED_OBJECTS_FMT1", fmt1, 1);
 +			LDD_SETENV("TRACE_LOADED_OBJECTS_FMT1", fmt1, 1);
  		if (fmt2 != NULL)
 -			setenv(LD_ "TRACE_LOADED_OBJECTS_FMT2", fmt2, 1);
 +			LDD_SETENV("TRACE_LOADED_OBJECTS_FMT2", fmt2, 1);
  
 -		setenv(LD_ "TRACE_LOADED_OBJECTS_PROGNAME", *argv, 1);
 +		LDD_SETENV("TRACE_LOADED_OBJECTS_PROGNAME", *argv, 1);
  		if (aflag)
 -			setenv(LD_ "TRACE_LOADED_OBJECTS_ALL", "1", 1);
 +			LDD_SETENV("TRACE_LOADED_OBJECTS_ALL", "1", 1);
  		else if (fmt1 == NULL && fmt2 == NULL)
  			/* Default formats */
  			printf("%s:\n", *argv);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: markj 
State-Changed-When: Wed Aug 7 00:37:50 UTC 2013 
State-Changed-Why:  
This is a duplicate of PR 127276 and has been fixed in r254018. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=175339 
>Unformatted:
