From jbeich@tormail.org  Thu Dec 27 08:50:49 2012
Return-Path: <jbeich@tormail.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4DBE1843
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Dec 2012 08:50:49 +0000 (UTC)
	(envelope-from jbeich@tormail.org)
Received: from outgoing.tormail.org (outgoing.tormail.org [82.221.96.22])
	by mx1.freebsd.org (Postfix) with ESMTP id F26CB8FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Dec 2012 08:50:48 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=internal.tormail.org)
	by outgoing.tormail.org with esmtp (Exim 4.72)
	(envelope-from <jbeich@tormail.org>)
	id 1To9Ar-0004Dy-Qh
	for FreeBSD-gnats-submit@freebsd.org; Thu, 27 Dec 2012 11:50:46 +0300
Received: from jbeich by internal.tormail.org with local (Exim 4.63)
	(envelope-from <jbeich@tormail.org>)
	id 1To992-0009s3-7Y
	for FreeBSD-gnats-submit@freebsd.org; Thu, 27 Dec 2012 08:48:54 +0000
Message-Id: <1To992-0009s3-7Y@internal.tormail.org>
Date: Thu, 27 Dec 2012 18:49:21 +1000
From: Jan Beich <jbeich@tormail.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [regression] "pw group show -a" broken after r242349

>Number:         174731
>Category:       bin
>Synopsis:       [regression] "pw group show -a" broken after r242349
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bapt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 27 09:00:00 UTC 2012
>Closed-Date:    Thu Dec 27 14:45:12 UTC 2012
>Last-Modified:  Thu Dec 27 14:50:00 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
r242349 no longer appends newline after a group entry. This is most
noticible with `-a' flag. One can use `getent group' as a workaround but
its format is slightly different.

Note, there is no difference for "pw user show -a" before/after r242349.
>How-To-Repeat:
# before
$ (pw group show wheel; pw group show operator)
wheel:*:0:root
operator:*:5:root

# after
$ (pw group show wheel; pw group show operator)
wheel:*:0:rootoperator:*:5:root

# before
$ pw group show -a
wheel:*:0:root
daemon:*:1:
kmem:*:2:
sys:*:3:
tty:*:4:
operator:*:5:root
mail:*:6:
bin:*:7:
news:*:8:
man:*:9:
games:*:13:
ftp:*:14:
staff:*:20:
sshd:*:22:
smmsp:*:25:
mailnull:*:26:
_atf:*:27:
guest:*:31:
bind:*:53:
proxy:*:62:
authpf:*:63:
_pflogd:*:64:
_dhcp:*:65:
uucp:*:66:
dialer:*:68:
network:*:69:
audit:*:77:
www:*:80:
hast:*:845:
nogroup:*:65533:
nobody:*:65534:

# after
$ pw group show -a
wheel:*:0:rootdaemon:*:1:kmem:*:2:sys:*:3:tty:*:4:operator:*:5:rootmail:*:6:bin:*:7:news:*:8:man:*:9:games:*:13:ftp:*:14:staff:*:20:sshd:*:22:smmsp:*:25:mailnull:*:26:_atf:*:27:guest:*:31:bind:*:53:proxy:*:62:authpf:*:63:_pflogd:*:64:_dhcp:*:65:uucp:*:66:dialer:*:68:network:*:69:audit:*:77:www:*:80:hast:*:845:nogroup:*:65533:nobody:*:65534:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->bapt 
Responsible-Changed-By: bapt 
Responsible-Changed-When: Thu Dec 27 14:23:11 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174731 
State-Changed-From-To: open->closed 
State-Changed-By: bapt 
State-Changed-When: Thu Dec 27 14:45:11 UTC 2012 
State-Changed-Why:  
Fixed now, no mfc planned as it only affects current. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174731 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/174731: commit references a PR
Date: Thu, 27 Dec 2012 14:44:21 +0000 (UTC)

 Author: bapt
 Date: Thu Dec 27 14:44:13 2012
 New Revision: 244738
 URL: http://svnweb.freebsd.org/changeset/base/244738
 
 Log:
   Fix a regression in "pw group show" introduced r242349:
   print a newline after printing each group line.
   
   PR:		bin/174731
   Submitted by:	Jan Beich <jbeich@tormail.org>
 
 Modified:
   head/usr.sbin/pw/pw_group.c
 
 Modified: head/usr.sbin/pw/pw_group.c
 ==============================================================================
 --- head/usr.sbin/pw/pw_group.c	Thu Dec 27 14:35:06 2012	(r244737)
 +++ head/usr.sbin/pw/pw_group.c	Thu Dec 27 14:44:13 2012	(r244738)
 @@ -407,7 +407,7 @@ print_group(struct group * grp, int pret
  		char           *buf = NULL;
  
  		buf = gr_make(grp);
 -		fputs(buf, stdout);
 +		printf("%s\n", buf);
  		free(buf);
  	} else {
  		int             i;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
