From jhs@berklix.com  Tue Dec  4 15:11:12 2012
Return-Path: <jhs@berklix.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BD99E514;
	Tue,  4 Dec 2012 15:11:12 +0000 (UTC)
	(envelope-from jhs@berklix.com)
Received: from tower.berklix.org (tower.berklix.org [83.236.223.114])
	by mx1.freebsd.org (Postfix) with ESMTP id 144468FC14;
	Tue,  4 Dec 2012 15:11:10 +0000 (UTC)
Received: from mart.js.berklix.net (pD9FBEE01.dip.t-dialin.net [217.251.238.1])
	(authenticated bits=128)
	by tower.berklix.org (8.14.4/8.14.4) with ESMTP id qB4FBxJF098607;
	Tue, 4 Dec 2012 16:12:01 +0100 (CET)
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41])
	by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id qB4FB3uR035879;
	Tue, 4 Dec 2012 16:11:03 +0100 (CET)
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (localhost [127.0.0.1])
	by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id qB4FArDd041025;
	Tue, 4 Dec 2012 16:10:58 +0100 (CET)
	(envelope-from jhs@fire.js.berklix.net)
Received: (from jhs@localhost)
	by fire.js.berklix.net (8.14.4/8.14.3/Submit) id qB4FAmFX041018;
	Tue, 4 Dec 2012 16:10:48 +0100 (CET)
	(envelope-from jhs)
Message-Id: <201212041510.qB4FAmFX041018@fire.js.berklix.net>
Date: Tue, 4 Dec 2012 16:10:48 +0100 (CET)
From: "Julian H. Stacey" <jhs@berklix.com>
Reply-To: "Julian H. Stacey" <jhs@berklix.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: re@freebsd.org
Subject: Missing quote in comment in 8.3 & 9.0 & 9.1RC2 etc/sendmail/freebsd.mc
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         174108
>Category:       bin
>Synopsis:       Missing quote in comment in 8.3 & 9.0 & 9.1RC2 etc/sendmail/freebsd.mc
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gshapiro
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 04 15:20:00 UTC 2012
>Closed-Date:    Sun Dec 30 15:44:26 UTC 2012
>Last-Modified:  Sun Dec 30 15:44:26 UTC 2012
>Originator:     "Julian H. Stacey" <jhs@berklix.com>
>Release:        FreeBSD 9.1-RC3 amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
FreeBSD slim.berklix.org 9.1-RC3 FreeBSD 9.1-RC3 #0: Mon Nov 26 18:35:36 CET 2012     jhs@slim.berklix.org:/usr/src/sys/amd64/compile/VIRTUAL  amd64

	
>Description:
There is a missing double quote " in 
8.3 & 9.0 & 9.1RC2 src/etc/sendmail/freebsd.mc
8.2-RELEASE & earlier are OK.

>How-To-Repeat:
	
	See posting below
>Fix:

	

I append my 
http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/etc/sendmail/freebsd.mc.REL=9.0-RELEASE.diff

This patch applies to 8.3-RELEASE and 9.0-RELEASE & 9.1RC3. 
It is not needed for 8.2-RELEASE & earlier.

---------
*** 9.1-RC3/src/etc/sendmail/freebsd.mc	Tue Dec  4 15:41:28 2012
--- new-generic/src/etc/sendmail/freebsd.mc	Tue Dec  4 15:42:09 2012
***************
*** 69,75 ****
  dnl Uncomment to activate your chosen DNS based blacklist
  dnl FEATURE(dnsbl, `dnsbl.example.com')
  dnl Alternatively, you can provide your own server and rejection message:
! dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
  
  dnl Dialup users should uncomment and define this appropriately
  dnl define(`SMART_HOST', `your.isp.mail.server')
--- 69,75 ----
  dnl Uncomment to activate your chosen DNS based blacklist
  dnl FEATURE(dnsbl, `dnsbl.example.com')
  dnl Alternatively, you can provide your own server and rejection message:
! dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected"'')
  
  dnl Dialup users should uncomment and define this appropriately
  dnl define(`SMART_HOST', `your.isp.mail.server')
---------

http://lists.freebsd.org/pipermail/freebsd-hackers/2012-December/041333.html

{
] To:	hackers@@freebsd.org
] cc: re@@freebsd.org
] Subject: Missing quote in comment in 8.3 & 9.0 & 9.1RC2 etc/sendmail/freebsd.mc
] From:		"Julian H. Stacey" <jhs@@berklix.com>
] Organization: http://berklix.com BSD Linux Unix Consultancy, Munich Germany
] Fcc:		sent
] User-agent:	EXMH on FreeBSD http://www.berklix.com/free/
] X-URL:		http://www.berklix.com/~jhs/cv/
] 
] Hi hackers@@freebsd.org
] 
] There is a missing double quote " in 
] 8.3 & 9.0 & 9.1RC2 src/etc/sendmail/freebsd.mc
] 8.2-RELEASE & earlier are OK.
] 
] Here's a diff -c to .mc
] The diff is not to fix it, but to help generate a freebsd.cf to
] understand the difference.  The patch for a fix would befar more trivial :-)
] 
] ------
] *** 9.1-RC3/src/etc/sendmail/freebsd.mc	Mon Oct 29 21:16:44 2012
] --- 9.1-RC3/src+debug/etc/sendmail/freebsdjhs.mc	Mon Dec  3 18:44:33 2012
] ***************
] *** 66,75 ****
]   dnl For that, visit
]   dnl http://www.google.com/Top/Computers/Internet/E-mail/Spam/Blacklists/
]   
] ! dnl Uncomment to activate your chosen DNS based blacklist
] ! dnl FEATURE(dnsbl, `dnsbl.example.com')
] ! dnl Alternatively, you can provide your own server and rejection message:
] ! dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
]   
]   dnl Dialup users should uncomment and define this appropriately
]   dnl define(`SMART_HOST', `your.isp.mail.server')
] --- 66,77 ----
]   dnl For that, visit
]   dnl http://www.google.com/Top/Computers/Internet/E-mail/Spam/Blacklists/
]   
] ! # Uncomment to activate your chosen DNS based blacklist
] ! FEATURE(dnsbl, `jhs0.dnsbl.example.com')
] ! # Alternatively, you can provide your own server and rejection message:
] ! FEATURE(dnsbl, `jhs3.dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
] ! # original line above has 3 x " , line below has 4
] ! FEATURE(dnsbl, `jhs4.dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected"'')
]   
]   dnl Dialup users should uncomment and define this appropriately
]   dnl define(`SMART_HOST', `your.isp.mail.server')
] ------
] 
] The .cf output is
] ------
] # DNS based IP address spam list jhs0.dnsbl.example.com
] R$*			$: $&{client_addr}
] R$-.$-.$-.$-		$: <?> $(dnsbl $4.$3.$2.$1.jhs0.dnsbl.example.com. $: OK $)
] R<?>OK			$: OKSOFAR
] R<?>$+<TMP>		$: TMPOK
] R<?>$+		$#error $@ 5.7.1 $: "550 Rejected: " $&{client_addr} " listed at jhs0.dnsbl.example.com"
] 
] # DNS based IP address spam list jhs3.dnsbl.example.com
] R$*			$: $&{client_addr}
] R$-.$-.$-.$-		$: <?> $(dnsbl $4.$3.$2.$1.jhs3.dnsbl.example.com. $: OK $)
] R<?>OK			$: OKSOFAR
] R<?>$+<TMP>		$: TMPOK
] R<?>$+		$#error $@ 5.7.1 $: "550 Mail from " $&{client_addr} " rejected
] 
] # DNS based IP address spam list jhs4.dnsbl.example.com
] R$*			$: $&{client_addr}
] R$-.$-.$-.$-		$: <?> $(dnsbl $4.$3.$2.$1.jhs4.dnsbl.example.com. $: OK $)
] R<?>OK			$: OKSOFAR
] R<?>$+<TMP>		$: TMPOK
] R<?>$+		$#error $@ 5.7.1 $: "550 Mail from " $&{client_addr} " rejected"
] ------
] Above, jhs3 seems bad & jhs4 seems good.
] 
] A copy of this diff + follow up is in
] 	http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/etc/sendmail/freebsd.mc.REL=ALL.diff
] 
] The error appeared in 8.3 & 9.0 & 9.1RC3, it was OK earlier :
] 
] 4.11-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', `"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}')
] 
] 6.4-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'')
] 
] 7.3-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'')
] 
] 7.4-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'')
] 
] 8.2-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'')
] 
] 8.3-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
] 
] 9.0-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
] 
] 9.1-RC3//src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
] 
] 
] Why others didnt notice earlier:
]   It's just a comment, I assume not checked by anything automatic at
]   freebsd.org.
] 
] How I caught it:
]   I have my own src/etc/sendmail/ Makefile diffs & fdef'd common.cpp
]   that generates various .mc files for each of my hosts, & many
]   versions, which filters the .cpp to create .mcfiles, inc. a check
]   file that should be an exact match with that version's freebsd.mc
]   ... & cpp complained: unmatched ".
] 
] I will send-pr unless I hear otherwise.
]   But as 9.1-RELEASE is imminent, & it would be a trivial anodyne
]   fix to a comment for re@ , so they want to fix, so cc'd to re@.
] 
] Cheers,
] Julian
] -- 
] Julian Stacey, BSD Unix Linux C Sys Eng Consultant, Munich http://berklix.com
]  Reply below not above, like a play script.  Indent old text with "> ".
]  Send plain text. Not: HTML, multipart/alternative, base64, quoted-printable.
}
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->gshapiro 
Responsible-Changed-By: gshapiro 
Responsible-Changed-When: Sat Dec 29 19:51:08 UTC 2012 
Responsible-Changed-Why:  
Over to sendmail maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174108 
State-Changed-From-To: open->feedback 
State-Changed-By: gshapiro 
State-Changed-When: Sat Dec 29 19:59:09 UTC 2012 
State-Changed-Why:  
Patch committed to HEAD.  State will be set to closed when patch MFC'ed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174108 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/174108: commit references a PR
Date: Sat, 29 Dec 2012 19:58:00 +0000 (UTC)

 Author: gshapiro
 Date: Sat Dec 29 19:57:52 2012
 New Revision: 244830
 URL: http://svnweb.freebsd.org/changeset/base/244830
 
 Log:
   Add missing closing quote on commented out example
   
   PR:		bin/174108
   Obtained from:	Julian H. Stacey
   MFC after:	1 day
 
 Modified:
   head/etc/sendmail/freebsd.mc
 
 Modified: head/etc/sendmail/freebsd.mc
 ==============================================================================
 --- head/etc/sendmail/freebsd.mc	Sat Dec 29 19:13:16 2012	(r244829)
 +++ head/etc/sendmail/freebsd.mc	Sat Dec 29 19:57:52 2012	(r244830)
 @@ -69,7 +69,7 @@ dnl http://www.google.com/Top/Computers/
  dnl Uncomment to activate your chosen DNS based blacklist
  dnl FEATURE(dnsbl, `dnsbl.example.com')
  dnl Alternatively, you can provide your own server and rejection message:
 -dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'')
 +dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected"'')
  
  dnl Dialup users should uncomment and define this appropriately
  dnl define(`SMART_HOST', `your.isp.mail.server')
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->closed 
State-Changed-By: gshapiro 
State-Changed-When: Sun Dec 30 15:43:58 UTC 2012 
State-Changed-Why:  
Change has been MFC'ed to supported branches (7, 8, 9) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174108 
>Unformatted:
