From nobody@FreeBSD.org  Mon Dec  3 08:19:06 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9E0FA400
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  3 Dec 2012 08:19:06 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 8397E8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  3 Dec 2012 08:19:06 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qB38J62p043221
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 3 Dec 2012 08:19:06 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id qB38J6uI043220;
	Mon, 3 Dec 2012 08:19:06 GMT
	(envelope-from nobody)
Message-Id: <201212030819.qB38J6uI043220@red.freebsd.org>
Date: Mon, 3 Dec 2012 08:19:06 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] devd.h needs sys/cdef.h
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         174078
>Category:       bin
>Synopsis:       [patch] devd.h needs sys/cdef.h
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 03 08:20:00 UTC 2012
>Closed-Date:    Wed Dec 05 17:55:55 UTC 2012
>Last-Modified:  Sun Feb 03 22:31:48 UTC 2013
>Originator:     Garrett Cooper
>Release:        n/a
>Organization:
EMC Isilon
>Environment:
n/a
>Description:
sys/cdef.h is needed in devd.h in order for it compile without warnings with yacc.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: sbin/devd/devd.h
===================================================================
--- sbin/devd/devd.h	(revision 243802)
+++ sbin/devd/devd.h	(working copy)
@@ -31,6 +31,8 @@
 #ifndef DEVD_H
 #define DEVD_H
 
+#include <sys/cdefs.h>
+
 /** @warning This file needs to be purely 'C' compatible.
  */
 struct event_proc;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Dec 3 22:47:59 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174078 

From: Garrett Cooper <yaneurabeya@gmail.com>
To: Eitan Adler <lists@eitanadler.com>
Cc: bug-followup <bug-followup@freebsd.org>
Subject: Re: bin/174078: [patch] devd.h needs sys/cdef.h
Date: Wed, 5 Dec 2012 09:03:00 -0800

 On Wed, Dec 5, 2012 at 8:35 AM, Eitan Adler <lists@eitanadler.com> wrote:
 > On 5 December 2012 11:08, Garrett Cooper <yaneurabeya@gmail.com> wrote:
 >> On Mon, Dec 3, 2012 at 4:55 PM, Eitan Adler <lists@eitanadler.com> wrote:
 >>
 >> ...
 >>
 >>>> sys/cdef.h is needed in devd.h in order for it compile without warnings with yacc.
 >>>
 >>> How can I reproduce this warning?
 >>
 >> Don't remember right offhand. It might have been an issue around when
 >> some of the Juniper build commits went in where the dependencies got
 >> mangled, or it might have been when I was running a slightly older
 >> version of yacc trying to compile CURRENT. conf/174079 is the same
 >> bucket.
 >
 > Alright. I tried to reproduce here, and I couldn't. Given my separate
 > work on reducing unneeeded include files is it okay for me to close
 > this? If its needed in the future I could easily reopen and commit.
 
     Sure. It might have been a WARNS thing, but my recollection of
 what actually was going on is eluding me.
 Thanks!
 -Garrett
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Wed Dec 5 17:55:55 UTC 2012 
State-Changed-Why:  
per discussion 

http://www.freebsd.org/cgi/query-pr.cgi?pr=174078 

From: Eitan Adler <lists@eitanadler.com>
To: Garrett Cooper <yaneurabeya@gmail.com>
Cc: bug-followup <bug-followup@freebsd.org>
Subject: Re: bin/174078: [patch] devd.h needs sys/cdef.h
Date: Wed, 5 Dec 2012 12:55:25 -0500

 On 5 December 2012 12:03, Garrett Cooper <yaneurabeya@gmail.com> wrote:
 >     Sure. It might have been a WARNS thing, but my recollection of
 > what actually was going on is eluding me.
 
 I tried with WARNS=6 and NO_WERROR= and couldn't repro.  If you find
 the case again I'd be happy to commit.
 
 Thanks for making FreeBSD better!
 
 
 -- 
 Eitan Adler
>Unformatted:
