From nobody@FreeBSD.org  Tue Oct 23 10:21:59 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 974067A7
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2012 10:21:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F66D8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2012 10:21:59 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q9NALxBl091417
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2012 10:21:59 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.5/8.14.5/Submit) id q9NALxsC091416;
	Tue, 23 Oct 2012 10:21:59 GMT
	(envelope-from nobody)
Message-Id: <201210231021.q9NALxsC091416@red.freebsd.org>
Date: Tue, 23 Oct 2012 10:21:59 GMT
From: Erik Cederstrand <erik@cederstrand.dk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dump: mark non-returning function quit() as such in function prototype
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         172978
>Category:       bin
>Synopsis:       dump(8): mark non-returning function quit() as such in function prototype
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 23 10:30:00 UTC 2012
>Closed-Date:    Thu Nov 29 05:17:33 UTC 2012
>Last-Modified:  Thu Nov 29 05:17:33 UTC 2012
>Originator:     Erik Cederstrand
>Release:        CURRENT
>Organization:
>Environment:
>Description:
Marking non-returning function prototype for quit() in head/sbin/dump/dump.h eliminates various false positives in Clang Static Analyzer reports.
>How-To-Repeat:

>Fix:
Use __noreturn__ to mark non-returning function.

Patch attached with submission follows:

Index: src/sbin/dump/dump.h
===================================================================
--- src/sbin/dump/dump.h	(revision 241876)
+++ src/sbin/dump/dump.h	(working copy)
@@ -96,7 +96,7 @@
 void	msg(const char *fmt, ...) __printflike(1, 2);
 void	msgtail(const char *fmt, ...) __printflike(1, 2);
 int	query(const char *question);
-void	quit(const char *fmt, ...) __printflike(1, 2);
+void	quit(const char *fmt, ...) __printflike(1, 2) __attribute__((__noreturn__));
 void	timeest(void);
 time_t	unctime(char *str);
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Oct 23 15:41:52 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172978 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Fri Oct 26 00:52:26 UTC 2012 
State-Changed-Why:  
awaiting approval or review prior to commit (no action needed from 
submitter) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172978 
State-Changed-From-To: analyzed->closed 
State-Changed-By: eadler 
State-Changed-When: Thu Nov 29 05:17:30 UTC 2012 
State-Changed-Why:  
committed in r243665 - sorry it took so long - I lost track of the patch 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172978 
>Unformatted:
