From peter@rulingia.com  Tue Oct  9 06:28:51 2012
Return-Path: <peter@rulingia.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 8928C17C7
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  9 Oct 2012 06:28:44 +0000 (UTC)
	(envelope-from peter@rulingia.com)
Received: from vps.rulingia.com (host-122-100-2-194.octopus.com.au [122.100.2.194])
	by mx1.freebsd.org (Postfix) with ESMTP id 21CD79043B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  8 Oct 2012 23:58:06 +0000 (UTC)
Received: from server.rulingia.com (c220-239-248-178.belrs5.nsw.optusnet.com.au [220.239.248.178])
	by vps.rulingia.com (8.14.5/8.14.5) with ESMTP id q98Nw3TT033384
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 9 Oct 2012 10:58:03 +1100 (EST)
	(envelope-from peter@rulingia.com)
Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1])
	by server.rulingia.com (8.14.5/8.14.5) with ESMTP id q98NvtMo080417
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 9 Oct 2012 10:57:56 +1100 (EST)
	(envelope-from peter@server.rulingia.com)
Received: (from peter@localhost)
	by server.rulingia.com (8.14.5/8.14.5/Submit) id q98Nvt4e080415;
	Tue, 9 Oct 2012 10:57:55 +1100 (EST)
	(envelope-from peter)
Message-Id: <201210082357.q98Nvt4e080415@server.rulingia.com>
Date: Tue, 9 Oct 2012 10:57:55 +1100 (EST)
From: Peter Jeremy <peter@rulingia.com>
Reply-To: Peter Jeremy <peter@rulingia.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: peter@server.rulingia.com
Subject: [patch] FICL - correct handling of bare comment lines
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         172534
>Category:       bin
>Synopsis:       [patch] FICL - correct handling of bare comment lines
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 09 22:30:16 UTC 2012
>Closed-Date:    
>Last-Modified:  Thu Nov 08 20:54:46 UTC 2012
>Originator:     Peter Jeremy
>Release:        FreeBSD 8.3-STABLE amd64
>Organization:
n/a
>Environment:
System: FreeBSD server.rulingia.com 8.3-STABLE FreeBSD 8.3-STABLE #18 r237444M: Sun Jul 8 10:47:08 EST 2012 root@server.rulingia.com:/var/obj/usr/src/sys/server amd64

>Description:
	Various forth files in sys/boot/ficl/softwords/ are converted
	to a C string code for embedding into the FICL binary using an
	awk script softcore.awk.  This script fails to strip out
	comments that consist of a sole backslash.  Whilst this isn't
	a problem for the standard set of SOFTWORDS, the
	not-normally-included oo.fr contains comments in the
	array-init definition that cause softcore.awk to emit the
	string "\ " - which gcc rejects.

>How-To-Repeat:
	# cd /sys/boot/ficl
	uncomment the line 'SOFTWORDS+= oo.fr classes.fr' in Makefile
	# make testmain
	fails with:
(cd /home/peter/forth/boot/ficl/softwords; cat softcore.fr jhlocal.fr marker.fr freebsd.fr ficllocal.fr  ifbrack.fr oo.fr classes.fr  | awk -f softcore.awk -v datestamp="`LC_ALL=C date`") > softcore.c
cc -O2 -pipe  -ffreestanding -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -std=gnu99   -m32 -march=i386 -I. -I/home/peter/forth/boot/ficl -I/home/peter/forth/boot/ficl/i386  -I/home/peter/forth/boot/ficl/../common -c softcore.c
softcore.c:917:5: warning: unknown escape sequence: '\040'
softcore.c:917:5: warning: unknown escape sequence: '\040'

>Fix:
	According to diff on stable-8, the following patch does not
	result in any change to the default softcore.c and only
	removes the two "\ " lines when the optional object-oriented
	words are added.

Index: sys/boot/ficl/softwords/softcore.awk
===================================================================
--- sys/boot/ficl/softwords/softcore.awk	(revision 241347)
+++ sys/boot/ficl/softwords/softcore.awk	(working copy)
@@ -75,7 +75,7 @@
 {
   gsub(/\t/, "    ");			# replace each tab with 4 spaces
   gsub(/\"/, "\\\"");			# escape quotes
-  gsub(/\\[[:space:]]+$/, "");		# toss empty comments
+  gsub(/\\[[:space:]]*$/, "");		# toss empty comments
 }
 
 # strip out empty lines
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Oct 18 22:57:56 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172534 
Responsible-Changed-From-To: eadler->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Nov 8 20:54:46 UTC 2012 
Responsible-Changed-Why:  
I won't be dealing with this PR for some time, so give it back to the 
pool 

http://www.freebsd.org/cgi/query-pr.cgi?pr=172534 
>Unformatted:
