From jbeich@tormail.org  Sat Sep 15 12:41:09 2012
Return-Path: <jbeich@tormail.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B40D106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2012 12:41:09 +0000 (UTC)
	(envelope-from jbeich@tormail.org)
Received: from outgoing.tormail.org (outgoing.tormail.org [82.221.96.22])
	by mx1.freebsd.org (Postfix) with ESMTP id CD4718FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2012 12:41:08 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=internal.tormail.org)
	by outgoing.tormail.org with esmtp (Exim 4.72)
	(envelope-from <jbeich@tormail.org>)
	id 1TCrgI-00060u-OS
	for FreeBSD-gnats-submit@freebsd.org; Sat, 15 Sep 2012 16:41:07 +0400
Received: from jbeich by internal.tormail.org with local (Exim 4.63)
	(envelope-from <jbeich@tormail.org>)
	id 1TCrfC-0004yI-6c
	for FreeBSD-gnats-submit@freebsd.org; Sat, 15 Sep 2012 12:39:59 +0000
Message-Id: <1TCrfC-0004yI-6c@internal.tormail.org>
Date: Sat, 15 Sep 2012 23:40:18 +1100
From: Jan Beich <jbeich@tormail.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: procstat(1): KVME_TYPE_SG (in TP column) is not documented

>Number:         171664
>Category:       bin
>Synopsis:       procstat(1): KVME_TYPE_SG (in TP column) is not documented
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 15 12:50:08 UTC 2012
>Closed-Date:    Sun Oct 21 03:31:38 UTC 2012
>Last-Modified:  Sun Oct 21 03:31:38 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
ref. http://svn.freebsd.org/changeset/base/195840
>Description:
>How-To-Repeat:
$ procstat -v $(pgrep firefox) | awk 'NR == 1 || $10 ~ /sg/'
  PID              START                END PRT  RES PRES REF SHD   FL TP PATH
90996        0x8017fb000        0x8017fc000 rw-    0    0  13   0 ---- sg
90996        0x8017fc000        0x8017fd000 rw-    1    0   5   0 ---- sg
90996        0x8017fd000        0x8017fe000 rw-    0    0   3   0 ---- sg
90996        0x8017fe000        0x8017ff000 rw-    0    0  13   0 ---- sg
90996        0x8017ff000        0x801800000 rw-    0    0   3   0 ---- sg
90996        0x8103d8000        0x8103f5000 rw-    2    0   3   0 ---- sg
90996        0x8103f5000        0x8103f6000 rw-    0    0  13   0 ---- sg
90996        0x8103f6000        0x8103f7000 rw-    1    0  13   0 ---- sg
90996        0x8103f7000        0x8103fb000 rw-    4    0   2   0 ---- sg
90996        0x8103fb000        0x8103fc000 rw-    1    0   4   0 ---- sg
90996        0x8103fc000        0x8103fd000 rw-    0    0   2   0 ---- sg
90996        0x811390000        0x8113d0000 rw-   64    0   2   0 ---- sg
90996        0x8113d0000        0x8113d4000 rw-    0    0   2   0 ---- sg
90996        0x812213000        0x812313000 rw-    4    0   2   0 ---- sg
90996        0x82d600000        0x82d800000 rw-  399    0   2   0 ---- sg
>Fix:
>Release-Note:
>Audit-Trail:

From: Jan Beich <jbeich@tormail.org>
To: jhb@freebsd.org
Cc: bug-followup@freebsd.org
Subject: Re: bin/171664: procstat(1): KVME_TYPE_SG (in TP column) is not documented
Date: Sun, 16 Sep 2012 21:07:38 -0300

 --=-=-=
 Content-Type: text/plain
 
 (oops, confused doc-bug with docs/ category)
 
 Jan Beich <jbeich@tormail.org> writes:
 
 >>Environment:
 > ref. http://svn.freebsd.org/changeset/base/195840
 >>How-To-Repeat:
 > $ procstat -v $(pgrep firefox) | awk 'NR == 1 || $10 ~ /sg/'
 >   PID              START                END PRT  RES PRES REF SHD   FL TP PATH
 > 90996        0x8017fb000        0x8017fc000 rw-    0    0  13   0 ---- sg
 
 John, how about the following trivial fix?
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: attachment; filename=sg_desc.diff
 
 Index: usr.bin/procstat/procstat.1
 ===================================================================
 --- usr.bin/procstat/procstat.1	(revision 240575)
 +++ usr.bin/procstat/procstat.1	(working copy)
 @@ -418,6 +418,8 @@ default
  device
  .It ph
  physical
 +.It sg
 +scatter/gather
  .It sw
  swap
  .It vn
 
 --=-=-=--
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Sep 17 01:07:01 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171664 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 17 01:19:12 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171664 

From: John Baldwin <jhb@freebsd.org>
To: Jan Beich <jbeich@tormail.org>
Cc: bug-followup@freebsd.org
Subject: Re: bin/171664: procstat(1): KVME_TYPE_SG (in TP column) is not documented
Date: Mon, 17 Sep 2012 08:47:23 -0400

 On Sunday, September 16, 2012 8:07:38 pm Jan Beich wrote:
 > (oops, confused doc-bug with docs/ category)
 > 
 > Jan Beich <jbeich@tormail.org> writes:
 > 
 > >>Environment:
 > > ref. http://svn.freebsd.org/changeset/base/195840
 > >>How-To-Repeat:
 > > $ procstat -v $(pgrep firefox) | awk 'NR == 1 || $10 ~ /sg/'
 > >   PID              START                END PRT  RES PRES REF SHD   FL TP 
 PATH
 > > 90996        0x8017fb000        0x8017fc000 rw-    0    0  13   0 ---- sg
 > 
 > John, how about the following trivial fix?
 
 Sure.  This is document OBJT_SGLIST I take it?
 
 -- 
 John Baldwin

From: Jan Beich <jbeich@tormail.org>
To: John Baldwin <jhb@freebsd.org>
Cc: bug-followup@freebsd.org
Subject: Re: bin/171664: procstat(1): KVME_TYPE_SG (in TP column) is not documented
Date: Tue, 18 Sep 2012 01:40:41 +0900

 John Baldwin <jhb@freebsd.org> writes:
 
 > On Sunday, September 16, 2012 8:07:38 pm Jan Beich wrote:
 >
 >> (oops, confused doc-bug with docs/ category)
 >> 
 >> Jan Beich <jbeich@tormail.org> writes:
 >> 
 >> >>Environment:
 >> > ref. http://svn.freebsd.org/changeset/base/195840
 >> >>How-To-Repeat:
 >> > $ procstat -v $(pgrep firefox) | awk 'NR == 1 || $10 ~ /sg/'
 >> >   PID              START                END PRT  RES PRES REF SHD   FL TP 
 > PATH
 >> > 90996        0x8017fb000        0x8017fc000 rw-    0    0  13   0 ---- sg
 >> 
 >> John, how about the following trivial fix?
 >
 > Sure.  This is document OBJT_SGLIST I take it?
 
 OBJT_SG unless procstat(1) knows they're managed by sglist(9).
 In the case above it seems nvidia-driver allocates a new list for each
 OpenGL client, e.g. Firefox with GL layers.

From: John Baldwin <jhb@freebsd.org>
To: Jan Beich <jbeich@tormail.org>
Cc: bug-followup@freebsd.org
Subject: Re: bin/171664: procstat(1): KVME_TYPE_SG (in TP column) is not documented
Date: Mon, 17 Sep 2012 13:13:39 -0400

 On Monday, September 17, 2012 12:40:41 pm Jan Beich wrote:
 > John Baldwin <jhb@freebsd.org> writes:
 > 
 > > On Sunday, September 16, 2012 8:07:38 pm Jan Beich wrote:
 > >
 > >> (oops, confused doc-bug with docs/ category)
 > >> 
 > >> Jan Beich <jbeich@tormail.org> writes:
 > >> 
 > >> >>Environment:
 > >> > ref. http://svn.freebsd.org/changeset/base/195840
 > >> >>How-To-Repeat:
 > >> > $ procstat -v $(pgrep firefox) | awk 'NR == 1 || $10 ~ /sg/'
 > >> >   PID              START                END PRT  RES PRES REF SHD   FL TP 
 > > PATH
 > >> > 90996        0x8017fb000        0x8017fc000 rw-    0    0  13   0 ---- sg
 > >> 
 > >> John, how about the following trivial fix?
 > >
 > > Sure.  This is document OBJT_SGLIST I take it?
 
 Should have said "to document"
 
 > OBJT_SG unless procstat(1) knows they're managed by sglist(9).
 > In the case above it seems nvidia-driver allocates a new list for each
 > OpenGL client, e.g. Firefox with GL layers.
 
 Oh, maybe it's OBJT_SG, can't recall which name it uses.  Yes, the
 nvidia-driver uses them in abundance (it was added specifically for that
 driver to use).
 
 -- 
 John Baldwin

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/171664: commit references a PR
Date: Tue,  2 Oct 2012 00:30:36 +0000 (UTC)

 Author: eadler
 Date: Tue Oct  2 00:30:20 2012
 New Revision: 241117
 URL: http://svn.freebsd.org/changeset/base/241117
 
 Log:
   add SG state type
   
   PR:		bin/171664
   Submitted by:	Jan Beich jbeich@tormail.org
   Approved by:	cperciva
   MFC after:	1 week
 
 Modified:
   head/usr.bin/procstat/procstat.1
 
 Modified: head/usr.bin/procstat/procstat.1
 ==============================================================================
 --- head/usr.bin/procstat/procstat.1	Tue Oct  2 00:30:15 2012	(r241116)
 +++ head/usr.bin/procstat/procstat.1	Tue Oct  2 00:30:20 2012	(r241117)
 @@ -418,6 +418,8 @@ default
  device
  .It ph
  physical
 +.It sg
 +scatter/gather
  .It sw
  swap
  .It vn
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->patched 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 2 00:44:51 UTC 2012 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171664 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Sun Oct 21 03:31:38 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171664 
>Unformatted:
