From jbeich@tormail.org  Sat Sep 15 11:44:56 2012
Return-Path: <jbeich@tormail.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DA8211065670
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2012 11:44:56 +0000 (UTC)
	(envelope-from jbeich@tormail.org)
Received: from outgoing.tormail.org (outgoing.tormail.org [82.221.96.22])
	by mx1.freebsd.org (Postfix) with ESMTP id 76BC68FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 15 Sep 2012 11:44:55 +0000 (UTC)
Received: from localhost ([127.0.0.1] helo=internal.tormail.org)
	by outgoing.tormail.org with esmtp (Exim 4.72)
	(envelope-from <jbeich@tormail.org>)
	id 1TCqXe-0005wZ-Qh
	for FreeBSD-gnats-submit@freebsd.org; Sat, 15 Sep 2012 15:28:08 +0400
Received: from jbeich by internal.tormail.org with local (Exim 4.63)
	(envelope-from <jbeich@tormail.org>)
	id 1TCqWE-000OAg-Au
	for FreeBSD-gnats-submit@freebsd.org; Sat, 15 Sep 2012 11:26:40 +0000
Message-Id: <1TCqWE-000OAg-Au@internal.tormail.org>
Date: Sat, 15 Sep 2012 02:26:36 -0900
From: Jan Beich <jbeich@tormail.org>
To: FreeBSD-gnats-submit@freebsd.org
Subject: procstat(1) fails to recognize AT_TIMEKEEP
X-GNATS-Notify: kib@freebsd.org, trociny@freebsd.org

>Number:         171662
>Category:       bin
>Synopsis:       [patch] procstat(1) fails to recognize AT_TIMEKEEP
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kib
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 15 11:50:09 UTC 2012
>Closed-Date:    Sun Sep 23 06:17:07 UTC 2012
>Last-Modified:  Sun Sep 23 06:20:06 UTC 2012
>Originator:     Jan Beich
>Release:        FreeBSD 10.0-CURRENT amd64
>Organization:
>Environment:
>Description:
>How-To-Repeat:
$ procstat -x $(pgrep firefox)
  PID COMM             AUXV             VALUE
90996 firefox          AT_PHDR          0x400040
90996 firefox          AT_PHENT         56
90996 firefox          AT_PHNUM         8
90996 firefox          AT_PAGESZ        4096
90996 firefox          AT_FLAGS         0
90996 firefox          AT_ENTRY         0x401790
90996 firefox          AT_BASE          0x80060d000
90996 firefox          AT_EXECPATH      0x7fffffffefc8
90996 firefox          AT_OSRELDATE     1000018
90996 firefox          AT_CANARY        0x7fffffffef88
90996 firefox          AT_CANARYLEN     64
90996 firefox          AT_NCPUS         2
90996 firefox          AT_PAGESIZES     0x7fffffffef70
90996 firefox          AT_PAGESIZESLEN  24
90996 firefox                        22 0x7ffffffff190
90996 firefox          AT_STACKPROT     EXECUTABLE
>Fix:
>Release-Note:
>Audit-Trail:

From: Konstantin Belousov <kostikbel@gmail.com>
To: Jan Beich <jbeich@tormail.org>
Cc: FreeBSD-gnats-submit@freebsd.org, trociny@freebsd.org
Subject: Re: bin/171662: procstat(1) fails to recognize AT_TIMEKEEP
Date: Sat, 15 Sep 2012 17:04:42 +0300

 --Gs9iBZf6UKWgztis
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Yes, I forgot about procstat at all when I added AT_TIMEKEEP.
 
 I also noted that AT_COUNT is defined in the switch statement, which
 is not useful. AT_COUNT is not an auxv at all, it is just count.
 
 diff --git a/usr.bin/procstat/procstat_auxv.c b/usr.bin/procstat/procstat_a=
 uxv.c
 index 9bf7afb..b78e13a 100644
 --- a/usr.bin/procstat/procstat_auxv.c
 +++ b/usr.bin/procstat/procstat_auxv.c
 @@ -231,9 +231,11 @@ procstat_auxv(struct kinfo_proc *kipp)
  			else
  				PRINT(AT_STACKPROT, %s, "EXECUTABLE");
  			break;
 -		case AT_COUNT:
 -			PRINT(AT_COUNT, %ld, (long)auxv[i].a_un.a_val);
 +#ifdef AT_TIMEKEEP
 +		case AT_TIMEKEEP:
 +			PRINT(AT_TIMEKEEP, %p, auxv[i].a_un.a_ptr);
  			break;
 +#endif
  		default:
  			PRINT_UNKNOWN(auxv[i].a_type, auxv[i].a_un.a_val);
  			break;
 
 --Gs9iBZf6UKWgztis
 Content-Type: application/pgp-signature
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.12 (FreeBSD)
 
 iEYEARECAAYFAlBUivoACgkQC3+MBN1Mb4hzpgCfbYe5K3wLrY3o6jqEwMt+CaiL
 OGsAn3+FVxju/YcO6AFi4ZQGaA1qexxg
 =J8Zi
 -----END PGP SIGNATURE-----
 
 --Gs9iBZf6UKWgztis--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/171662: commit references a PR
Date: Sun, 16 Sep 2012 05:53:11 +0000 (UTC)

 Author: kib
 Date: Sun Sep 16 05:52:54 2012
 New Revision: 240546
 URL: http://svn.freebsd.org/changeset/base/240546
 
 Log:
   Handle AT_TIMEKEEP in procstat(1) -x [1]. Remove the AT_COUNT switch
   case, since AT_COUNT is not an aux vector, it is the counter of total
   number of defined vectors.
   
   PR:	bin/171662 [1]
   MFC after:	1 week
 
 Modified:
   head/usr.bin/procstat/procstat_auxv.c
 
 Modified: head/usr.bin/procstat/procstat_auxv.c
 ==============================================================================
 --- head/usr.bin/procstat/procstat_auxv.c	Sun Sep 16 00:35:09 2012	(r240545)
 +++ head/usr.bin/procstat/procstat_auxv.c	Sun Sep 16 05:52:54 2012	(r240546)
 @@ -231,9 +231,11 @@ procstat_auxv(struct kinfo_proc *kipp)
  			else
  				PRINT(AT_STACKPROT, %s, "EXECUTABLE");
  			break;
 -		case AT_COUNT:
 -			PRINT(AT_COUNT, %ld, (long)auxv[i].a_un.a_val);
 +#ifdef AT_TIMEKEEP
 +		case AT_TIMEKEEP:
 +			PRINT(AT_TIMEKEEP, %p, auxv[i].a_un.a_ptr);
  			break;
 +#endif
  		default:
  			PRINT_UNKNOWN(auxv[i].a_type, auxv[i].a_un.a_val);
  			break;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: linimon 
State-Changed-When: Sun Sep 16 07:15:02 UTC 2012 
State-Changed-Why:  
set as MFC reminder. 


Responsible-Changed-From-To: freebsd-bugs->kib 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Sep 16 07:15:02 UTC 2012 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=171662 
State-Changed-From-To: patched->closed 
State-Changed-By: kib 
State-Changed-When: Sun Sep 23 06:16:51 UTC 2012 
State-Changed-Why:  
Merged. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171662 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/171662: commit references a PR
Date: Sun, 23 Sep 2012 06:16:23 +0000 (UTC)

 Author: kib
 Date: Sun Sep 23 06:16:08 2012
 New Revision: 240847
 URL: http://svn.freebsd.org/changeset/base/240847
 
 Log:
   MFC r240546:
   Handle AT_TIMEKEEP in procstat(1) -x.
   
   PR:	bin/171662
 
 Modified:
   stable/9/usr.bin/procstat/procstat_auxv.c
 Directory Properties:
   stable/9/usr.bin/procstat/   (props changed)
 
 Modified: stable/9/usr.bin/procstat/procstat_auxv.c
 ==============================================================================
 --- stable/9/usr.bin/procstat/procstat_auxv.c	Sun Sep 23 03:46:03 2012	(r240846)
 +++ stable/9/usr.bin/procstat/procstat_auxv.c	Sun Sep 23 06:16:08 2012	(r240847)
 @@ -231,9 +231,11 @@ procstat_auxv(struct kinfo_proc *kipp)
  			else
  				PRINT(AT_STACKPROT, %s, "EXECUTABLE");
  			break;
 -		case AT_COUNT:
 -			PRINT(AT_COUNT, %ld, (long)auxv[i].a_un.a_val);
 +#ifdef AT_TIMEKEEP
 +		case AT_TIMEKEEP:
 +			PRINT(AT_TIMEKEEP, %p, auxv[i].a_un.a_ptr);
  			break;
 +#endif
  		default:
  			PRINT_UNKNOWN(auxv[i].a_type, auxv[i].a_un.a_val);
  			break;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
