From bryan@shatow.net  Mon Sep 10 00:56:33 2012
Return-Path: <bryan@shatow.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A9EAF1065678
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Sep 2012 00:56:33 +0000 (UTC)
	(envelope-from bryan@shatow.net)
Received: from secure.xzibition.com (secure.xzibition.com [173.160.118.92])
	by mx1.freebsd.org (Postfix) with ESMTP id 5206F8FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 10 Sep 2012 00:56:33 +0000 (UTC)
Received: (qmail 14904 invoked from network); 9 Sep 2012 19:56:30 -0500
Received: from unknown (HELO test8.xzibition.com) (10.10.0.34)
  by sweb.xzibition.com with SMTP; 9 Sep 2012 19:56:30 -0500
Received: by test8.xzibition.com (sSMTP sendmail emulation); Sun, 09 Sep 2012 19:56:29 -0500
Message-Id: <20120910005633.A9EAF1065678@hub.freebsd.org>
Date: Sun, 09 Sep 2012 19:56:29 -0500
From: Bryan Drewery <bryan@shatow.net>
Reply-To: Bryan Drewery <bryan@shatow.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: eadler@FreeBSD.org
Subject: [PATCH] [usr.bin/man] Make man(1) default to use full screen if using a tty
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         171514
>Category:       bin
>Synopsis:       [PATCH] Make man(1) default to use full screen if using a tty
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 10 01:00:08 UTC 2012
>Closed-Date:    
>Last-Modified:  Fri Jul 19 18:57:00 UTC 2013
>Originator:     Bryan Drewery
>Release:        FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:

	
>Description:
	r222635 added support for MANWIDTH=tty which makes man(1) use the full screen if ran in a TTY. Make this the default, if MANWIDTH is not already set and not set to null.
>How-To-Repeat:
	
>Fix:

	

--- patch-man-default-MANWIDTH-tty.txt begins here ---
# svn status
M       usr.bin/man/man.sh

Index: usr.bin/man/man.sh
===================================================================
--- usr.bin/man/man.sh	(revision 240291)
+++ usr.bin/man/man.sh	(working copy)
@@ -576,7 +576,7 @@
 	local sizes
 
 	unset use_width
-	case "$MANWIDTH" in
+	case "${MANWIDTH-tty}" in
 	[0-9]*)
 		if [ "$MANWIDTH" -gt 0 2>/dev/null ]; then
 			use_width=$MANWIDTH
--- patch-man-default-MANWIDTH-tty.txt ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Sep 10 01:01:43 UTC 2012 
Responsible-Changed-Why:  
I'll deal with this one 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 10 11:42:05 UTC 2012 
State-Changed-Why:  
this is a test case 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
State-Changed-From-To: closed->open 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 10 11:45:20 UTC 2012 
State-Changed-Why:  
oops, wrong PR number 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Tue Sep 11 02:39:15 UTC 2012 
State-Changed-Why:  
awaiting approval 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 

From: Jilles Tjoelker <jilles@stack.nl>
To: bug-followup@FreeBSD.org, bryan@shatow.net
Cc:  
Subject: Re: bin/171514: [PATCH] Make man(1) default to use full screen if
 using a tty
Date: Sat, 15 Sep 2012 19:59:46 +0200

 I am nitpicking, but if you say
 
 > Make this the default, if MANWIDTH is not already set and not set to
 > null.
 
 then
 
 >+	case "${MANWIDTH-tty}" in
 
 is not actually doing that. It only gives "tty" when MANWIDTH is not set
 (or when it is set to "tty").
 
 If you also want to have "tty" when MANWIDTH is null, then use
 "${MANWIDTH:-tty}".
 
 -- 
 Jilles Tjoelker

From: Bryan Drewery <bryan@shatow.net>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/171514: [PATCH] Make man(1) default to use full screen if
 using a tty
Date: Sat, 15 Sep 2012 13:21:30 -0500

 On 9/15/2012 12:59 PM, Jilles Tjoelker wrote:
 > I am nitpicking, but if you say
 > 
 >> Make this the default, if MANWIDTH is not already set and not set to
 >> null.
 > 
 > then
 > 
 >> +	case "${MANWIDTH-tty}" in
 > 
 > is not actually doing that. It only gives "tty" when MANWIDTH is not set
 > (or when it is set to "tty").
 > 
 > If you also want to have "tty" when MANWIDTH is null, then use
 > "${MANWIDTH:-tty}".
 > 
 
 I misworded, I meant "set to blank", not "set to null". It's working as
 intended. I did not want to have it set to tty if someone does
 'MANWIDTH=' in their env.
 
 Bryan

From: Eitan Adler <eadler@freebsd.org>
To: Jilles Tjoelker <jilles@stack.nl>
Cc: bug-followup@freebsd.org
Subject: Re: bin/171514: [PATCH] Make man(1) default to use full screen if
 using a tty
Date: Sat, 15 Sep 2012 15:48:21 -0400

 On 15 September 2012 14:00, Jilles Tjoelker <jilles@stack.nl> wrote:
 >  I am nitpicking, but if you say
 >
 >  > Make this the default, if MANWIDTH is not already set and not set to
 >  > null.
 >
 >  then
 >
 >  >+     case "${MANWIDTH-tty}" in
 >
 ...
 
 There is some discussion now whether we should set a default
 environment variable, or change how man(1) functions. I've asked
 doceng@ and ru@ to comment. doceng@ redirected me to ru@. :)
 
 
 
 -- 
 Eitan Adler
 Source & Ports committer
 X11, Bugbusting teams
State-Changed-From-To: analyzed->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 30 03:31:44 UTC 2012 
State-Changed-Why:  
after some discussion it seems that changing the default isn't the 
correct decision at this time 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
State-Changed-From-To: closed->open 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 30 04:01:58 UTC 2012 
State-Changed-Why:  
per disussion with submitter, maybe it still should be done 

http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
Responsible-Changed-From-To: eadler->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Fri Jul 19 18:56:48 UTC 2013 
Responsible-Changed-Why:  
I don't have time to deal with this bug in the near future 


http://www.freebsd.org/cgi/query-pr.cgi?pr=171514 
>Unformatted:
