From nobody@FreeBSD.org  Sat Jun 23 16:43:31 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E8CC21065670
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 23 Jun 2012 16:43:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D258C8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 23 Jun 2012 16:43:31 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5NGhVOP079771
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 23 Jun 2012 16:43:31 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5NGhVYd079770;
	Sat, 23 Jun 2012 16:43:31 GMT
	(envelope-from nobody)
Message-Id: <201206231643.q5NGhVYd079770@red.freebsd.org>
Date: Sat, 23 Jun 2012 16:43:31 GMT
From: Devin Teske <dteske@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: "pw groupmod GROUP -h FD" ignores "passwd_format" from login.conf(5)
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169356
>Category:       bin
>Synopsis:       pw(8): "pw groupmod GROUP -h FD" ignores "passwd_format" from login.conf(5)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 23 16:50:08 UTC 2012
>Closed-Date:    
>Last-Modified:  Sat Jun 23 20:21:27 UTC 2012
>Originator:     Devin Teske
>Release:        FreeBSD 9.0-RELEASE i386
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe9.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan  3 07:15:25 UTC 2012     root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When attempting to set the password field for a group in group(5) using pw(8), only old-style DES hash is used. The passwd_format setting in login.conf(5) is ignored.
>How-To-Repeat:
First, witness that pw(8) adheres to the desired "passwd_format" setting in login.conf(5) when changing the password for a user (versus group):

echo newpass | sudo pw usermod SOMEUSER -h 0
sudo grep '^SOMEUSER:' /etc/master.passwd

NOTE: The password field (second field delimited by ":") contains a hash in the desired format (based on "passwd_format" setting in login.conf -- MD5 is the default, producing "$1$salt$data" in the password field).

Now, witness that when doing the same thing but for a group, login.conf(5) is now ignored and only a DES hash can be generated:

echo newpass | sudo pw groupmod SOMEGROUP -h 0
grep '^SOMEGROUP:' /etc/group
>Fix:
I see two ways forward:

1. Update pw(8) to adhere to passwd_format when "groupmod GROUP -h FD" is used (making it act similar to "usermod USER -h FD")

2. Add a new "group_passwd_format" to login.conf(5) and make pw(8) adhere to that.

>Release-Note:
>Audit-Trail:
>Unformatted:
