From nobody@FreeBSD.org  Fri Jun 15 21:23:58 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5B811106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jun 2012 21:23:58 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 4678B8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jun 2012 21:23:58 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5FLNv7w070875
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 15 Jun 2012 21:23:57 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q5FLNvwK070874;
	Fri, 15 Jun 2012 21:23:57 GMT
	(envelope-from nobody)
Message-Id: <201206152123.q5FLNvwK070874@red.freebsd.org>
Date: Fri, 15 Jun 2012 21:23:57 GMT
From: Ruben de Groot <ruben@hacktor.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Resurrect a traditional and fun function name
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         169127
>Category:       bin
>Synopsis:       Resurrect a traditional and fun function name
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jun 16 00:03:28 UTC 2012
>Closed-Date:    Wed Sep 12 11:03:30 UTC 2012
>Last-Modified:  Wed Sep 12 11:03:30 UTC 2012
>Originator:     Ruben de Groot
>Release:        multiple
>Organization:
Competa IT
>Environment:
FreeBSD morninglightmountain.hacktor.net 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Mon Apr 27 22:37:12 UTC 2009     root@morninglightmountain.hacktor.net:/usr/obj/usr/src/sys/MORNINGLIGHTMOUNTAIN  sparc64
>Description:
Just the other day, while showing a younger colleague his way around the FreeBSD source tree, I wanted to show him the cool "die_you_gravy_sucking_pig_dog" funtion, as an example how coding can be fun.

Regretfully I found this function is no longer in the shutdown.c source. It has apparently been removed in an otherwise very unsubstantial commit (Revision 1.30, Tue Dec 29 08:49:43 2009)

I don't think the function name was moronic. It's historic and deserves to be in the source tree. Therefore I propose to return to the original funtion name, keeping the funtional changes (void) made in that commit.

>How-To-Repeat:
1) have a little sense of humor
2) read shutdown.c before Tue Dec 29 08:49:43 2009
3) read shutdown.c after Tue Dec 29 08:49:43 2009

>Fix:
patch attached

Patch attached with submission follows:

--- src/sbin/shutdown/shutdown.c.orig	2012-05-23 21:25:46.000000000 +0200
+++ src/sbin/shutdown/shutdown.c	2012-06-15 22:52:04.000000000 +0200
@@ -93,7 +93,7 @@
 static const char *nosync, *whom;
 
 static void badtime(void);
-static void perform_shutdown(void);
+static void die_you_gravy_sucking_pig_dog(void);
 static void finish(int);
 static void getoffset(char *);
 static void loop(void);
@@ -282,7 +282,7 @@
 		if (!tp->timeleft)
 			break;
 	}
-	perform_shutdown();
+	die_you_gravy_sucking_pig_dog();
 }
 
 static jmp_buf alarmbuf;
@@ -349,7 +349,7 @@
 }
 
 static void
-perform_shutdown(void)
+die_you_gravy_sucking_pig_dog(void)
 {
 	char *empty_environ[] = { NULL };
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-advocacy->freebsd-bugs 
Responsible-Changed-By: jhb 
Responsible-Changed-When: Mon Jul 30 12:18:41 UTC 2012 
Responsible-Changed-Why:  
Not an advocacy PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169127 

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, ruben@hacktor.com
Cc: Ed Schouten <ed@freebsd.org>
Subject: Re: advocacy/169127: Resurrect a traditional and fun function name
Date: Mon, 30 Jul 2012 08:18:28 -0400

 While it is true that the original function name goes back to BSD (and
 predates FreeBSD), I'm not sure it is worth renaming it back.
 
 -- 
 John Baldwin

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/169127: commit references a PR
Date: Wed,  1 Aug 2012 09:10:33 +0000 (UTC)

 Author: des
 Date: Wed Aug  1 09:10:21 2012
 New Revision: 238968
 URL: http://svn.freebsd.org/changeset/base/238968
 
 Log:
   Restore a piece of BSD history.
   
   PR:		169127
   Submitted by:	Ruben de Groot <ruben@hacktor.com>
   MFC after:	1 week
 
 Modified:
   head/sbin/shutdown/shutdown.c
 
 Modified: head/sbin/shutdown/shutdown.c
 ==============================================================================
 --- head/sbin/shutdown/shutdown.c	Wed Aug  1 09:00:26 2012	(r238967)
 +++ head/sbin/shutdown/shutdown.c	Wed Aug  1 09:10:21 2012	(r238968)
 @@ -93,7 +93,7 @@ static char mbuf[BUFSIZ];
  static const char *nosync, *whom;
  
  static void badtime(void);
 -static void perform_shutdown(void);
 +static void die_you_gravy_sucking_pig_dog(void);
  static void finish(int);
  static void getoffset(char *);
  static void loop(void);
 @@ -282,7 +282,7 @@ loop(void)
  		if (!tp->timeleft)
  			break;
  	}
 -	perform_shutdown();
 +	die_you_gravy_sucking_pig_dog();
  }
  
  static jmp_buf alarmbuf;
 @@ -349,7 +349,7 @@ timeout(int signo __unused)
  }
  
  static void
 -perform_shutdown(void)
 +die_you_gravy_sucking_pig_dog(void)
  {
  	char *empty_environ[] = { NULL };
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Wed Sep 12 11:03:27 UTC 2012 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=169127 
>Unformatted:
