From truckman@FreeBSD.org  Thu May 17 00:56:16 2012
Return-Path: <truckman@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AE5C2106566C;
	Thu, 17 May 2012 00:56:16 +0000 (UTC)
	(envelope-from truckman@FreeBSD.org)
Received: from gw.catspoiler.org (gw.catspoiler.org [75.1.14.242])
	by mx1.freebsd.org (Postfix) with ESMTP id 86E088FC08;
	Thu, 17 May 2012 00:56:16 +0000 (UTC)
Received: from mousie.catspoiler.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id q4H0uG7T094972;
	Wed, 16 May 2012 17:56:16 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: from mousie.catspoiler.org (localhost.catspoiler.org [127.0.0.1])
	by mousie.catspoiler.org (8.14.5/8.14.5) with ESMTP id q4H0uFB0074604;
	Wed, 16 May 2012 17:56:15 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Received: (from dl@localhost)
	by mousie.catspoiler.org (8.14.5/8.14.5/Submit) id q4H0uFWh074603;
	Wed, 16 May 2012 17:56:15 -0700 (PDT)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <201205170056.q4H0uFWh074603@mousie.catspoiler.org>
Date: Wed, 16 May 2012 17:56:15 -0700 (PDT)
From: Don Lewis <truckman@FreeBSD.org>
Reply-To: Don Lewis <truckman@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: stas@FreeBSD.org
Subject: location of <com_err.h> install doesn't match man page
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         167986
>Category:       bin
>Synopsis:       location of <com_err.h> install doesn't match man page
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 17 01:00:09 UTC 2012
>Closed-Date:    
>Last-Modified:  Sun Sep 02 17:06:29 UTC 2012
>Originator:     Don Lewis
>Release:        FreeBSD 10.0-CURRENT i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD scratch.catspoiler.org 10.0-CURRENT FreeBSD 10.0-CURRENT #6: Tue May 15 14:19:58 PDT 2012 dl@scratch.catspoiler.org:/usr/obj/usr/src/sys/GENERIC SMB i386


> Description:

The man page for com_err(3) says that <krb5/com_err.h> should be included,
but the com_err.h include file is installed directly under /usr/include.

>Description:
>How-To-Repeat:

>Fix:

For compatibility with upstream, <com_err.h> should probably be installed
under /usr/include/krb5.  Maybe there should also be compatibility crutch
installed under /usr/include.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu May 17 01:08:42 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167986 

From: Garrett Wollman <wollman@hergotha.csail.mit.edu>
To: truckman@freebsd.org
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man page
Date: Wed, 16 May 2012 22:30:51 -0400 (EDT)

 In article <201205170056.q4H0uFWh074603@mousie.catspoiler.org>,
 truckman@freebsd.org> writes:
 
 >For compatibility with upstream, <com_err.h> should probably be installed
 >under /usr/include/krb5.  Maybe there should also be compatibility crutch
 >installed under /usr/include.
 
 It also shouldn't be installed at all when Heimdal is not being built.
 Nothing else in the base system uses it, and it conflicts with the
 standard MIT Kerberos version of this library.
 
 -GAWollman
 

From: Stanislav Sedov <stas@FreeBSD.org>
To: Don Lewis <truckman@FreeBSD.org>
Cc: FreeBSD PR followup <bug-followup@FreeBSD.org>,
 wollman@hergotha.csail.mit.edu
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Sun, 20 May 2012 19:15:24 -0700

 Hi!
 
 Thanks for the bug report.
 Do you know if there any 3rd party software that assumes the com_err.h
 header file is located in krb5/ directory?  FreeBSD is used to install
 it in /usr/include historically, and I would prefer not to change it.
 OTOH, we can always install a symlink to krb5/ if 3rd party software
 compatibility is at a stake.
 
 As for the suggestion to not install it with kerberos disabled -- I
 think we already do this?
 
 -- 
 Stanislav Sedov
 ST4096-RIPE
 
 ()  ascii ribbon campaign - against html e-mail 
 /\  www.asciiribbon.org   - against proprietary attachments

From: Don Lewis <truckman@FreeBSD.org>
To: stas@FreeBSD.org
Cc: bug-followup@FreeBSD.org, wollman@hergotha.csail.mit.edu
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Sun, 20 May 2012 19:59:33 -0700 (PDT)

 On 20 May, Stanislav Sedov wrote:
 > Hi!
 > 
 > Thanks for the bug report.
 > Do you know if there any 3rd party software that assumes the com_err.h
 > header file is located in krb5/ directory?  FreeBSD is used to install
 > it in /usr/include historically, and I would prefer not to change it.
 > OTOH, we can always install a symlink to krb5/ if 3rd party software
 > compatibility is at a stake.
 
 I'm not aware of anything.  I just stumbled across this iconsistency
 when I was trying to find a fix the the problem that I reported in
 ports/167989.  The evolution-data-server port expects to find com_err.h
 under /usr/include, but it doesn't know that it needs to pull in the
 other include files listed in the the com_err(3) man page.  Maybe
 finding com_err.h under krb5 would provide the proper hint ...
 
 

From: Garrett Wollman <wollman@FreeBSD.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Cc: FreeBSD PR followup <bug-followup@FreeBSD.org>
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Mon, 21 May 2012 00:06:56 -0400

 <<On Sun, 20 May 2012 19:15:24 -0700, Stanislav Sedov <stas@FreeBSD.org> said:
 
 > As for the suggestion to not install it with kerberos disabled -- I
 > think we already do this?
 
 I would not have mentioned it were that the case.  Every time I do an
 installworld, I have to go and delete all of the com_err bits so that
 they won't conflict with the MIT com_err bits.  About a week ago I
 finally got around to patching one of my source trees to build a
 completely com_err-free world, and there were no issues.
 
 -GAWollman

From: Stanislav Sedov <stas@FreeBSD.org>
To: Garrett Wollman <wollman@FreeBSD.org>
Cc: FreeBSD PR followup <bug-followup@FreeBSD.org>
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Sun, 20 May 2012 21:24:39 -0700

 On Mon, 21 May 2012 00:06:56 -0400
 Garrett Wollman <wollman@FreeBSD.org> mentioned:
 
 > <<On Sun, 20 May 2012 19:15:24 -0700, Stanislav Sedov <stas@FreeBSD.org> said:
 > 
 > > As for the suggestion to not install it with kerberos disabled -- I
 > > think we already do this?
 > 
 > I would not have mentioned it were that the case.  Every time I do an
 > installworld, I have to go and delete all of the com_err bits so that
 > they won't conflict with the MIT com_err bits.  About a week ago I
 > finally got around to patching one of my source trees to build a
 > completely com_err-free world, and there were no issues.
 > 
 
 Hmm, are you sure this happens with HEAD as well?
 I can't see how installworld may install any com_err bits with kerberos
 disabled unless MK_KERBEROS_SUPPORT is not getting propagated
 to lib/Makefile.  I'll try to do buildworld/installworld tomorrow
 with Kerberos disabled to confirm.
 
 -- 
 Stanislav Sedov
 ST4096-RIPE
 
 ()  ascii ribbon campaign - against html e-mail 
 /\  www.asciiribbon.org   - against proprietary attachments

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/167986: commit references a PR
Date: Mon, 21 May 2012 04:29:21 +0000 (UTC)

 Author: stas
 Date: Mon May 21 04:29:11 2012
 New Revision: 235716
 URL: http://svn.freebsd.org/changeset/base/235716
 
 Log:
   - On FreeBSD, com_err.h is installed into /usr/include, not /usr/include/krb5.
     Reflect that in the manpage.
   
   PR:		bin/167986
   Reported by:	truckman@
 
 Modified:
   head/contrib/com_err/com_err.3
 
 Modified: head/contrib/com_err/com_err.3
 ==============================================================================
 --- head/contrib/com_err/com_err.3	Mon May 21 04:24:58 2012	(r235715)
 +++ head/contrib/com_err/com_err.3	Mon May 21 04:29:11 2012	(r235716)
 @@ -54,7 +54,7 @@ Common Error Library (libcom_err, -lcom_
  .Sh SYNOPSIS
  .Fd #include <stdio.h>
  .Fd #include <stdarg.h>
 -.Fd #include <krb5/com_err.h>
 +.Fd #include <com_err.h>
  .Fd #include \&"XXX_err.h\&"
  .Pp
  typedef void (*errf)(const char *, long, const char *, ...);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Stanislav Sedov <stas@FreeBSD.org>
To: Don Lewis <truckman@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, wollman@hergotha.csail.mit.edu
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Sun, 20 May 2012 21:31:22 -0700

 On Sun, 20 May 2012 19:59:33 -0700 (PDT)
 Don Lewis <truckman@FreeBSD.org> mentioned:
 
 > On 20 May, Stanislav Sedov wrote:
 > > Hi!
 > > 
 > > Thanks for the bug report.
 > > Do you know if there any 3rd party software that assumes the com_err.h
 > > header file is located in krb5/ directory?  FreeBSD is used to install
 > > it in /usr/include historically, and I would prefer not to change it.
 > > OTOH, we can always install a symlink to krb5/ if 3rd party software
 > > compatibility is at a stake.
 > 
 > I'm not aware of anything.  I just stumbled across this iconsistency
 > when I was trying to find a fix the the problem that I reported in
 > ports/167989.  The evolution-data-server port expects to find com_err.h
 > under /usr/include, but it doesn't know that it needs to pull in the
 > other include files listed in the the com_err(3) man page.  Maybe
 > finding com_err.h under krb5 would provide the proper hint ...
 > 
 
 I just committed a fix to the manpage to point to the <com_err.h>
 header instead.  We might still need to install a symlink to krb5/
 in future if we see some compatibility issues with 3rd party software,
 but for now let's leave it like this.
 
 Thanks!
 
 -- 
 Stanislav Sedov
 ST4096-RIPE
 
 ()  ascii ribbon campaign - against html e-mail 
 /\  www.asciiribbon.org   - against proprietary attachments

From: Garrett Wollman <wollman@bimajority.org>
To: Stanislav Sedov <stas@FreeBSD.org>
Cc: FreeBSD PR followup <bug-followup@FreeBSD.org>
Subject: Re: bin/167986: location of <com_err.h> install doesn't match man
 page
Date: Mon, 21 May 2012 11:57:00 -0400

 <<On Sun, 20 May 2012 21:24:39 -0700, Stanislav Sedov <stas@FreeBSD.org> said:
 
 > Hmm, are you sure this happens with HEAD as well?
 
 Not sure at all.  If it's already fixed in HEAD, that's great; please
 merge the fix to [89]-STABLE.
 
 -GAWollman
 
Responsible-Changed-From-To: eadler->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Sep 2 17:06:26 UTC 2012 
Responsible-Changed-Why:  
I won't be looking at this PR for a while and I need to clear some out 
of my queue 

http://www.freebsd.org/cgi/query-pr.cgi?pr=167986 
>Unformatted:
