From nobody@FreeBSD.org  Wed Mar  7 15:55:56 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAEB51065672
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Mar 2012 15:55:56 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id DA25C8FC19
	for <freebsd-gnats-submit@FreeBSD.org>; Wed,  7 Mar 2012 15:55:56 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q27FtuiG074200
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 7 Mar 2012 15:55:56 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q27FtuTE074199;
	Wed, 7 Mar 2012 15:55:56 GMT
	(envelope-from nobody)
Message-Id: <201203071555.q27FtuTE074199@red.freebsd.org>
Date: Wed, 7 Mar 2012 15:55:56 GMT
From: Andreas Longwitz <longwitz@incore.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: missing "-J" in "dumpfs -m" for gjournal file systems
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         165821
>Category:       bin
>Synopsis:       [patch] dumpfs(8): missing "-J" in "dumpfs -m" for gjournal file systems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 16:00:27 UTC 2012
>Closed-Date:    Tue Oct 30 03:31:54 UTC 2012
>Last-Modified:  Tue Oct 30 03:31:54 UTC 2012
>Originator:     Andreas Longwitz
>Release:        FreeBSD 8.2-STABLE
>Organization:
Data Service Stockelsdorf
>Environment:
FreeBSD dsssrvt2.incore 8.2-STABLE FreeBSD 8.2-STABLE #0: Wed Feb 22 14:47:19 CET 2012 root@dsssrvt2.incore:/usr/obj/usr/src/sys/SERVER64  amd64
>Description:
The command dumpfs -m fs for a gjournal file system fs does not put "-J" to his output.
>How-To-Repeat:

>Fix:
--- sbin/dumpfs/dumpfs.c.orig   2012-01-26 12:41:54.000000000 +0100
+++ sbin/dumpfs/dumpfs.c        2012-03-07 16:41:48.000000000 +0100
@@ -408,6 +408,8 @@
        printf("-O %d ", disk.d_ufs);
        if (fs->fs_flags & FS_DOSOFTDEP)
                printf("-U ");
+       if (fs->fs_flags & FS_GJOURNAL)
+               printf("-J ");
        printf("-a %d ", fs->fs_maxcontig);
        printf("-b %d ", fs->fs_bsize);
        /* -c is dumb */

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Mon Jul 9 00:25:07 UTC 2012 
Responsible-Changed-Why:  
I'll take it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165821 
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Sun Oct 14 18:12:50 UTC 2012 
State-Changed-Why:  
awaiting approval / review 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165821 
State-Changed-From-To: analyzed->closed 
State-Changed-By: eadler 
State-Changed-When: Tue Oct 30 03:31:53 UTC 2012 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165821 
>Unformatted:
