From cejkar@fit.vutbr.cz  Wed Mar  7 08:37:45 2012
Return-Path: <cejkar@fit.vutbr.cz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FF821065670
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2012 08:37:45 +0000 (UTC)
	(envelope-from cejkar@fit.vutbr.cz)
Received: from kazi.fit.vutbr.cz (kazi6.fit.vutbr.cz [IPv6:2001:67c:1220:808::93e5:80c])
	by mx1.freebsd.org (Postfix) with ESMTP id B1F4D8FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2012 08:37:44 +0000 (UTC)
Received: from kazi.fit.vutbr.cz (localhost [127.0.0.1])
	by kazi.fit.vutbr.cz (envelope-from cejkar@fit.vutbr.cz) (8.14.5/8.14.4) with ESMTP id q278bgo6048025
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 7 Mar 2012 09:37:42 +0100 (CET)
Received: (from cejkar@localhost)
	by kazi.fit.vutbr.cz (8.14.5/8.13.1/Submit) id q278bgcI048024;
	Wed, 7 Mar 2012 09:37:42 +0100 (CET)
	(envelope-from cejkar)
Message-Id: <201203070837.q278bgcI048024@kazi.fit.vutbr.cz>
Date: Wed, 7 Mar 2012 09:37:42 +0100 (CET)
From: Rudolf Cejka <cejkar@fit.vutbr.cz>
Reply-To: Rudolf Cejka <cejkar@fit.vutbr.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: setfacl -b is broken
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165807
>Category:       bin
>Synopsis:       setfacl(1): setfacl -b is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    trasz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 08:40:15 UTC 2012
>Closed-Date:    Tue Jun 25 08:35:04 UTC 2013
>Last-Modified:  Tue Jun 25 08:35:04 UTC 2013
>Originator:     Rudolf Cejka
>Release:        FreeBSD 8.2-STABLE i386
>Organization:
FIT, Brno University of Technology, Czech Republic
>Environment:
>Description:

setfacl -b is broken, because it does not remove ACL mask (it seems to me,
that in FreeBSD once on some object ACLs are set, it is not possible to
completely remove then anymore - in Linux it is possible to use
setfacl -b file or setfacl -x mask file if there is remaining just mask):

# touch file
# setfacl -m u:root:rw file
# setfacl -b file
# getfacl file
# file: file
# owner: root
# group: wheel
user::rw-
group::r--
mask::r--
other::r--

Also, when setfacl -b is used on default direcotry ACLs, which are not
created yet, it dumps core:

# mkdir dir
# setfacl -b -d dir
Assertion failed: (_acl_brand(acl_new) == ACL_BRAND_POSIX), function _posix1e_acl_strip_np, file /usr/src/lib/libc/posix1e/acl_strip.c, line 129.
Abort trap: 6 (core dumped)
>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:

From: Cejka Rudolf <cejkar@fit.vutbr.cz>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:  
Subject: Re: bin/165807: setfacl -b is broken
Date: Wed, 7 Mar 2012 10:16:59 +0100

 Oops, I'm sorry, setfacl -n -b file removes also mask, so please ignore
 first part about complete removal of ACLs - setfacl -nb is sufficient.
 
 -- 
 Rudolf Cejka <cejkar at fit.vutbr.cz> http://www.fit.vutbr.cz/~cejkar
 Brno University of Technology, Faculty of Information Technology
 Bozetechova 2, 612 66  Brno, Czech Republic
Responsible-Changed-From-To: freebsd-bugs->trasz 
Responsible-Changed-By: trasz 
Responsible-Changed-When: Mon Sep 3 17:30:53 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165807 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/165807: commit references a PR
Date: Tue,  4 Sep 2012 11:50:24 +0000 (UTC)

 Author: trasz
 Date: Tue Sep  4 11:50:13 2012
 New Revision: 240084
 URL: http://svn.freebsd.org/changeset/base/240084
 
 Log:
   Make "setfacl -bd" an alias for "setfacl -k".  Previously it would crash
   on assert.
   
   PR:		bin/165807
   MFC after:	1 month
 
 Modified:
   head/bin/setfacl/setfacl.c
 
 Modified: head/bin/setfacl/setfacl.c
 ==============================================================================
 --- head/bin/setfacl/setfacl.c	Tue Sep  4 11:43:00 2012	(r240083)
 +++ head/bin/setfacl/setfacl.c	Tue Sep  4 11:50:13 2012	(r240084)
 @@ -264,6 +264,17 @@ main(int argc, char *argv[])
  				need_mask = 1;
  				break;
  			case OP_REMOVE_EXT:
 +				/*
 +				 * Don't try to call remove_ext() for empty
 +				 * default ACL.
 +				 */
 +				if (acl_type == ACL_TYPE_DEFAULT &&
 +				    acl_get_entry(acl, ACL_FIRST_ENTRY,
 +				    &unused_entry) == 0) {
 +					local_error += remove_default(&acl,
 +					    file->filename);
 +					break;
 +				}
  				remove_ext(&acl, file->filename);
  				need_mask = 0;
  				break;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: trasz 
State-Changed-When: Tue Sep 4 12:04:56 UTC 2012 
State-Changed-Why:  
Fixed in HEAD. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165807 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/165807: commit references a PR
Date: Thu,  4 Oct 2012 08:52:38 +0000 (UTC)

 Author: trasz
 Date: Thu Oct  4 08:33:46 2012
 New Revision: 241185
 URL: http://svn.freebsd.org/changeset/base/241185
 
 Log:
   MFC r240084:
   
   Make "setfacl -bd" an alias for "setfacl -k".  Previously it would crash
   on assert.
   
   PR:		bin/165807
 
 Modified:
   stable/9/bin/setfacl/setfacl.c
 Directory Properties:
   stable/9/bin/setfacl/   (props changed)
 
 Modified: stable/9/bin/setfacl/setfacl.c
 ==============================================================================
 --- stable/9/bin/setfacl/setfacl.c	Thu Oct  4 08:26:49 2012	(r241184)
 +++ stable/9/bin/setfacl/setfacl.c	Thu Oct  4 08:33:46 2012	(r241185)
 @@ -264,6 +264,17 @@ main(int argc, char *argv[])
  				need_mask = 1;
  				break;
  			case OP_REMOVE_EXT:
 +				/*
 +				 * Don't try to call remove_ext() for empty
 +				 * default ACL.
 +				 */
 +				if (acl_type == ACL_TYPE_DEFAULT &&
 +				    acl_get_entry(acl, ACL_FIRST_ENTRY,
 +				    &unused_entry) == 0) {
 +					local_error += remove_default(&acl,
 +					    file->filename);
 +					break;
 +				}
  				remove_ext(&acl, file->filename);
  				need_mask = 0;
  				break;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: trasz 
State-Changed-When: Tue Jun 25 08:34:59 UTC 2013 
State-Changed-Why:  
Fixed in both HEAD and 9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165807 
>Unformatted:
