From amdmi3@amdmi3.ru  Mon Feb 13 01:17:51 2012
Return-Path: <amdmi3@amdmi3.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D861106566C
	for <freebsd-gnats-submit@freebsd.org>; Mon, 13 Feb 2012 01:17:51 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.57])
	by mx1.freebsd.org (Postfix) with ESMTP id 302EE8FC0A
	for <freebsd-gnats-submit@freebsd.org>; Mon, 13 Feb 2012 01:17:50 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256)
	(Exim 4.76)
	(envelope-from <amdmi3@amdmi3.ru>)
	id 1RwkXo-0002uG-50; Mon, 13 Feb 2012 05:17:28 +0400
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id E1CB5B84D;
	Mon, 13 Feb 2012 05:17:27 +0400 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id D419B381; Mon, 13 Feb 2012 05:17:27 +0400 (MSK)
Message-Id: <20120213011727.D419B381@hades.panopticon>
Date: Mon, 13 Feb 2012 05:17:27 +0400 (MSK)
From: Dmitry Marakasov <amdmi3@FreeBSD.org>
Reply-To: Dmitry Marakasov <amdmi3@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: kib@FreeBSD.org
Subject: rtld error messages are missing a newline
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         165075
>Category:       bin
>Synopsis:       rtld error messages are missing a newline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kib
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 13 01:20:06 UTC 2012
>Closed-Date:    Thu Feb 16 11:25:21 UTC 2012
>Last-Modified:  Thu Feb 16 11:25:21 UTC 2012
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 10 01:33:18 MSK 2012 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64


>Description:
There's a regression somewhere between 8.2 and 9.0 which removed newline characters from rtld error messages, which makes them less- or unreadable depending on shell used.

>How-To-Repeat:
Get rtld error (missing library for example) on 9.0-RELEASE or later.

% perl -e 'print "TEST\n";'
% echo $?
1
% perl; echo
Shared object "libm.so.5" not found, required by "perl"
% perl 2>&1 | hexdump -C
00000000  53 68 61 72 65 64 20 6f  62 6a 65 63 74 20 22 6c  |Shared object "l|
00000010  69 62 6d 2e 73 6f 2e 35  22 20 6e 6f 74 20 66 6f  |ibm.so.5" not fo|
00000020  75 6e 64 2c 20 72 65 71  75 69 72 65 64 20 62 79  |und, required by|
00000030  20 22 70 65 72 6c 22                              | "perl"|
                               ^^          no newline :(            ^

>Fix:

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: kib 
State-Changed-When: Mon Feb 13 11:14:49 UTC 2012 
State-Changed-Why:  
Fix in head. 


Responsible-Changed-From-To: freebsd-bugs->kib 
Responsible-Changed-By: kib 
Responsible-Changed-When: Mon Feb 13 11:14:49 UTC 2012 
Responsible-Changed-Why:  
Fix in head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165075 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/165075: commit references a PR
Date: Mon, 13 Feb 2012 11:15:45 +0000 (UTC)

 Author: kib
 Date: Mon Feb 13 11:15:29 2012
 New Revision: 231582
 URL: http://svn.freebsd.org/changeset/base/231582
 
 Log:
   Add missed EOL when die() was converted to use rtld_fdputstr() instead
   of errx().
   
   Reported by:	amdmi3
   PR:	bin/165075
   MFC after:	3 days
 
 Modified:
   head/libexec/rtld-elf/rtld.c
 
 Modified: head/libexec/rtld-elf/rtld.c
 ==============================================================================
 --- head/libexec/rtld-elf/rtld.c	Mon Feb 13 10:48:43 2012	(r231581)
 +++ head/libexec/rtld-elf/rtld.c	Mon Feb 13 11:15:29 2012	(r231582)
 @@ -757,6 +757,7 @@ die(void)
      if (msg == NULL)
  	msg = "Fatal error";
      rtld_fdputstr(STDERR_FILENO, msg);
 +    rtld_fdputchar(STDERR_FILENO, '\n');
      _exit(1);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/165075: commit references a PR
Date: Thu, 16 Feb 2012 10:58:25 +0000 (UTC)

 Author: kib
 Date: Thu Feb 16 10:58:15 2012
 New Revision: 231820
 URL: http://svn.freebsd.org/changeset/base/231820
 
 Log:
   MFC r231582:
   Add missed EOL when die() was converted to use rtld_fdputstr() instead
   of errx().
   
   PR:	bin/165075
 
 Modified:
   stable/9/libexec/rtld-elf/rtld.c
 Directory Properties:
   stable/9/libexec/rtld-elf/   (props changed)
 
 Modified: stable/9/libexec/rtld-elf/rtld.c
 ==============================================================================
 --- stable/9/libexec/rtld-elf/rtld.c	Thu Feb 16 06:45:51 2012	(r231819)
 +++ stable/9/libexec/rtld-elf/rtld.c	Thu Feb 16 10:58:15 2012	(r231820)
 @@ -757,6 +757,7 @@ die(void)
      if (msg == NULL)
  	msg = "Fatal error";
      rtld_fdputstr(STDERR_FILENO, msg);
 +    rtld_fdputchar(STDERR_FILENO, '\n');
      _exit(1);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: kib 
State-Changed-When: Thu Feb 16 11:24:58 UTC 2012 
State-Changed-Why:  
Merged to 9, not relevant for 8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=165075 
>Unformatted:
