From nobody@FreeBSD.org  Fri Jan 27 09:45:15 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C29AE1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Jan 2012 09:45:15 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id B167D8FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Jan 2012 09:45:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0R9jFAN011220
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Jan 2012 09:45:15 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0R9jFIB011219;
	Fri, 27 Jan 2012 09:45:15 GMT
	(envelope-from nobody)
Message-Id: <201201270945.q0R9jFIB011219@red.freebsd.org>
Date: Fri, 27 Jan 2012 09:45:15 GMT
From: Marcus Reid <marcus@blazingdot.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ps(1) truncates command to screen size even when stdout is not a tty
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164535
>Category:       bin
>Synopsis:       [patch] ps(1) truncates command to screen size even when stdout is not a tty
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 27 09:50:09 UTC 2012
>Closed-Date:    
>Last-Modified:  Fri Jan 27 20:50:37 UTC 2012
>Originator:     Marcus Reid
>Release:        9.0-STABLE
>Organization:
>Environment:
FreeBSD seabug 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Jan  9 10:53:27 PST 2012     root@seabug:/usr/obj/usr/src/sys/FARK  amd64
>Description:
ps(1) truncates long commands to the size of the screen even when stdout is not a terminal.  This is counter-intuitive and differs from another implementation I looked at.  Output of ps | grep differs depending on how big your terminal window is for example.
>How-To-Repeat:
ps aux | grep
ps auxww | grep
>Fix:
Patch included.  Tested; behavior remains consistent with docs: COLUMNS variable retains effect, and -w limits to 132 characters still.


--- bin/ps/ps.c.orig    2012-01-27 01:24:10.519024952 -0800
+++ bin/ps/ps.c 2012-01-27 01:24:20.350023629 -0800
@@ -187,6 +187,8 @@
 
        if ((cols = getenv("COLUMNS")) != NULL && *cols != '\0')
                termwidth = atoi(cols);
+       else if (isatty(STDOUT_FILENO) == 0)
+               termwidth = UNLIMITED;
        else if ((ioctl(STDOUT_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
             ioctl(STDERR_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
             ioctl(STDIN_FILENO,  TIOCGWINSZ, (char *)&ws) == -1) ||


Patch attached with submission follows:

--- bin/ps/ps.c.orig	2012-01-27 01:24:10.519024952 -0800
+++ bin/ps/ps.c	2012-01-27 01:24:20.350023629 -0800
@@ -187,6 +187,8 @@
 
 	if ((cols = getenv("COLUMNS")) != NULL && *cols != '\0')
 		termwidth = atoi(cols);
+	else if (isatty(STDOUT_FILENO) == 0)
+		termwidth = UNLIMITED;
 	else if ((ioctl(STDOUT_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
 	     ioctl(STDERR_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
 	     ioctl(STDIN_FILENO,  TIOCGWINSZ, (char *)&ws) == -1) ||


>Release-Note:
>Audit-Trail:

From: Bruce Evans <brde@optusnet.com.au>
To: Marcus Reid <marcus@blazingdot.com>
Cc: freebsd-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org
Subject: Re: bin/164535: ps(1) truncates command to screen size even when
 stdout is not a tty
Date: Fri, 27 Jan 2012 22:49:35 +1100 (EST)

 On Fri, 27 Jan 2012, Marcus Reid wrote:
 
 >> Description:
 > ps(1) truncates long commands to the size of the screen even when stdout is not a terminal.  This is counter-intuitive and differs from another implementation I looked at.  Output of ps | grep differs depending on how big your terminal window is for example.
 >> How-To-Repeat:
 > ps aux | grep
 > ps auxww | grep
 >> Fix:
 > Patch included.  Tested; behavior remains consistent with docs: COLUMNS variable retains effect, and -w limits to 132 characters still.
 >
 >
 > Patch attached with submission follows:
 >
 > --- bin/ps/ps.c.orig	2012-01-27 01:24:10.519024952 -0800
 > +++ bin/ps/ps.c	2012-01-27 01:24:20.350023629 -0800
 > @@ -187,6 +187,8 @@
 >
 > 	if ((cols = getenv("COLUMNS")) != NULL && *cols != '\0')
 > 		termwidth = atoi(cols);
 > +	else if (isatty(STDOUT_FILENO) == 0)
 > +		termwidth = UNLIMITED;
 
 This change defeats the else clause, which checks all of STDOUT_FILENO,
 STDERR_FILENO and STDIN_FILENO and uses the terminal width iff any if
 these is a terminal according to the TIOCGWINSZ test for being a
 terminal, and otherwise gives a default of 79 columns (not UNLIMITED,
 which is only documented for ps -ww and only reachable using that and
 via the missing sanity checking for COLUMNS=0).
 
 > 	else if ((ioctl(STDOUT_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
 > 	     ioctl(STDERR_FILENO, TIOCGWINSZ, (char *)&ws) == -1 &&
 > 	     ioctl(STDIN_FILENO,  TIOCGWINSZ, (char *)&ws) == -1) ||
 
 So the correct way to avoid terminalness when outputting to a file
 is "ps </dev/null >foo 2>&1".  This is too strange for stdin, so
 apparently checking all 3 fd's is a feature, precisely to get the
 terminal width from somewhere even when stdout and stderr are
 redirected to a file.  "COLUMNS=0 ps" is an easier way.  If this
 feature is considered a bug, then remove the checks of STDERR_FILENO
 and STDIN_FILENO.
 
 Bruce
>Unformatted:
