From nobody@FreeBSD.org  Wed Jan 18 13:44:08 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E33A1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jan 2012 13:44:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D65C8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jan 2012 13:44:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0IDi7C3011656
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 18 Jan 2012 13:44:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0IDi7Ct011636;
	Wed, 18 Jan 2012 13:44:07 GMT
	(envelope-from nobody)
Message-Id: <201201181344.q0IDi7Ct011636@red.freebsd.org>
Date: Wed, 18 Jan 2012 13:44:07 GMT
From: Tomek CEDRO <cederom@tlen.pl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: FreeBSD 9.0-RELEASE ADM64 DVD1.ISO bsdinstall bug
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164278
>Category:       bin
>Synopsis:       bsdinstall(8): FreeBSD 9.0-RELEASE ADM64 DVD1.ISO bsdinstall bug
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-sysinstall
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 18 13:50:06 UTC 2012
>Closed-Date:    Wed Jan 18 16:02:36 UTC 2012
>Last-Modified:  Sun Feb  5 16:10:06 UTC 2012
>Originator:     Tomek CEDRO
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD hexagon.. 8.2-RELEASE-p3 FreeBSD 8.2-RELEASE-p3 #0: Tue Sep 27 18:45:57 UTC 2011     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64

>Description:
There are bugs during the "stable" release installation on amm64 machine
using bsdinstall from dvd1.iso making it impossible to install the system -
"Error while extracting base.txz: Can't set user=0/group=0 for var/empty
Can't update time for var/empty".

Please add "sysinstall" next to the "shell" and "live cd" selection dialog
at installation startup :-) Replacing sysinstall with bsdinstall is a
linux-style mistake... if you want to create an alternative, make it an
option :-)
>How-To-Repeat:
1. bsdinstall starts
2. partitioning goes well
3. packages selection and exctraction goes well
4. error message shows up "Error while extracting base.txz: Can't set
   user=0/group=0 for var/emptyCan'r update time for var/empty"

 Then bsdinstall asks if I want to restart or exit the installation.

>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-sysinstall 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jan 18 14:50:25 UTC 2012 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164278 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164278: commit references a PR
Date: Wed, 18 Jan 2012 15:59:36 +0000 (UTC)

 Author: nwhitehorn
 Date: Wed Jan 18 15:59:23 2012
 New Revision: 230309
 URL: http://svn.freebsd.org/changeset/base/230309
 
 Log:
   Warn if trying to install over an existing partition, which usually fails
   anyway due to libarchive not being able to overwrite schg flags.
   
   PR:		bin/164278
   MFC after:	4 days
 
 Modified:
   head/usr.sbin/bsdinstall/partedit/partedit.c
 
 Modified: head/usr.sbin/bsdinstall/partedit/partedit.c
 ==============================================================================
 --- head/usr.sbin/bsdinstall/partedit/partedit.c	Wed Jan 18 15:25:34 2012	(r230308)
 +++ head/usr.sbin/bsdinstall/partedit/partedit.c	Wed Jan 18 15:59:23 2012	(r230309)
 @@ -240,23 +240,41 @@ delete_part_metadata(const char *name)
  static int
  validate_setup(void)
  {
 -	struct partition_metadata *md;
 -	int root_found = FALSE;
 +	struct partition_metadata *md, *root = NULL;
 +	int cancel;
  
  	TAILQ_FOREACH(md, &part_metadata, metadata) {
  		if (md->fstab != NULL && strcmp(md->fstab->fs_file, "/") == 0)
 -			root_found = TRUE;
 +			root = md;
  
  		/* XXX: Check for duplicate mountpoints */
  	}
  
 -	if (!root_found) {
 +	if (root == NULL) {
  		dialog_msgbox("Error", "No root partition was found. "
  		    "The root FreeBSD partition must have a mountpoint of '/'.",
  		0, 0, TRUE);
  		return (FALSE);
  	}
  
 +	/*
 +	 * Check for root partitions that we aren't formatting, which is 
 +	 * usually a mistake
 +	 */
 +	if (root->newfs == NULL) {
 +		dialog_vars.defaultno = TRUE;
 +		cancel = dialog_yesno("Warning", "The chosen root partition "
 +		    "has a preexisting filesystem. If it contains an existing "
 +		    "FreeBSD system, please update it with freebsd-update "
 +		    "instead of installing a new system on it. The partition "
 +		    "can also be erased by pressing \"No\" and then deleting "
 +		    "and recreating it. Are you sure you want to proceed?",
 +		    0, 0);
 +		dialog_vars.defaultno = FALSE;
 +		if (cancel)
 +			return (FALSE);
 +	}
 +
  	return (TRUE);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: nwhitehorn 
State-Changed-When: Wed Jan 18 16:01:14 UTC 2012 
State-Changed-Why:  
This can happen if you try to install over an existing filesystem without 
reformatting the partitions due to UFS schg flags. r230309 adds a warning 
about this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164278 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164278: commit references a PR
Date: Sun,  5 Feb 2012 16:08:55 +0000 (UTC)

 Author: nwhitehorn
 Date: Sun Feb  5 16:08:45 2012
 New Revision: 231020
 URL: http://svn.freebsd.org/changeset/base/231020
 
 Log:
   MFC r230309:
   
   Warn if trying to install over an existing partition, which usually fails
   anyway due to libarchive not being able to overwrite schg flags.
   
   PR:		bin/164278
 
 Modified:
   stable/9/usr.sbin/bsdinstall/partedit/partedit.c
 Directory Properties:
   stable/9/usr.sbin/bsdinstall/   (props changed)
   stable/9/usr.sbin/bsdinstall/scripts/   (props changed)
 
 Modified: stable/9/usr.sbin/bsdinstall/partedit/partedit.c
 ==============================================================================
 --- stable/9/usr.sbin/bsdinstall/partedit/partedit.c	Sun Feb  5 15:59:18 2012	(r231019)
 +++ stable/9/usr.sbin/bsdinstall/partedit/partedit.c	Sun Feb  5 16:08:45 2012	(r231020)
 @@ -240,23 +240,41 @@ delete_part_metadata(const char *name)
  static int
  validate_setup(void)
  {
 -	struct partition_metadata *md;
 -	int root_found = FALSE;
 +	struct partition_metadata *md, *root = NULL;
 +	int cancel;
  
  	TAILQ_FOREACH(md, &part_metadata, metadata) {
  		if (md->fstab != NULL && strcmp(md->fstab->fs_file, "/") == 0)
 -			root_found = TRUE;
 +			root = md;
  
  		/* XXX: Check for duplicate mountpoints */
  	}
  
 -	if (!root_found) {
 +	if (root == NULL) {
  		dialog_msgbox("Error", "No root partition was found. "
  		    "The root FreeBSD partition must have a mountpoint of '/'.",
  		0, 0, TRUE);
  		return (FALSE);
  	}
  
 +	/*
 +	 * Check for root partitions that we aren't formatting, which is 
 +	 * usually a mistake
 +	 */
 +	if (root->newfs == NULL) {
 +		dialog_vars.defaultno = TRUE;
 +		cancel = dialog_yesno("Warning", "The chosen root partition "
 +		    "has a preexisting filesystem. If it contains an existing "
 +		    "FreeBSD system, please update it with freebsd-update "
 +		    "instead of installing a new system on it. The partition "
 +		    "can also be erased by pressing \"No\" and then deleting "
 +		    "and recreating it. Are you sure you want to proceed?",
 +		    0, 0);
 +		dialog_vars.defaultno = FALSE;
 +		if (cancel)
 +			return (FALSE);
 +	}
 +
  	return (TRUE);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
