From nobody@FreeBSD.org  Mon Jan 16 04:12:36 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 19915106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 04:12:36 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 03FA58FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 04:12:36 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0G4CZ8W096190
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Jan 2012 04:12:35 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0G4CZx6096189;
	Mon, 16 Jan 2012 04:12:35 GMT
	(envelope-from nobody)
Message-Id: <201201160412.q0G4CZx6096189@red.freebsd.org>
Date: Mon, 16 Jan 2012 04:12:35 GMT
From: Devin Teske <dteske@vicor.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] Fix typo intr-by SVN r214735 in usr.sbin/wpa/wpa_supplicant/Makefile
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164192
>Category:       bin
>Synopsis:       [patch] wpa_supplicant(8): Fix typo intr-by SVN r214735 in usr.sbin/wpa/wpa_supplicant/Makefile
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    emaste
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 16 04:20:06 UTC 2012
>Closed-Date:    Mon Feb 20 20:24:03 UTC 2012
>Last-Modified:  Mon Feb 20 20:24:03 UTC 2012
>Originator:     Devin Teske
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2010
root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Trying to build RELENG_9 and finding a typo in the Makefile for usr.sbin/wpa/wpa_supplicant.
>How-To-Repeat:

>Fix:
See attached patch.txt

Patch attached with submission follows:

--- usr.sbin/wpa/wpa_supplicant/Makefile.orig	2011-09-22 17:51:37.000000000 -0700
+++ usr.sbin/wpa/wpa_supplicant/Makefile	2012-01-15 20:10:57.000000000 -0800
@@ -5,7 +5,7 @@
 .PATH.c:${WPA_SUPPLICANT_DISTDIR} \
 	${WPA_DISTDIR}/src/drivers \
 	${WPA_DISTDIR}/src/eap_peer \
-	${WPA_DISTDIR}/src/rsn_supp
+	${WPA_DISTDIR}/src/rsn_supp \
 	${WPA_DISTDIR}/src/crypto
 
 PROG=	wpa_supplicant


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: emaste 
State-Changed-When: Wed Jan 18 02:44:48 UTC 2012 
State-Changed-Why:  
Committed as r230293 


Responsible-Changed-From-To: freebsd-bugs->emaste 
Responsible-Changed-By: emaste 
Responsible-Changed-When: Wed Jan 18 02:44:48 UTC 2012 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164192 

From: Devin Teske <devin.teske@fisglobal.com>
To: <bug-followup@FreeBSD.org>, <dteske@vicor.com>
Cc:  
Subject: Re: bin/164192: [patch] wpa_supplicant(8): Fix typo intr-by SVN r214735 in usr.sbin/wpa/wpa_supplicant/Makefile
Date: Tue, 17 Jan 2012 18:44:17 -0800

 NOTE:
 
 The reason this typo went unnoticed for 14 months and 2 weeks is because...
 
 1. Despite the fact that src/usr.sbin/wpa/wpa_supplicant/Makefile failed to
 properly include ${WPA_DISTDIR}/src/crypto due to a typo
 
 2. The higher-level Makefile.inc one-directory-up already declared
 ${WPA_DISTDIR}/src/crypto as an include-directory for *.c files.
 
 Thus, the typo did not result in expected outcome (failure to link
 wpa_supplicant due to missing sources; causing undefined references).
 
 The patch in this PR stands and should still be made to shore-up the Makefile
 logic by correcting the still-outstanding typo.
 -- 
 Devin
 
 _____________
 The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164192: commit references a PR
Date: Wed, 18 Jan 2012 02:44:37 +0000 (UTC)

 Author: emaste
 Date: Wed Jan 18 02:44:22 2012
 New Revision: 230293
 URL: http://svn.freebsd.org/changeset/base/230293
 
 Log:
   Add missing line continuation \.  It did not cause any issue because
   the same path is already being included in ../Makefile.inc.
   
   PR:		164192
   Submitted by:	Devin Teske <dteske vicor com>
   MFC after:	2 weeks
 
 Modified:
   head/usr.sbin/wpa/wpa_supplicant/Makefile
 
 Modified: head/usr.sbin/wpa/wpa_supplicant/Makefile
 ==============================================================================
 --- head/usr.sbin/wpa/wpa_supplicant/Makefile	Wed Jan 18 02:29:11 2012	(r230292)
 +++ head/usr.sbin/wpa/wpa_supplicant/Makefile	Wed Jan 18 02:44:22 2012	(r230293)
 @@ -5,7 +5,7 @@
  .PATH.c:${WPA_SUPPLICANT_DISTDIR} \
  	${WPA_DISTDIR}/src/drivers \
  	${WPA_DISTDIR}/src/eap_peer \
 -	${WPA_DISTDIR}/src/rsn_supp
 +	${WPA_DISTDIR}/src/rsn_supp \
  	${WPA_DISTDIR}/src/crypto
  
  PROG=	wpa_supplicant
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164192: commit references a PR
Date: Wed,  1 Feb 2012 01:28:56 +0000 (UTC)

 Author: emaste
 Date: Wed Feb  1 01:28:35 2012
 New Revision: 230854
 URL: http://svn.freebsd.org/changeset/base/230854
 
 Log:
   MFC r230293:
   
     Add missing line continuation \.  It did not cause any issue because
     the same path is already being included in ../Makefile.inc.
   
     PR:           164192
     Submitted by: Devin Teske <dteske vicor com>
 
 Modified:
   stable/8/usr.sbin/wpa/wpa_supplicant/Makefile
 Directory Properties:
   stable/8/usr.sbin/wpa/wpa_supplicant/   (props changed)
 
 Modified: stable/8/usr.sbin/wpa/wpa_supplicant/Makefile
 ==============================================================================
 --- stable/8/usr.sbin/wpa/wpa_supplicant/Makefile	Tue Jan 31 23:24:46 2012	(r230853)
 +++ stable/8/usr.sbin/wpa/wpa_supplicant/Makefile	Wed Feb  1 01:28:35 2012	(r230854)
 @@ -5,7 +5,7 @@
  .PATH.c:${WPA_SUPPLICANT_DISTDIR} \
  	${WPA_DISTDIR}/src/drivers \
  	${WPA_DISTDIR}/src/eap_peer \
 -	${WPA_DISTDIR}/src/rsn_supp
 +	${WPA_DISTDIR}/src/rsn_supp \
  
  PROG=	wpa_supplicant
  SRCS=	aes.c aes_wrap.c blacklist.c common.c config.c ctrl_iface.c \
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164192: commit references a PR
Date: Wed,  1 Feb 2012 03:28:35 +0000 (UTC)

 Author: emaste
 Date: Wed Feb  1 03:28:19 2012
 New Revision: 230858
 URL: http://svn.freebsd.org/changeset/base/230858
 
 Log:
   MFC r230293:
   
     Add missing line continuation \.  It did not cause any issue because
     the same path is already being included in ../Makefile.inc.
   
     PR:           164192
     Submitted by: Devin Teske <dteske vicor com>
 
 Modified:
   stable/9/usr.sbin/wpa/wpa_supplicant/Makefile
 Directory Properties:
   stable/9/usr.sbin/wpa/wpa_supplicant/   (props changed)
 
 Modified: stable/9/usr.sbin/wpa/wpa_supplicant/Makefile
 ==============================================================================
 --- stable/9/usr.sbin/wpa/wpa_supplicant/Makefile	Wed Feb  1 02:53:06 2012	(r230857)
 +++ stable/9/usr.sbin/wpa/wpa_supplicant/Makefile	Wed Feb  1 03:28:19 2012	(r230858)
 @@ -5,7 +5,7 @@
  .PATH.c:${WPA_SUPPLICANT_DISTDIR} \
  	${WPA_DISTDIR}/src/drivers \
  	${WPA_DISTDIR}/src/eap_peer \
 -	${WPA_DISTDIR}/src/rsn_supp
 +	${WPA_DISTDIR}/src/rsn_supp \
  	${WPA_DISTDIR}/src/crypto
  
  PROG=	wpa_supplicant
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: emaste 
State-Changed-When: Mon Feb 20 20:23:39 UTC 2012 
State-Changed-Why:  
Merged to stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164192 
>Unformatted:
