From nobody@FreeBSD.org  Fri Jan 13 19:06:42 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5E5FD1065672
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Jan 2012 19:06:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 48DD68FC14
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Jan 2012 19:06:42 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0DJ6ful047518
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 13 Jan 2012 19:06:41 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0DJ6f7p047517;
	Fri, 13 Jan 2012 19:06:41 GMT
	(envelope-from nobody)
Message-Id: <201201131906.q0DJ6f7p047517@red.freebsd.org>
Date: Fri, 13 Jan 2012 19:06:41 GMT
From: Ariane van der Steldt <ariane@stack.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: installer progress over 100%
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164094
>Category:       bin
>Synopsis:       bsdinstall(8): installer progress over 100%
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-sysinstall
>State:          feedback
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 13 19:10:07 UTC 2012
>Closed-Date:    
>Last-Modified:  Fri Jan 20 15:20:13 UTC 2012
>Originator:     Ariane van der Steldt
>Release:        FreeBSD 9.0 Release
>Organization:
>Environment:
FreeBSD 9.0 Release
iso from wednesday Jan 11, 2012, FreeBSD-9.0-RELEASE-amd64-bootonly.iso,
SHA256 (FreeBSD-9.0-RELEASE-amd64-bootonly.iso) = d16fd5f32c9483177a01241f37ed84f347484c65e52aba4dbf8a2f3108fb457d
>Description:
Installer failed to get the first file in the list (base.tgz from memory) and continued to fetch the next file (kernel.tgz) due to my DNS resolver giving a negative reply, the first fetch.

Subsequently, my overall progress bar quickly overflowed, running over 3000%.
>How-To-Repeat:
Fail to download the first file, progress to the next file.
>Fix:
- clamp progress bar rendering to be between 0% and 100% (this will fix the overflown bar only)
- reset progress bar state on failed download (I suspect this only happens for succesful downloads)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-sysinstall 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sat Jan 14 01:15:02 UTC 2012 
Responsible-Changed-Why:  
assign and fix synopsis 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164094 
State-Changed-From-To: open->feedback 
State-Changed-By: eadler 
State-Changed-When: Sat Jan 14 02:00:55 UTC 2012 
State-Changed-Why:  
nwhitehorn asked for feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164094 

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
Date: Wed, 18 Jan 2012 09:00:42 -0600

 ----- Forwarded message from Ariane van der Steldt <ariane@stack.nl> -----
 
 Date: Wed, 18 Jan 2012 06:23:08 +0100
 From: Ariane van der Steldt <ariane@stack.nl>
 To: Nathan Whitehorn <nwhitehorn@freebsd.org>
 Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org,
 	freebsd-sysinstall@FreeBSD.org
 Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
 User-Agent: Mutt/1.5.21 (2010-09-15)
 
 Hi Nathan,
 
 On Sat, Jan 14, 2012 at 07:42:24AM +0100, Ariane van der Steldt wrote:
 > On Fri, Jan 13, 2012 at 07:49:12PM -0600, Nathan Whitehorn wrote:
 > > On 01/13/12 19:16, eadler@FreeBSD.org wrote:
 > > > FreeBSD installer changed my MBR-only partition table to MBR+GPT 
 > > > partition table.
 
 
 > > > The other OS does not have GPT logic; I want to be at least warned 
 > > > this is happening and prefer to have the option at least. 
 > > > Alternatively, the installer may opt not to install a GPT if the disk 
 > > > does not require it (as in the case in this machine)
 > > 
 > > Can you give some more details here? This is something that the 
 > > installer is not programmed to do and that I cannot reproduce.
 > 
 > Sure. I used a VM to reproduce the problem, so I could provide pretty
 > screenshots in an attempt to better explain the problem.
 > 
 > 
 > Pre-install:
 > only 1 OS installed, windows XP, using MBR partition table.
 > 
 > Using a live CD, I can instruct fdisk to (pointlessly) alter the active
 > partition, as can be seen in attached screenshot 1
 > 
 > 
 > Post-install:
 > Both windows XP and FreeBSD are installed.
 > Unfortunately, fdisk can no longer be used to alter the active
 > partition, gpart is to be used instead.
 > As can be seen in attached screenshot 2, fdisk fails.
 > 
 > After install, only gpart can be used to change the active partition.
 
 Upon rereading the manpage for gpart, I'm wondering if what I concluded
 really happened. On closer examination, it's possible the geom logic
 blocked fdisk from modifying the partition table. Can you tell me how I
 can confirm out what partitioning schemes are present on my harddisk?
 I put the output of gpart show at the bottom of the e-mail, which
 suggests the mbr scheme is used regardless.
 
 If geom indeed blocks fdisk from altering the partition table, I'm
 wondering what the use of the binary is though, as it seems gpart does
 everything fdisk does, but without failing.
 
 # gpart show
 =>        63  1250263665  ada0  MBR  (596G)
           63   209712447     1  ntfs  [active]  (100G)
    209712510   102398310     2  ntfs  (48G)
    312110820   937426896     3  freebsd  (447G)
   1249537716      726012        - free -  (354M)
 
 =>        0  937426896  ada0s3  BSD  (447G)
           0  929038336       1  freebsd-ufs  (443G)
   929038336    8388559       2  freebsd-swap  (4G)
   937426895          1          - free -  (512B)
 -- 
 Ariane
 _______________________________________________
 freebsd-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
 To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"
 
 
 ----- End forwarded message -----

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
Date: Wed, 18 Jan 2012 09:01:18 -0600

 ----- Forwarded message from Nathan Whitehorn <nwhitehorn@freebsd.org> -----
 
 Date: Tue, 17 Jan 2012 23:57:10 -0600
 From: Nathan Whitehorn <nwhitehorn@freebsd.org>
 To: Ariane van der Steldt <ariane@stack.nl>
 Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org,
 	freebsd-sysinstall@FreeBSD.org
 Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
 
 That implies it's just MBR + BSD label. Why did you think it was GPT?
 Geom does prevent many utilities from altering the partition table. I
 was under the impression that fdisk had been modified to actually use
 geom these days, so it should have worked, but it's possible that
 didn't work somehow.
 -Nathan
 
 ----- End forwarded message -----

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
Date: Fri, 20 Jan 2012 09:18:01 -0600

 ----- Forwarded message from Ariane van der Steldt <ariane@stack.nl> -----
 
 Date: Fri, 20 Jan 2012 10:46:43 +0100
 From: Ariane van der Steldt <ariane@stack.nl>
 To: Nathan Whitehorn <nwhitehorn@freebsd.org>
 Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org,
 	freebsd-sysinstall@FreeBSD.org
 Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
 
 I came under that impression because fdisk didn't work, while before
 installing freebsd, it did work. gpart, due to its name and coupled with
 a refusing fdisk, made me jump to the conclusion that I had been given a
 GPT table.
 
 Is there a technical reason that geom is not automatically activated on
 every partition table? It seems to me that unifying these would reduce
 complexity and confusion to the end user. And I see no reason why the
 boot volume has this recognized and activated automatically, but other
 devices don't.
 -- 
 Ariane
 
 ----- End forwarded message -----

From: Mark Linimon <linimon@lonesome.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
Date: Fri, 20 Jan 2012 09:18:31 -0600

 ----- Forwarded message from Bruce Cran <bruce@cran.org.uk> -----
 
 Date: Fri, 20 Jan 2012 10:33:49 +0000
 From: Bruce Cran <bruce@cran.org.uk>
 To: Ariane van der Steldt <ariane@stack.nl>
 Cc: freebsd-bugs@FreeBSD.org, eadler@FreeBSD.org,
 	Nathan Whitehorn <nwhitehorn@freebsd.org>,
 	freebsd-sysinstall@FreeBSD.org
 Subject: Re: bin/164094: bsdinstall(8): installer progress over 100%
 
 gpart is just a geom partitioner: its name has nothing to do with GPT.
 
 -- 
 Bruce Cran
 
 ----- End forwarded message -----
>Unformatted:
