From nobody@FreeBSD.org  Thu Jan 12 04:56:47 2012
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E2A65106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Jan 2012 04:56:47 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D099F8FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Jan 2012 04:56:47 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0C4ulRr067223
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 12 Jan 2012 04:56:47 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q0C4ulMq067222;
	Thu, 12 Jan 2012 04:56:47 GMT
	(envelope-from nobody)
Message-Id: <201201120456.q0C4ulMq067222@red.freebsd.org>
Date: Thu, 12 Jan 2012 04:56:47 GMT
From: Devin Teske <dteske@vicor.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [PATCH] tzsetup(8): Don't write /var/db/zoneinfo either when "-n" is passed or when install_zoneinfo_file returns failure
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         164039
>Category:       bin
>Synopsis:       [PATCH] tzsetup(8): Don't write /var/db/zoneinfo either when "-n" is passed or when install_zoneinfo_file returns failure
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dteske
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 12 05:00:26 UTC 2012
>Closed-Date:    Mon Mar 04 11:21:51 UTC 2013
>Last-Modified:  Mon Mar 04 11:21:51 UTC 2013
>Originator:     Devin Teske
>Release:        FreeBSD 9.0-RELEASE amd64
>Organization:
FIS Global, Inc.
>Environment:
FreeBSD scribe.vicor.com 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2010
root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
The "-n" flag is described in tzsetup(8) as "Do not create or copy files," so it seems like a bug that /var/db/zoneinfo is created without regard to this flag's presence.

Additionally, since SVN r198350 -- where install_zone_file() was split into install_zoneinfo_file()/install_zoneinfo() -- the /var/db/zoneinfo file is written without regard to whether the zoneinfo file was successfully installed or not.

The attached patch.txt makes it so that /var/db/zoneinfo is only written if (a) a zoneinfo file was successfully installed (install_zoneinfo_file returns success) and (b) the "-n" flag is not present.
>How-To-Repeat:
Exec as root: tzsetup some/foo
Notice that /var/db/zoneinfo contains "some/foo" despite given failure to install any zonefile by that name.

Similarly, exec as root: tzsetup -n America/Los_Angeles
Notice that /var/db/zoneinfo contains "America/Los_Angeles"
>Fix:
See attached patch.txt

Patch attached with submission follows:

--- usr.sbin/tzsetup/tzsetup.c.orig	Fri Dec  2 11:19:10 2011
+++ usr.sbin/tzsetup/tzsetup.c	Wed Jan 11 20:12:54 2012
@@ -801,9 +801,11 @@ install_zoneinfo(const char *zoneinfo)
 	rv = install_zoneinfo_file(path_zoneinfo_file);
 
 	/* Save knowledge for later */
-	if ((f = fopen(path_db, "w")) != NULL) {
-		fprintf(f, "%s\n", zoneinfo);
-		fclose(f);
+	if (reallydoit && (rv & DITEM_FAILURE) == 0) {
+		if (f = fopen(path_db, "w")) != NULL) {
+			fprintf(f, "%s\n", zoneinfo);
+			fclose(f);
+		}
 	}
 
 	return (rv);


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: emaste 
State-Changed-When: Wed Jan 18 04:12:44 UTC 2012 
State-Changed-Why:  
Committed as r230296 


Responsible-Changed-From-To: freebsd-bugs->emaste 
Responsible-Changed-By: emaste 
Responsible-Changed-When: Wed Jan 18 04:12:44 UTC 2012 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164039 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164039: commit references a PR
Date: Wed, 18 Jan 2012 04:12:46 +0000 (UTC)

 Author: emaste
 Date: Wed Jan 18 04:12:32 2012
 New Revision: 230296
 URL: http://svn.freebsd.org/changeset/base/230296
 
 Log:
   Don't write /var/db/zoneinfo when zone is not actually changed.
   
   If the specified zone file does not exist or the -n flag is specified,
   do not update /var/db/zoneinfo.
   
   PR:		bin/164039
   Submitted by:	Devin Teske <dteske vicor com>
   MFC after:	1 week
 
 Modified:
   head/usr.sbin/tzsetup/tzsetup.c
 
 Modified: head/usr.sbin/tzsetup/tzsetup.c
 ==============================================================================
 --- head/usr.sbin/tzsetup/tzsetup.c	Wed Jan 18 03:07:34 2012	(r230295)
 +++ head/usr.sbin/tzsetup/tzsetup.c	Wed Jan 18 04:12:32 2012	(r230296)
 @@ -829,9 +829,11 @@ install_zoneinfo(const char *zoneinfo)
  	rv = install_zoneinfo_file(path_zoneinfo_file);
  
  	/* Save knowledge for later */
 -	if ((f = fopen(path_db, "w")) != NULL) {
 -		fprintf(f, "%s\n", zoneinfo);
 -		fclose(f);
 +	if (reallydoit && (rv & DITEM_FAILURE) == 0) {
 +		if ((f = fopen(path_db, "w")) != NULL) {
 +			fprintf(f, "%s\n", zoneinfo);
 +			fclose(f);
 +		}
  	}
  
  	return (rv);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Michael Scheidell <scheidell@freebsd.org>
To: <bug-followup@FreeBSD.org>, <dteske@vicor.com>
Cc:  
Subject: Re: bin/164039: [PATCH] tzsetup(8): Don&#39;t write /var/db/zoneinfo
 either when &quot;-n&quot; is passed or when install_zoneinfo_file returns
 failure
Date: Sun, 22 Jan 2012 21:52:17 -0500

 --------------030008070606050600080505
 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
 Content-Transfer-Encoding: 7bit
 
 have you seen this bug also?  want to combine them?
 
 http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993
 
 
 -- 
 Michael Scheidell, CTO
 o: 561-999-5000
 d: 561-948-2259
  >*| *SECNAP Network Security Corporation
 
     * Best Mobile Solutions Product of 2011
     * Best Intrusion Prevention Product
     * Hot Company Finalist 2011
     * Best Email Security Product
     * Certified SNORT Integrator
 
 
 --------------030008070606050600080505
 Content-Type: text/html; charset="ISO-8859-1"
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
   <head>
 
     <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
   </head>
   <body bgcolor="#ffffff" text="#000000">
     have you seen this bug also?&nbsp; want to combine them?<br>
     <br>
     <a class="moz-txt-link-freetext" href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993</a>&nbsp; <br>
     <br>
     <br>
     <div class="moz-signature">-- <br>
       Michael Scheidell, CTO<br>
       o: 561-999-5000<br>
       d: 561-948-2259<br>
       <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
       Network Security Corporation
       <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
       <ul class="unnamed1">
         <li>Best Mobile Solutions Product of 2011</li>
         <li>Best Intrusion Prevention Product</li>
         <li>Hot Company Finalist 2011</li>
         <li>Best Email Security Product</li>
         <li>Certified SNORT Integrator</li>
       </ul>
     </div>
   </body>
 </html>
 
 --------------030008070606050600080505--

From: Devin Teske <devin.teske@fisglobal.com>
To: Michael Scheidell <scheidell@freebsd.org>
Cc: <bug-followup@FreeBSD.org>, <dteske@vicor.com>
Subject: Re: bin/164039: [PATCH] tzsetup(8): Don&#39;t write /var/db/zoneinfo either when &quot;-n&quot; is passed or when install_zoneinfo_file returns failure
Date: Sun, 22 Jan 2012 21:06:13 -0800

 --Apple-Mail-4--1051861420
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset="us-ascii"
 
 Hmmm, I'm afraid I don't understand.
 
 Can you clarify?
 -- 
 Devin
 
 On Jan 22, 2012, at 6:52 PM, Michael Scheidell wrote:
 
 > have you seen this bug also?  want to combine them?
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993  
 > 
 > 
 > -- 
 > Michael Scheidell, CTO
 > o: 561-999-5000
 > d: 561-948-2259
 > > | SECNAP Network Security Corporation
 > Best Mobile Solutions Product of 2011
 > Best Intrusion Prevention Product
 > Hot Company Finalist 2011
 > Best Email Security Product
 > Certified SNORT Integrator
 
 -- 
 Cheers,
 Devin Teske
 
 -> CONTACT INFORMATION <-
 Business Solutions Consultant II
 FIS - fisglobal.com
 510-735-5650 Mobile
 510-621-2038 Office
 510-621-2020 Office Fax
 909-477-4578 Home/Fax
 devin.teske@fisglobal.com
 
 -> LEGAL DISCLAIMER <-
 This message  contains confidential  and proprietary  information
 of the sender,  and is intended only for the person(s) to whom it
 is addressed. Any use, distribution, copying or disclosure by any
 other person  is strictly prohibited.  If you have  received this
 message in error,  please notify  the e-mail sender  immediately,
 and delete the original message without making a copy.
 
 -> END TRANSMISSION <-
 
 _____________
 The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
 
 --Apple-Mail-4--1051861420
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html; charset="us-ascii"
 
 <html><head></head><body style=3D"word-wrap: break-word; -webkit-nbsp-mode:=
  space; -webkit-line-break: after-white-space; "><div>Hmmm, I'm afraid I do=
 n't understand.</div><div><br></div><div>Can you clarify?</div><div>--&nbsp=
 ;</div><div>Devin</div><br><div><div>On Jan 22, 2012, at 6:52 PM, Michael S=
 cheidell wrote:</div><br class=3D"Apple-interchange-newline"><blockquote ty=
 pe=3D"cite"><div bgcolor=3D"#ffffff" text=3D"#000000">
     have you seen this bug also?&nbsp; want to combine them?<br>
     <br>
     <a class=3D"moz-txt-link-freetext" href=3D"http://www.freebsd.org/cgi/q=
 uery-pr.cgi?pr=3Dports/162993">http://www.freebsd.org/cgi/query-pr.cgi?pr=
 =3Dports/162993</a>&nbsp; <br>
     <br>
     <br>
     <div class=3D"moz-signature">-- <br>
       Michael Scheidell, CTO<br>
       o: 561-999-5000<br>
       d: 561-948-2259<br>
       <font color=3D"#999999">&gt;</font><font color=3D"#cc0000"> <b>| </b>=
 </font>SECNAP
       Network Security Corporation
       <style type=3D"text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
       <ul class=3D"unnamed1">
         <li>Best Mobile Solutions Product of 2011</li>
         <li>Best Intrusion Prevention Product</li>
         <li>Hot Company Finalist 2011</li>
         <li>Best Email Security Product</li>
         <li>Certified SNORT Integrator</li>
       </ul>
     </div>
   </div>
 
 </blockquote></div><br><div>
 <span class=3D"Apple-style-span" style=3D"border-collapse: separate; color:=
  rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: no=
 rmal; font-weight: normal; letter-spacing: normal; line-height: normal; orp=
 hans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-sp=
 ace: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacin=
 g: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-e=
 ffect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px=
 ; font-size: medium; "><span class=3D"Apple-style-span" style=3D"border-col=
 lapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: n=
 ormal; font-variant: normal; font-weight: normal; letter-spacing: normal; l=
 ine-height: normal; orphans: 2; text-indent: 0px; text-transform: none; whi=
 te-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-s=
 pacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations=
 -in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width=
 : 0px; font-size: medium; "><div style=3D"word-wrap: break-word; -webkit-nb=
 sp-mode: space; -webkit-line-break: after-white-space; "><span class=3D"App=
 le-style-span" style=3D"border-collapse: separate; color: rgb(0, 0, 0); fon=
 t-family: Helvetica; font-style: normal; font-variant: normal; font-weight:=
  normal; letter-spacing: normal; line-height: normal; orphans: 2; text-inde=
 nt: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing=
 : 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spac=
 ing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjus=
 t: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style=3D=
 "word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after=
 -white-space; "><span class=3D"Apple-style-span" style=3D"border-collapse: =
 separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; =
 font-variant: normal; font-weight: normal; letter-spacing: normal; line-hei=
 ght: normal; orphans: 2; text-indent: 0px; text-transform: none; white-spac=
 e: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing:=
  0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-eff=
 ect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; =
 font-size: medium; "><div style=3D"word-wrap: break-word; -webkit-nbsp-mode=
 : space; -webkit-line-break: after-white-space; "><span class=3D"Apple-styl=
 e-span" style=3D"border-collapse: separate; color: rgb(0, 0, 0); font-famil=
 y: Helvetica; font-size: medium; font-style: normal; font-variant: normal; =
 font-weight: normal; letter-spacing: normal; line-height: normal; orphans: =
 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; =
 word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-v=
 ertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-tex=
 t-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style=3D"word-w=
 rap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-=
 space; "><span class=3D"Apple-style-span" style=3D"border-collapse: separat=
 e; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-sty=
 le: normal; font-variant: normal; font-weight: normal; letter-spacing: norm=
 al; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none=
 ; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizon=
 tal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decora=
 tions-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-=
 width: 0px; "><div style=3D"word-wrap: break-word; -webkit-nbsp-mode: space=
 ; -webkit-line-break: after-white-space; ">--&nbsp;<br>Cheers,<br>Devin Tes=
 ke<br><br>-&gt; CONTACT INFORMATION &lt;-<br>Business Solutions Consultant =
 II<br>FIS -&nbsp;<a href=3D"http://fisglobal.com/">fisglobal.com</a></div><=
 div style=3D"word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-=
 break: after-white-space; ">510-735-5650 Mobile<br>510-621-2038 Office<br>5=
 10-621-2020 Office Fax<br>909-477-4578 Home/Fax<br><a href=3D"mailto:devin.=
 teske@fisglobal.com">devin.teske@fisglobal.com</a><br><br>-&gt; LEGAL DISCL=
 AIMER &lt;-<br>This message &nbsp;contains confidential &nbsp;and&nbsp;prop=
 rietary &nbsp;information<br>of the sender, &nbsp;and is intended only for =
 the&nbsp;person(s) to whom it<br>is addressed. Any use, distribution, copyi=
 ng&nbsp;or disclosure by any<br>other person &nbsp;is strictly prohibited. =
 &nbsp;If you&nbsp;have &nbsp;received this<br>message in error, &nbsp;pleas=
 e notify &nbsp;the e-mail&nbsp;sender &nbsp;immediately,<br>and delete the =
 original message without&nbsp;making a copy.<br><br>-&gt; END TRANSMISSION =
 &lt;-</div></span></div></span></div></span></div></span></div></span></spa=
 n>
 </div>
 <br>
 <DIV>
 _____________<BR>
 The information contained in this message is proprietary and/or confidentia=
 l. If you are not the intended recipient, please: (i) delete the message an=
 d all copies; (ii) do not disclose, distribute or use the message in any ma=
 nner; and (iii) notify the sender immediately. In addition, please be aware=
  that any message addressed to our domain is subject to archiving and revie=
 w by persons other than the intended recipient. Thank you.<BR>
 </DIV></body></html>
 
 --Apple-Mail-4--1051861420--

From: Michael Scheidell <scheidell@freebsd.org>
To: Devin Teske <devin.teske@fisglobal.com>
Cc: <bug-followup@FreeBSD.org>, <dteske@vicor.com>
Subject: Re: bin/164039: [PATCH] tzsetup(8): Don&#39;t write /var/db/zoneinfo
 either when &quot;-n&quot; is passed or when install_zoneinfo_file returns
 failure
Date: Mon, 23 Jan 2012 05:13:38 -0500

 --------------070609050108030703030708
 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
 Content-Transfer-Encoding: 7bit
 
 
 
 On 1/23/12 12:06 AM, Devin Teske wrote:
 > Hmmm, I'm afraid I don't understand.
 >
 > Can you clarify?
 > -- 
 > Devin
 
 mostly meant for the maintainer.  There are two bugs open for zoneinfo.  
 they both need to be committed.
 
 >
 > On Jan 22, 2012, at 6:52 PM, Michael Scheidell wrote:
 >
 >> have you seen this bug also?  want to combine them?
 >>
 >> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993
 >>
 >>
 >> -- 
 >> Michael Scheidell, CTO
 >> o: 561-999-5000
 >> d: 561-948-2259
 >> >*| *SECNAP Network Security Corporation
 >>
 >>     * Best Mobile Solutions Product of 2011
 >>     * Best Intrusion Prevention Product
 >>     * Hot Company Finalist 2011
 >>     * Best Email Security Product
 >>     * Certified SNORT Integrator
 >>
 >
 > -- 
 > Cheers,
 > Devin Teske
 >
 > -> CONTACT INFORMATION <-
 > Business Solutions Consultant II
 > FIS - fisglobal.com <http://fisglobal.com/>
 > 510-735-5650 Mobile
 > 510-621-2038 Office
 > 510-621-2020 Office Fax
 > 909-477-4578 Home/Fax
 > devin.teske@fisglobal.com <mailto:devin.teske@fisglobal.com>
 >
 > -> LEGAL DISCLAIMER <-
 > This message  contains confidential  and proprietary  information
 > of the sender,  and is intended only for the person(s) to whom it
 > is addressed. Any use, distribution, copying or disclosure by any
 > other person  is strictly prohibited.  If you have  received this
 > message in error,  please notify  the e-mail sender  immediately,
 > and delete the original message without making a copy.
 >
 > -> END TRANSMISSION <-
 >
 > _____________
 > The information contained in this message is proprietary and/or 
 > confidential. If you are not the intended recipient, please: (i) 
 > delete the message and all copies; (ii) do not disclose, distribute or 
 > use the message in any manner; and (iii) notify the sender 
 > immediately. In addition, please be aware that any message addressed 
 > to our domain is subject to archiving and review by persons other than 
 > the intended recipient. Thank you.
 
 -- 
 Michael Scheidell, CTO
 o: 561-999-5000
 d: 561-948-2259
  >*| *SECNAP Network Security Corporation
 
     * Best Mobile Solutions Product of 2011
     * Best Intrusion Prevention Product
     * Hot Company Finalist 2011
     * Best Email Security Product
     * Certified SNORT Integrator
 
 
 --------------070609050108030703030708
 Content-Type: text/html; charset="ISO-8859-1"
 Content-Transfer-Encoding: 7bit
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
   <head>
     <meta content="text/html; charset=ISO-8859-1"
       http-equiv="Content-Type">
   </head>
   <body bgcolor="#ffffff" text="#000000">
     <br>
     <br>
     On 1/23/12 12:06 AM, Devin Teske wrote:
     <blockquote
       cite="mid:9D2906B6-CDD4-4068-AC82-57571598D20D@fisglobal.com"
       type="cite">
       <meta http-equiv="Content-Type" content="text/html;
         charset=ISO-8859-1">
       <div>Hmmm, I'm afraid I don't understand.</div>
       <div><br>
       </div>
       <div>Can you clarify?</div>
       <div>--&nbsp;</div>
       <div>Devin</div>
     </blockquote>
     <br>
     mostly meant for the maintainer.&nbsp; There are two bugs open for
     zoneinfo.&nbsp; they both need to be committed.<br>
     <br>
     <blockquote
       cite="mid:9D2906B6-CDD4-4068-AC82-57571598D20D@fisglobal.com"
       type="cite"><br>
       <div>
         <div>On Jan 22, 2012, at 6:52 PM, Michael Scheidell wrote:</div>
         <br class="Apple-interchange-newline">
         <blockquote type="cite">
           <div bgcolor="#ffffff" text="#000000"> have you seen this bug
             also?&nbsp; want to combine them?<br>
             <br>
             <a moz-do-not-send="true" class="moz-txt-link-freetext"
               href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993</a>&nbsp;
             <br>
             <br>
             <br>
             <div class="moz-signature">-- <br>
               Michael Scheidell, CTO<br>
               o: 561-999-5000<br>
               d: 561-948-2259<br>
               <font color="#999999">&gt;</font><font color="#cc0000"> <b>|
                 </b></font>SECNAP Network Security Corporation
               <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
               <ul class="unnamed1">
                 <li>Best Mobile Solutions Product of 2011</li>
                 <li>Best Intrusion Prevention Product</li>
                 <li>Hot Company Finalist 2011</li>
                 <li>Best Email Security Product</li>
                 <li>Certified SNORT Integrator</li>
               </ul>
             </div>
           </div>
         </blockquote>
       </div>
       <br>
       <div>
         <span class="Apple-style-span" style="border-collapse: separate;
           color: rgb(0, 0, 0); font-family: Helvetica; font-style:
           normal; font-variant: normal; font-weight: normal;
           letter-spacing: normal; line-height: normal; orphans: 2;
           text-indent: 0px; text-transform: none; white-space: normal;
           widows: 2; word-spacing: 0px; font-size: medium;"><span
             class="Apple-style-span" style="border-collapse: separate;
             color: rgb(0, 0, 0); font-family: Helvetica; font-style:
             normal; font-variant: normal; font-weight: normal;
             letter-spacing: normal; line-height: normal; orphans: 2;
             text-indent: 0px; text-transform: none; white-space: normal;
             widows: 2; word-spacing: 0px; font-size: medium;">
             <div style="word-wrap: break-word;"><span
                 class="Apple-style-span" style="border-collapse:
                 separate; color: rgb(0, 0, 0); font-family: Helvetica;
                 font-style: normal; font-variant: normal; font-weight:
                 normal; letter-spacing: normal; line-height: normal;
                 orphans: 2; text-indent: 0px; text-transform: none;
                 white-space: normal; widows: 2; word-spacing: 0px;
                 font-size: medium;">
                 <div style="word-wrap: break-word;"><span
                     class="Apple-style-span" style="border-collapse:
                     separate; color: rgb(0, 0, 0); font-family:
                     Helvetica; font-style: normal; font-variant: normal;
                     font-weight: normal; letter-spacing: normal;
                     line-height: normal; orphans: 2; text-indent: 0px;
                     text-transform: none; white-space: normal; widows:
                     2; word-spacing: 0px; font-size: medium;">
                     <div style="word-wrap: break-word;"><span
                         class="Apple-style-span" style="border-collapse:
                         separate; color: rgb(0, 0, 0); font-family:
                         Helvetica; font-size: medium; font-style:
                         normal; font-variant: normal; font-weight:
                         normal; letter-spacing: normal; line-height:
                         normal; orphans: 2; text-indent: 0px;
                         text-transform: none; white-space: normal;
                         widows: 2; word-spacing: 0px;">
                         <div style="word-wrap: break-word;"><span
                             class="Apple-style-span"
                             style="border-collapse: separate; color:
                             rgb(0, 0, 0); font-family: Helvetica;
                             font-size: medium; font-style: normal;
                             font-variant: normal; font-weight: normal;
                             letter-spacing: normal; line-height: normal;
                             orphans: 2; text-indent: 0px;
                             text-transform: none; white-space: normal;
                             widows: 2; word-spacing: 0px;">
                             <div style="word-wrap: break-word;">--&nbsp;<br>
                               Cheers,<br>
                               Devin Teske<br>
                               <br>
                               -&gt; CONTACT INFORMATION &lt;-<br>
                               Business Solutions Consultant II<br>
                               FIS -&nbsp;<a moz-do-not-send="true"
                                 href="http://fisglobal.com/">fisglobal.com</a></div>
                             <div style="word-wrap: break-word;">510-735-5650
                               Mobile<br>
                               510-621-2038 Office<br>
                               510-621-2020 Office Fax<br>
                               909-477-4578 Home/Fax<br>
                               <a moz-do-not-send="true"
                                 href="mailto:devin.teske@fisglobal.com">devin.teske@fisglobal.com</a><br>
                               <br>
                               -&gt; LEGAL DISCLAIMER &lt;-<br>
                               This message &nbsp;contains confidential
                               &nbsp;and&nbsp;proprietary &nbsp;information<br>
                               of the sender, &nbsp;and is intended only for
                               the&nbsp;person(s) to whom it<br>
                               is addressed. Any use, distribution,
                               copying&nbsp;or disclosure by any<br>
                               other person &nbsp;is strictly prohibited. &nbsp;If
                               you&nbsp;have &nbsp;received this<br>
                               message in error, &nbsp;please notify &nbsp;the
                               e-mail&nbsp;sender &nbsp;immediately,<br>
                               and delete the original message
                               without&nbsp;making a copy.<br>
                               <br>
                               -&gt; END TRANSMISSION &lt;-</div>
                           </span></div>
                       </span></div>
                   </span></div>
               </span></div>
           </span></span>
       </div>
       <br>
       <div>
         _____________<br>
         The information contained in this message is proprietary and/or
         confidential. If you are not the intended recipient, please: (i)
         delete the message and all copies; (ii) do not disclose,
         distribute or use the message in any manner; and (iii) notify
         the sender immediately. In addition, please be aware that any
         message addressed to our domain is subject to archiving and
         review by persons other than the intended recipient. Thank you.<br>
       </div>
     </blockquote>
     <br>
     <div class="moz-signature">-- <br>
       Michael Scheidell, CTO<br>
       o: 561-999-5000<br>
       d: 561-948-2259<br>
       <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
       Network Security Corporation
       <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
       <ul class="unnamed1">
         <li>Best Mobile Solutions Product of 2011</li>
         <li>Best Intrusion Prevention Product</li>
         <li>Hot Company Finalist 2011</li>
         <li>Best Email Security Product</li>
         <li>Certified SNORT Integrator</li>
       </ul>
     </div>
   </body>
 </html>
 
 --------------070609050108030703030708--

From: Devin Teske <devin.teske@fisglobal.com>
To: Michael Scheidell <scheidell@freebsd.org>
Cc: "<bug-followup@FreeBSD.org>" <bug-followup@FreeBSD.org>,
        "<dteske@vicor.com>" <dteske@vicor.com>
Subject: * Re: bin/164039: [PATCH] tzsetup(8): Don&#39;t write
 /var/db/zoneinfo either when &quot;-n&quot; is passed or when
 install_zoneinfo_file returns failure
Date: Mon, 23 Jan 2012 06:55:44 -0800

 --Apple-Mail-4--1016473345
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain; charset="us-ascii"
 
 
 On Jan 23, 2012, at 2:13 AM, Michael Scheidell <scheidell@freebsd.org> wrot=
 e:
 
 >=20
 >=20
 > On 1/23/12 12:06 AM, Devin Teske wrote:
 >>=20
 >> Hmmm, I'm afraid I don't understand.
 >>=20
 >> Can you clarify?
 >> --=20
 >> Devin
 >=20
 > mostly meant for the maintainer.=20
 
 Huh? I'm not the maintainer of zoneinfo (only tzdialog, not even tzsetup, j=
 ust tzdialog). I'm afraid I still don't understand.
 
 
 > There are two bugs open for zoneinfo.
 
 You linked me to one PR on zoneinfo and one PR on tzsetup (which I submitte=
 d). The two PRs are not related other than the face that they both deal wit=
 h TZ stuff.
 
 
 >   they both need to be committed.
 
 2 out of 3 PRs I filed on tzsetup have already been committed. The one you =
 mentioned is already patched.
 --=20
 Devin
 
 >=20
 >>=20
 >> On Jan 22, 2012, at 6:52 PM, Michael Scheidell wrote:
 >>=20
 >>> have you seen this bug also?  want to combine them?
 >>>=20
 >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/162993=20=20
 >>>=20
 >>>=20
 >>> --=20
 >>> Michael Scheidell, CTO
 >>> o: 561-999-5000
 >>> d: 561-948-2259
 >>> > | SECNAP Network Security Corporation
 >>> Best Mobile Solutions Product of 2011
 >>> Best Intrusion Prevention Product
 >>> Hot Company Finalist 2011
 >>> Best Email Security Product
 >>> Certified SNORT Integrator
 >>=20
 >> --=20
 >> Cheers,
 >> Devin Teske
 >>=20
 >> -> CONTACT INFORMATION <-
 >> Business Solutions Consultant II
 >> FIS - fisglobal.com
 >> 510-735-5650 Mobile
 >> 510-621-2038 Office
 >> 510-621-2020 Office Fax
 >> 909-477-4578 Home/Fax
 >> devin.teske@fisglobal.com
 >>=20
 >> -> LEGAL DISCLAIMER <-
 >> This message  contains confidential  and proprietary  information
 >> of the sender,  and is intended only for the person(s) to whom it
 >> is addressed. Any use, distribution, copying or disclosure by any
 >> other person  is strictly prohibited.  If you have  received this
 >> message in error,  please notify  the e-mail sender  immediately,
 >> and delete the original message without making a copy.
 >>=20
 >> -> END TRANSMISSION <-
 >>=20
 >> _____________
 >> The information contained in this message is proprietary and/or confiden=
 tial. If you are not the intended recipient, please: (i) delete the message=
  and all copies; (ii) do not disclose, distribute or use the message in any=
  manner; and (iii) notify the sender immediately. In addition, please be aw=
 are that any message addressed to our domain is subject to archiving and re=
 view by persons other than the intended recipient. Thank you.
 >=20
 > --=20
 > Michael Scheidell, CTO
 > o: 561-999-5000
 > d: 561-948-2259
 > > | SECNAP Network Security Corporation
 > Best Mobile Solutions Product of 2011
 > Best Intrusion Prevention Product
 > Hot Company Finalist 2011
 > Best Email Security Product
 > Certified SNORT Integrator
 
 _____________
 The information contained in this message is proprietary and/or confidentia=
 l. If you are not the intended recipient, please: (i) delete the message an=
 d all copies; (ii) do not disclose, distribute or use the message in any ma=
 nner; and (iii) notify the sender immediately. In addition, please be aware=
  that any message addressed to our domain is subject to archiving and revie=
 w by persons other than the intended recipient. Thank you.
 
 --Apple-Mail-4--1016473345
 Content-Type: text/html; charset="utf-8"
 Content-Transfer-Encoding: 8bit
 
 <html><body bgcolor="#FFFFFF"><div><br></div><div>On Jan 23, 2012, at 2:13 AM, Michael Scheidell &lt;<a href="mailto:scheidell@freebsd.org">scheidell@freebsd.org</a>&gt; wrote:<br><br></div><div></div><blockquote type="cite"><div>
     <br>
     <br>
     On 1/23/12 12:06 AM, Devin Teske wrote:
     <blockquote cite="mid:9D2906B6-CDD4-4068-AC82-57571598D20D@fisglobal.com" type="cite">
       
       <div>Hmmm, I'm afraid I don't understand.</div>
       <div><br>
       </div>
       <div>Can you clarify?</div>
       <div>--&nbsp;</div>
       <div>Devin</div>
     </blockquote>
     <br>
     mostly meant for the maintainer.&nbsp; </div></blockquote><div><br></div><div>Huh? I'm not the maintainer of zoneinfo (only tzdialog, not even tzsetup, just tzdialog). I'm afraid I still don't understand.</div><div><br></div><br><blockquote type="cite"><div>There are two bugs open for
     zoneinfo.</div></blockquote><div><br></div><div>You linked me to one PR on zoneinfo and one PR on tzsetup (which I submitted). The two PRs are not related other than the face that they both deal with TZ stuff.</div><div><br></div><br><blockquote type="cite"><div>&nbsp; they both need to be committed.<br></div></blockquote><div><br></div><div>2 out of 3 PRs I filed on tzsetup have already been committed. The one you mentioned is already patched.</div><div>--&nbsp;</div><div>Devin</div><br><blockquote ty pe="cite"><div>
     <br>
     <blockquote cite="mid:9D2906B6-CDD4-4068-AC82-57571598D20D@fisglobal.com" type="cite"><br>
       <div>
         <div>On Jan 22, 2012, at 6:52 PM, Michael Scheidell wrote:</div>
         <br class="Apple-interchange-newline">
         <blockquote type="cite">
           <div bgcolor="#ffffff" text="#000000"> have you seen this bug
             also?&nbsp; want to combine them?<br>
             <br>
             <a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993"><a href="http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993">http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162993</a></a>&nbsp;
             <br>
             <br>
             <br>
             <div class="moz-signature">-- <br>
               Michael Scheidell, CTO<br>
               o: 561-999-5000<br>
               d: 561-948-2259<br>
               <font color="#999999">&gt;</font><font color="#cc0000"> <b>|
                 </b></font>SECNAP Network Security Corporation
               <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
               <ul class="unnamed1">
                 <li>Best Mobile Solutions Product of 2011</li>
                 <li>Best Intrusion Prevention Product</li>
                 <li>Hot Company Finalist 2011</li>
                 <li>Best Email Security Product</li>
                 <li>Certified SNORT Integrator</li>
               </ul>
             </div>
           </div>
         </blockquote>
       </div>
       <br>
       <div>
         <span class="Apple-style-span" style="border-collapse: separate;
           color: rgb(0, 0, 0); font-family: Helvetica; font-style:
           normal; font-variant: normal; font-weight: normal;
           letter-spacing: normal; line-height: normal; orphans: 2;
           text-indent: 0px; text-transform: none; white-space: normal;
           widows: 2; word-spacing: 0px; font-size: medium;"><span class="Apple-style-span" style="border-collapse: separate;
             color: rgb(0, 0, 0); font-family: Helvetica; font-style:
             normal; font-variant: normal; font-weight: normal;
             letter-spacing: normal; line-height: normal; orphans: 2;
             text-indent: 0px; text-transform: none; white-space: normal;
             widows: 2; word-spacing: 0px; font-size: medium;">
             <div style="word-wrap: break-word;"><span class="Apple-style-span" style="border-collapse:
                 separate; color: rgb(0, 0, 0); font-family: Helvetica;
                 font-style: normal; font-variant: normal; font-weight:
                 normal; letter-spacing: normal; line-height: normal;
                 orphans: 2; text-indent: 0px; text-transform: none;
                 white-space: normal; widows: 2; word-spacing: 0px;
                 font-size: medium;">
                 <div style="word-wrap: break-word;"><span class="Apple-style-span" style="border-collapse:
                     separate; color: rgb(0, 0, 0); font-family:
                     Helvetica; font-style: normal; font-variant: normal;
                     font-weight: normal; letter-spacing: normal;
                     line-height: normal; orphans: 2; text-indent: 0px;
                     text-transform: none; white-space: normal; widows:
                     2; word-spacing: 0px; font-size: medium;">
                     <div style="word-wrap: break-word;"><span class="Apple-style-span" style="border-collapse:
                         separate; color: rgb(0, 0, 0); font-family:
                         Helvetica; font-size: medium; font-style:
                         normal; font-variant: normal; font-weight:
                         normal; letter-spacing: normal; line-height:
                         normal; orphans: 2; text-indent: 0px;
                         text-transform: none; white-space: normal;
                         widows: 2; word-spacing: 0px;">
                         <div style="word-wrap: break-word;"><span class="Apple-style-span" style="border-collapse: separate; color:
                             rgb(0, 0, 0); font-family: Helvetica;
                             font-size: medium; font-style: normal;
                             font-variant: normal; font-weight: normal;
                             letter-spacing: normal; line-height: normal;
                             orphans: 2; text-indent: 0px;
                             text-transform: none; white-space: normal;
                             widows: 2; word-spacing: 0px;">
                             <div style="word-wrap: break-word;">--&nbsp;<br>
                               Cheers,<br>
                               Devin Teske<br>
                               <br>
                               -&gt; CONTACT INFORMATION &lt;-<br>
                               Business Solutions Consultant II<br>
                               FIS -&nbsp;<a moz-do-not-send="true" href="http://fisglobal.com/"><a href="http://fisglobal.com">fisglobal.com</a></a></div>
                             <div style="word-wrap: break-word;">510-735-5650
                               Mobile<br>
                               510-621-2038 Office<br>
                               510-621-2020 Office Fax<br>
                               909-477-4578 Home/Fax<br>
                               <a moz-do-not-send="true" href="mailto:devin.teske@fisglobal.com"><a href="mailto:devin.teske@fisglobal.com">devin.teske@fisglobal.com</a></a><br>
                               <br>
                               -&gt; LEGAL DISCLAIMER &lt;-<br>
                               This message &nbsp;contains confidential
                               &nbsp;and&nbsp;proprietary &nbsp;information<br>
                               of the sender, &nbsp;and is intended only for
                               the&nbsp;person(s) to whom it<br>
                               is addressed. Any use, distribution,
                               copying&nbsp;or disclosure by any<br>
                               other person &nbsp;is strictly prohibited. &nbsp;If
                               you&nbsp;have &nbsp;received this<br>
                               message in error, &nbsp;please notify &nbsp;the
                               e-mail&nbsp;sender &nbsp;immediately,<br>
                               and delete the original message
                               without&nbsp;making a copy.<br>
                               <br>
                               -&gt; END TRANSMISSION &lt;-</div>
                           </span></div>
                       </span></div>
                   </span></div>
               </span></div>
           </span></span>
       </div>
       <br>
       <div>
         _____________<br>
         The information contained in this message is proprietary and/or
         confidential. If you are not the intended recipient, please: (i)
         delete the message and all copies; (ii) do not disclose,
         distribute or use the message in any manner; and (iii) notify
         the sender immediately. In addition, please be aware that any
         message addressed to our domain is subject to archiving and
         review by persons other than the intended recipient. Thank you.<br>
       </div>
     </blockquote>
     <br>
     <div class="moz-signature">-- <br>
       Michael Scheidell, CTO<br>
       o: 561-999-5000<br>
       d: 561-948-2259<br>
       <font color="#999999">&gt;</font><font color="#cc0000"> <b>| </b></font>SECNAP
       Network Security Corporation
       <style type="text/css">
 <!--
 .unnamed1 {
 	margin: 1em;
 	padding: 1px;
 } -->
 </style>
       <ul class="unnamed1">
         <li>Best Mobile Solutions Product of 2011</li>
         <li>Best Intrusion Prevention Product</li>
         <li>Hot Company Finalist 2011</li>
         <li>Best Email Security Product</li>
         <li>Certified SNORT Integrator</li>
       </ul>
     </div>
   
 
 </div></blockquote>
 <DIV>
 _____________<BR>
 The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.<BR>
 </DIV></body></html>
 
 --Apple-Mail-4--1016473345--
Responsible-Changed-From-To: emaste->dteske 
Responsible-Changed-By: emaste 
Responsible-Changed-When: Mon Apr 9 13:22:14 UTC 2012 
Responsible-Changed-Why:  
Submitter is becoming a committer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164039 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164039: commit references a PR
Date: Sun,  3 Mar 2013 19:26:26 +0000 (UTC)

 Author: dteske
 Date: Sun Mar  3 19:26:05 2013
 New Revision: 247728
 URL: http://svnweb.freebsd.org/changeset/base/247728
 
 Log:
   MFC r230296:
   
   Don't write /var/db/zoneinfo when zone is not actually changed.
   
   If the specified zone file does not exist or the -n flag is specified,
   do not update /var/db/zoneinfo.
   
   PR:		bin/164039
   Submitted by:	dteske
 
 Modified:
   stable/9/usr.sbin/tzsetup/tzsetup.c
 
 Modified: stable/9/usr.sbin/tzsetup/tzsetup.c
 ==============================================================================
 --- stable/9/usr.sbin/tzsetup/tzsetup.c	Sun Mar  3 19:20:30 2013	(r247727)
 +++ stable/9/usr.sbin/tzsetup/tzsetup.c	Sun Mar  3 19:26:05 2013	(r247728)
 @@ -836,9 +836,11 @@ install_zoneinfo(const char *zoneinfo)
  	rv = install_zoneinfo_file(path_zoneinfo_file);
  
  	/* Save knowledge for later */
 -	if ((f = fopen(path_db, "w")) != NULL) {
 -		fprintf(f, "%s\n", zoneinfo);
 -		fclose(f);
 +	if (reallydoit && (rv & DITEM_FAILURE) == 0) {
 +		if ((f = fopen(path_db, "w")) != NULL) {
 +			fprintf(f, "%s\n", zoneinfo);
 +			fclose(f);
 +		}
  	}
  
  	return (rv);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/164039: commit references a PR
Date: Mon,  4 Mar 2013 01:36:14 +0000 (UTC)

 Author: dteske
 Date: Mon Mar  4 01:35:56 2013
 New Revision: 247748
 URL: http://svnweb.freebsd.org/changeset/base/247748
 
 Log:
   MFC r230296:
   
   Don't write /var/db/zoneinfo when zone is not actually changed.
   
   If the specified zone file does not exist or the -n flag is specified,
   do not update /var/db/zoneinfo.
   
   PR:		bin/164039
   Submitted by:	dteske
 
 Modified:
   stable/8/usr.sbin/tzsetup/tzsetup.c
 
 Modified: stable/8/usr.sbin/tzsetup/tzsetup.c
 ==============================================================================
 --- stable/8/usr.sbin/tzsetup/tzsetup.c	Mon Mar  4 01:32:24 2013	(r247747)
 +++ stable/8/usr.sbin/tzsetup/tzsetup.c	Mon Mar  4 01:35:56 2013	(r247748)
 @@ -721,9 +721,11 @@ install_zoneinfo(const char *zoneinfo)
  	rv = install_zoneinfo_file(path_zoneinfo_file);
  
  	/* Save knowledge for later */
 -	if ((f = fopen(path_db, "w")) != NULL) {
 -		fprintf(f, "%s\n", zoneinfo);
 -		fclose(f);
 +	if (reallydoit && (rv & DITEM_FAILURE) == 0) {
 +		if ((f = fopen(path_db, "w")) != NULL) {
 +			fprintf(f, "%s\n", zoneinfo);
 +			fclose(f);
 +		}
  	}
  
  	return (rv);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: dteske 
State-Changed-When: Mon Mar 4 11:20:33 UTC 2013 
State-Changed-Why:  
MFC'd to stable/9 with r247728 and stable/8 with r247748 

http://www.freebsd.org/cgi/query-pr.cgi?pr=164039 
>Unformatted:
