From nobody@FreeBSD.org  Sun Nov 27 17:53:19 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7DAC9106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Nov 2011 17:53:19 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6E0D98FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Nov 2011 17:53:19 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pARHrIRS056770
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Nov 2011 17:53:18 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id pARHrIvh056762;
	Sun, 27 Nov 2011 17:53:18 GMT
	(envelope-from nobody)
Message-Id: <201111271753.pARHrIvh056762@red.freebsd.org>
Date: Sun, 27 Nov 2011 17:53:18 GMT
From: Oleg Ginzburg <olevole@olevole.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: zdump doesn't know progname
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         162908
>Category:       bin
>Synopsis:       [patch] zdump(8) doesn't know progname
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 27 18:00:20 UTC 2011
>Closed-Date:    Wed Feb 01 04:55:26 UTC 2012
>Last-Modified:  Wed Feb 01 04:55:26 UTC 2012
>Originator:     Oleg Ginzburg
>Release:        9.0-PRERELEASE
>Organization:
>Environment:
>Description:
The progname variable in zdump(8) is equal null

Something like progname=argv[0] or getprogname(3) missed
>How-To-Repeat:
% zdump -z  

(usage: (null) [--version] [-v] [--help] [-c [loyear,]hiyear] zonename ...)

>Fix:


Patch attached with submission follows:

diff -ruN /usr/src/contrib/tzcode/zic.bak/zdump.c /usr/src/contrib/tzcode/zic/zdump.c
--- /usr/src/contrib/tzcode/zic.bak/zdump.c	2011-11-27 21:42:58.776739066 +0400
+++ /usr/src/contrib/tzcode/zic/zdump.c	2011-11-27 21:43:38.735740140 +0400
@@ -260,6 +260,7 @@
 	register struct tm *	tmp;
 	register struct tm *	newtmp;
 
+	progname=argv[0];
 	INITIALIZE(cutlotime);
 	INITIALIZE(cuthitime);
 #if HAVE_GETTEXT


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Dec 4 00:29:13 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162908 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/162908: commit references a PR
Date: Thu,  8 Dec 2011 02:40:55 +0000 (UTC)

 Author: eadler (ports committer)
 Date: Thu Dec  8 02:40:46 2011
 New Revision: 228342
 URL: http://svn.freebsd.org/changeset/base/228342
 
 Log:
   - set progname for use in usage()
   
   PR:		bin/162908
   Submitted by:	Oleg Ginzburg <olevole@olevole.ru>
   Approved by:	sbruno@
   MFC after:	3 days
 
 Modified:
   head/contrib/tzcode/zic/zdump.c
 
 Modified: head/contrib/tzcode/zic/zdump.c
 ==============================================================================
 --- head/contrib/tzcode/zic/zdump.c	Thu Dec  8 00:56:23 2011	(r228341)
 +++ head/contrib/tzcode/zic/zdump.c	Thu Dec  8 02:40:46 2011	(r228342)
 @@ -260,6 +260,7 @@ char *	argv[];
  	register struct tm *	tmp;
  	register struct tm *	newtmp;
  
 +	progname=argv[0];
  	INITIALIZE(cutlotime);
  	INITIALIZE(cuthitime);
  #if HAVE_GETTEXT
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: eadler 
State-Changed-When: Thu Dec 8 03:26:13 UTC 2011 
State-Changed-Why:  
commited in r228342 


http://www.freebsd.org/cgi/query-pr.cgi?pr=162908 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Wed Feb 1 04:55:25 UTC 2012 
State-Changed-Why:  
contrib code & fix sent upstream so I'm not going to MFC this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=162908 
>Unformatted:
