From nobody@FreeBSD.org  Mon Oct 24 01:07:41 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1DF7B106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 01:07:41 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0E3EF8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 01:07:41 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p9O17eXA010532
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 24 Oct 2011 01:07:40 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p9O17el1010531;
	Mon, 24 Oct 2011 01:07:40 GMT
	(envelope-from nobody)
Message-Id: <201110240107.p9O17el1010531@red.freebsd.org>
Date: Mon, 24 Oct 2011 01:07:40 GMT
From: Richard Yao <ryao@cs.stonybrook.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: FreeBSD 9 installer enters infinite input loop
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         161950
>Category:       bin
>Synopsis:       bsdinstall(8): FreeBSD 9 installer enters infinite input loop
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-sysinstall
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 24 01:10:00 UTC 2011
>Closed-Date:    Tue Oct 25 16:37:24 UTC 2011
>Last-Modified:  Tue Oct 25 16:40:11 UTC 2011
>Originator:     Richard Yao
>Release:        FreeBSD9-RC1
>Organization:
State University of New York at Stony Brook
>Environment:
FreeBSD freebsd9 9.0-RC1 FreeBSD 9.0-RC1 #0 Tue Oct 18 18:51:43 UTC 2011 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
I ran the FreeBSD9-RC1 installer on a KVM virtual machine with virtio network and storage devices. Since FreeBSD9-RC1 did not support those, it didn't see either of them. The installer entered an infinite input loop upon selection of guided mode, where it stated "An installation step has been aborted." with some information on my options. This lead to the installer restarting itself from the beginning, with the same result when it came time to partition the disk.

I reconfigured the VM to use a SCSI device, which broke the first infinite input loop and then ran into a similar loop when it came time to configure the network interfaces, where I kept being asked if I wanted to configure IPv4.
>How-To-Repeat:
Try to install FreeBSD9-RC1 on a system that has no disk or network interface card.
>Fix:
Check to see if a disk or network interface card exists and inform the user so that he does not enter an infinite input loop.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-sysinstall 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Mon Oct 24 01:23:01 UTC 2011 
Responsible-Changed-Why:  
Over to maintainer(s). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161950 
State-Changed-From-To: open->analyzed 
State-Changed-By: nwhitehorn 
State-Changed-When: Mon Oct 24 13:33:02 UTC 2011 
State-Changed-Why:  
Thanks for the bug report! The no disks/no network interfaces case was 
one that didn't really get tested. I see where the bugs are, and should 
get patches in soon. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161950 
State-Changed-From-To: analyzed->closed 
State-Changed-By: nwhitehorn 
State-Changed-When: Tue Oct 25 16:37:00 UTC 2011 
State-Changed-Why:  
Fixed in r226739 and r226741. Thanks for the report! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161950 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/161950: commit references a PR
Date: Tue, 25 Oct 2011 16:30:42 +0000 (UTC)

 Author: nwhitehorn
 Date: Tue Oct 25 16:30:16 2011
 New Revision: 226739
 URL: http://svn.freebsd.org/changeset/base/226739
 
 Log:
   Provide an error message instead of silent failure if no disks are present
   in the system.
   
   PR:		bin/161950
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/bsdinstall/partedit/partedit.c
 
 Modified: head/usr.sbin/bsdinstall/partedit/partedit.c
 ==============================================================================
 --- head/usr.sbin/bsdinstall/partedit/partedit.c	Tue Oct 25 16:22:43 2011	(r226738)
 +++ head/usr.sbin/bsdinstall/partedit/partedit.c	Tue Oct 25 16:30:16 2011	(r226739)
 @@ -70,7 +70,7 @@ main(int argc, const char **argv)
  {
  	struct partition_metadata *md;
  	const char *prompt;
 -	struct partedit_item *items;
 +	struct partedit_item *items = NULL;
  	struct gmesh mesh;
  	int i, op, nitems, nscroll;
  	int error;
 @@ -99,12 +99,21 @@ main(int argc, const char **argv)
  
  	/* Show the part editor either immediately, or to confirm wizard */
  	while (1) {
 -		error = geom_gettree(&mesh);
 -		items = read_geom_mesh(&mesh, &nitems);
 -		get_mount_points(items, nitems);
  		dlg_clear();
  		dlg_put_backtitle();
  
 +		error = geom_gettree(&mesh);
 +		if (error == 0)
 +			items = read_geom_mesh(&mesh, &nitems);
 +		if (error || items == NULL) {
 +			dialog_msgbox("Error", "No disks found. If you need to "
 +			    "install a kernel driver, choose Shell at the "
 +			    "installation menu.", 0, 0, TRUE);
 +			break;
 +		}
 +			
 +		get_mount_points(items, nitems);
 +
  		if (i >= nitems)
  			i = nitems - 1;
  		op = diskeditor_show("Partition Editor", prompt,
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/161950: commit references a PR
Date: Tue, 25 Oct 2011 16:35:58 +0000 (UTC)

 Author: nwhitehorn
 Date: Tue Oct 25 16:35:48 2011
 New Revision: 226741
 URL: http://svn.freebsd.org/changeset/base/226741
 
 Log:
   Provide an error message and error handling if there are no network
   interfaces in the system. This is a non-fatal error except when doing a
   network installation.
   
   PR:		bin/161950
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/bsdinstall/scripts/netconfig
 
 Modified: head/usr.sbin/bsdinstall/scripts/netconfig
 ==============================================================================
 --- head/usr.sbin/bsdinstall/scripts/netconfig	Tue Oct 25 16:35:08 2011	(r226740)
 +++ head/usr.sbin/bsdinstall/scripts/netconfig	Tue Oct 25 16:35:48 2011	(r226741)
 @@ -49,6 +49,13 @@ for IF in `ifconfig -l`; do
  	DIALOG_TAGS="$DIALOG_TAGS $IF \"$DESC\""
  done
  
 +if [ -z "$INTERFACES" ]; then
 +	dialog --backtitle 'FreeBSD Installer' \
 +	    --title 'Network Configuration Error' \
 +	    --msgbox 'No network interfaces present to configure.' 0 0
 +	exit 1
 +fi
 +
  exec 3>&1
  INTERFACE=`echo $DIALOG_TAGS | xargs dialog --backtitle 'FreeBSD Installer' --title 'Network Configuration' --menu 'Please select a network interface to configure:' 0 0 0 2>&1 1>&3`
  if [ $? -eq $DIALOG_CANCEL ]; then exit 1; fi
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
