From nobody@FreeBSD.org  Sat Sep 24 17:21:01 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1D7BA1065678
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Sep 2011 17:21:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 0DB018FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Sep 2011 17:21:01 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8OHL0P8062579
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 24 Sep 2011 17:21:00 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8OHL00D062578;
	Sat, 24 Sep 2011 17:21:00 GMT
	(envelope-from nobody)
Message-Id: <201109241721.p8OHL00D062578@red.freebsd.org>
Date: Sat, 24 Sep 2011 17:21:00 GMT
From: Joe Barbish <fbsd8@a1poweruser.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: 9.0 burncd error caused by change to cd0 from acd0
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160979
>Category:       bin
>Synopsis:       burncd(8): 9.0 burncd error caused by change to cd0 from acd0
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 24 17:30:14 UTC 2011
>Closed-Date:    Fri Mar 30 23:58:44 UTC 2012
>Last-Modified:  Fri Mar 30 23:58:44 UTC 2012
>Originator:     Joe Barbish
>Release:        9.0 beta 2
>Organization:
none
>Environment:
>Description:
It seems that in 9.0 the cd/dvd/drive is now given a dev name of cd0 
where in all previous releases it was acd0. 
Tried to use the system burncd command in 9.0 and got this error msg

burncd: ioctl(CDRIOCGETBLOCKSIZE): Inappropriate ioctl for device

Tested using "burncd -f acd0" and "burncd -f cd0".
In both cases got the same error message.

Looks to me like the burncd command needs to be fixed
to work in 9.0. 


>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Joe Barbish <fbsd8@a1poweruser.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0
Date: Sun, 25 Sep 2011 13:00:43 +0300

 On 2011-09-24, Joe Barbish wrote:
 > It seems that in 9.0 the cd/dvd/drive is now given a dev name of cd0 
 > where in all previous releases it was acd0. 
 > Tried to use the system burncd command in 9.0 and got this error msg
 > 
 > burncd: ioctl(CDRIOCGETBLOCKSIZE): Inappropriate ioctl for device
 > 
 > Tested using "burncd -f acd0" and "burncd -f cd0".
 > In both cases got the same error message.
 > 
 > Looks to me like the burncd command needs to be fixed
 > to work in 9.0. 
 
 burncd(8) supports only acd(4) driver. In 9.0 the default is the new
 CAM-based ATA stack which uses cd(4) (UPDATING entry 20110424).
 
 It's unlikely that a support for cd(4) will be added to burncd(8).
 
 I think this should be mentioned in release notes.
 
 -- 
 Jaakko

From: Fbsd8 <fbsd8@a1poweruser.com>
To: Jaakko Heinonen <jh@FreeBSD.org>
Cc: bug-followup@FreeBSD.org, freebsd-current@freebsd.org
Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0
Date: Sun, 25 Sep 2011 08:44:48 -0400

 Jaakko Heinonen wrote:
 > On 2011-09-24, Joe Barbish wrote:
 >> It seems that in 9.0 the cd/dvd/drive is now given a dev name of cd0 
 >> where in all previous releases it was acd0. 
 >> Tried to use the system burncd command in 9.0 and got this error msg
 >>
 >> burncd: ioctl(CDRIOCGETBLOCKSIZE): Inappropriate ioctl for device
 >>
 >> Tested using "burncd -f acd0" and "burncd -f cd0".
 >> In both cases got the same error message.
 >>
 >> Looks to me like the burncd command needs to be fixed
 >> to work in 9.0. 
 > 
 > burncd(8) supports only acd(4) driver. In 9.0 the default is the new
 > CAM-based ATA stack which uses cd(4) (UPDATING entry 20110424).
 > 
 > It's unlikely that a support for cd(4) will be added to burncd(8).
 > 
 > I think this should be mentioned in release notes.
 > 
 
 
 Fixing burncd should be a priority, this PR gets it into the "must fix 
 queue" before the next round of beta or RC releases. Yes you have 
 identified what is causing it to not work, but you have not followed 
 through. The next step is to assign it to someone to work on it now. 
 Thats the whole idea of the PR system and beta testing.
 
 If burncd is not going to work in 9.0 then it should be removed from the 
 release all together. Has any research been done to identify other 
 system commands or ports that changing the system default from acd0 to 
 cd0 effects?
 

From: Eric Masson <emss@free.fr>
To: Fbsd8 <fbsd8@a1poweruser.com>
Cc: Jaakko Heinonen <jh@FreeBSD.org>,  freebsd-current@freebsd.org,
	  bug-followup@FreeBSD.org
Subject: Re: bin/160979: 9.0 burncd error caused by change to cd0 from acd0
Date: Sun, 25 Sep 2011 20:05:25 +0200

 Fbsd8 <fbsd8@a1poweruser.com> writes:
 
 Hi,
 
 > Fixing burncd should be a priority
 
 It's not broken, so it doesn't need to be fixed.
 burncd has been designed to work with the old ata stack, when using new
 cam based ata stack, just use cdrecord.
 It deserves an entry in the release notes, nothing less, nothing more.
 
 ric Masson
 
 -- 
  Je n'ai pas envie de perdre mon temps  leur APD  la con. Mais j'ai
  besoin du certificat qu'y est dlivr, pour passer le permis. J'ai
  entendu qu'on le trouvait sur Internet. Quelqu'un aurait-il des infos?
  -+- DC in GNU : Neuneu s'achte une conduite -+-
State-Changed-From-To: open->analyzed 
State-Changed-By: eadler 
State-Changed-When: Mon Sep 26 23:24:00 UTC 2011 
State-Changed-Why:  
requires only a release notes entry; use cdrecord instead of burncd 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160979 
State-Changed-From-To: analyzed->patched 
State-Changed-By: rodrigc 
State-Changed-When: Sun Oct 9 14:42:22 PDT 2011 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=160979 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160979: commit references a PR
Date: Sun,  9 Oct 2011 21:42:17 +0000 (UTC)

 Author: rodrigc
 Date: Sun Oct  9 21:42:02 2011
 New Revision: 226179
 URL: http://svn.freebsd.org/changeset/base/226179
 
 Log:
   Add a "kern.features.ata_cam" sysctl in the kernel when the ATA_CAM kernel
   option is defined.  This sysctl can be queried by feature_present(3).
   
   Query for this feature in /sbin/atacontrol and /usr/sbin/burncd.
   If these utilities detect that ATA_CAM is enabled, then these utilities
   will error out.  These utilities are compatible with the old ATA
   driver, but are incomptible with the new ATA_CAM driver.  By erroring out,
   we give end-users an idea as to what remedies to use, and reduce the need for them
   to file PR's.  For atacontrol, camcontrol must be used instead,
   and for burncd, alternative utilties from the ports collection must be used
   such as sysutils/cdrtools.
   
   In future, maybe someone can re-write burncd to work with ATA_CAM,
   but at least for now, we give a somewhat useful error message to end users.
   
   PR:		160979
   Reviewed by:	jh, Arnaud Lacombe <lacombar at gmail dot com>
   Reported by:	Joe Barbish <fbsd8 at a1poweruser dot com>
   MFC after:	3 days
 
 Modified:
   head/sbin/atacontrol/atacontrol.8
   head/sbin/atacontrol/atacontrol.c
   head/sys/dev/ata/ata-all.c
   head/usr.sbin/burncd/burncd.8
   head/usr.sbin/burncd/burncd.c
 
 Modified: head/sbin/atacontrol/atacontrol.8
 ==============================================================================
 --- head/sbin/atacontrol/atacontrol.8	Sun Oct  9 21:40:38 2011	(r226178)
 +++ head/sbin/atacontrol/atacontrol.8	Sun Oct  9 21:42:02 2011	(r226179)
 @@ -25,12 +25,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 21, 2009
 +.Dd October 9, 2011
  .Dt ATACONTROL 8
  .Os
  .Sh NAME
  .Nm atacontrol
  .Nd ATA device driver control program
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Aq Ar command
 @@ -361,11 +368,17 @@ or syslog logging on it as the disk will
  up all the time.
  .Sh SEE ALSO
  .Xr ata 4
 +.Xr cam 4
 +.Xr camcontrol 8
  .Sh HISTORY
  The
  .Nm
  utility first appeared in
  .Fx 4.6 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  .An -nosplit
  The
 @@ -377,3 +390,16 @@ utility was written by
  This manual page was written by
  .An S\(/oren Schmidt
  .Aq sos@FreeBSD.org .
 +.Sh NOTES
 +The
 +.Nm
 +utility was deprecated in
 +.Fx 9.0 .
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr camcontrol 8
 +must be used instead.
 
 Modified: head/sbin/atacontrol/atacontrol.c
 ==============================================================================
 --- head/sbin/atacontrol/atacontrol.c	Sun Oct  9 21:40:38 2011	(r226178)
 +++ head/sbin/atacontrol/atacontrol.c	Sun Oct  9 21:42:02 2011	(r226179)
 @@ -378,6 +378,11 @@ main(int argc, char **argv)
  {
  	int fd, mode, channel, array;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Please use camcontrol instead.");
 +	}
 +
  	if (argc < 2)
  		usage();
  
 
 Modified: head/sys/dev/ata/ata-all.c
 ==============================================================================
 --- head/sys/dev/ata/ata-all.c	Sun Oct  9 21:40:38 2011	(r226178)
 +++ head/sys/dev/ata/ata-all.c	Sun Oct  9 21:42:02 2011	(r226179)
 @@ -120,6 +120,9 @@ SYSCTL_INT(_hw_ata, OID_AUTO, wc, CTLFLA
  TUNABLE_INT("hw.ata.setmax", &ata_setmax);
  SYSCTL_INT(_hw_ata, OID_AUTO, setmax, CTLFLAG_RDTUN, &ata_setmax, 0,
  	   "ATA disk set max native address");
 +#ifdef ATA_CAM
 +FEATURE(ata_cam, "ATA devices are accessed through the cam(4) driver");
 +#endif
  
  /*
   * newbus device interface related functions
 
 Modified: head/usr.sbin/burncd/burncd.8
 ==============================================================================
 --- head/usr.sbin/burncd/burncd.8	Sun Oct  9 21:40:38 2011	(r226178)
 +++ head/usr.sbin/burncd/burncd.8	Sun Oct  9 21:42:02 2011	(r226179)
 @@ -27,12 +27,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd December 21, 2009
 +.Dd October 9, 2011
  .Dt BURNCD 8
  .Os
  .Sh NAME
  .Nm burncd
  .Nd control the ATAPI CD-R/RW driver
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Op Fl deFlmnpqtv
 @@ -211,6 +218,10 @@ The
  .Nm
  utility appeared in
  .Fx 4.0 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  The
  .Nm
 @@ -220,3 +231,19 @@ Denmark
  .Aq sos@FreeBSD.org .
  .Sh BUGS
  Probably, please report when found.
 +.Sh NOTES
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr cdrecord 1 ,
 +available in the
 +.Fx
 +Ports Collection as part of the
 +.Pa sysutils/cdrtools
 +port, must be used instead.
 +Refer to:
 +.Pp
 +http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD
 
 Modified: head/usr.sbin/burncd/burncd.c
 ==============================================================================
 --- head/usr.sbin/burncd/burncd.c	Sun Oct  9 21:40:38 2011	(r226178)
 +++ head/usr.sbin/burncd/burncd.c	Sun Oct  9 21:42:02 2011	(r226179)
 @@ -82,6 +82,13 @@ main(int argc, char **argv)
  	int block_size = 0, block_type = 0, cdopen = 0, dvdrw = 0;
  	const char *dev, *env_speed;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Install the sysutils/cdrtools port and use cdrecord instead.\n\n"
 +		    "Please refer to:\n"
 +		    "http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD");
 +	}
 +
  	if ((dev = getenv("CDROM")) == NULL)
  		dev = "/dev/acd0";
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160979: commit references a PR
Date: Wed, 26 Oct 2011 17:04:41 +0000 (UTC)

 Author: rodrigc
 Date: Wed Oct 26 17:04:26 2011
 New Revision: 226800
 URL: http://svn.freebsd.org/changeset/base/226800
 
 Log:
   Add a "kern.features.ata_cam" sysctl in the kernel when the ATA_CAM kernel
   option is defined.  This sysctl can be queried by feature_present(3).
   
   Query for this feature in /sbin/atacontrol and /usr/sbin/burncd.
   If these utilities detect that ATA_CAM is enabled, then these utilities
   will error out.  These utilities are compatible with the old ATA
   driver, but are incomptible with the new ATA_CAM driver.  By erroring out,
   we give end-users an idea as to what remedies to use, and reduce the need for them
   to file PR's.  For atacontrol, camcontrol must be used instead,
   and for burncd, alternative utilties from the ports collection must be used
   such as sysutils/cdrtools.
   
   In future, maybe someone can re-write burncd to work with ATA_CAM,
   but at least for now, we give a somewhat useful error message to end users.
   
   PR:		160979
   Reviewed by:	jh, Arnaud Lacombe <lacombar at gmail dot com>
   Approved by:	re (kib)
   Reported by:	Joe Barbish <fbsd8 at a1poweruser dot com>
 
 Modified:
   stable/9/sbin/atacontrol/atacontrol.8
   stable/9/sbin/atacontrol/atacontrol.c
   stable/9/sys/dev/ata/ata-all.c
   stable/9/usr.sbin/burncd/burncd.8
   stable/9/usr.sbin/burncd/burncd.c
 Directory Properties:
   stable/9/sbin/atacontrol/   (props changed)
   stable/9/sys/   (props changed)
   stable/9/usr.sbin/burncd/   (props changed)
 
 Modified: stable/9/sbin/atacontrol/atacontrol.8
 ==============================================================================
 --- stable/9/sbin/atacontrol/atacontrol.8	Wed Oct 26 16:11:49 2011	(r226799)
 +++ stable/9/sbin/atacontrol/atacontrol.8	Wed Oct 26 17:04:26 2011	(r226800)
 @@ -25,12 +25,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 21, 2009
 +.Dd October 9, 2011
  .Dt ATACONTROL 8
  .Os
  .Sh NAME
  .Nm atacontrol
  .Nd ATA device driver control program
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Aq Ar command
 @@ -361,11 +368,17 @@ or syslog logging on it as the disk will
  up all the time.
  .Sh SEE ALSO
  .Xr ata 4
 +.Xr cam 4
 +.Xr camcontrol 8
  .Sh HISTORY
  The
  .Nm
  utility first appeared in
  .Fx 4.6 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  .An -nosplit
  The
 @@ -377,3 +390,16 @@ utility was written by
  This manual page was written by
  .An S\(/oren Schmidt
  .Aq sos@FreeBSD.org .
 +.Sh NOTES
 +The
 +.Nm
 +utility was deprecated in
 +.Fx 9.0 .
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr camcontrol 8
 +must be used instead.
 
 Modified: stable/9/sbin/atacontrol/atacontrol.c
 ==============================================================================
 --- stable/9/sbin/atacontrol/atacontrol.c	Wed Oct 26 16:11:49 2011	(r226799)
 +++ stable/9/sbin/atacontrol/atacontrol.c	Wed Oct 26 17:04:26 2011	(r226800)
 @@ -378,6 +378,11 @@ main(int argc, char **argv)
  {
  	int fd, mode, channel, array;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Please use camcontrol instead.");
 +	}
 +
  	if (argc < 2)
  		usage();
  
 
 Modified: stable/9/sys/dev/ata/ata-all.c
 ==============================================================================
 --- stable/9/sys/dev/ata/ata-all.c	Wed Oct 26 16:11:49 2011	(r226799)
 +++ stable/9/sys/dev/ata/ata-all.c	Wed Oct 26 17:04:26 2011	(r226800)
 @@ -120,6 +120,9 @@ SYSCTL_INT(_hw_ata, OID_AUTO, wc, CTLFLA
  TUNABLE_INT("hw.ata.setmax", &ata_setmax);
  SYSCTL_INT(_hw_ata, OID_AUTO, setmax, CTLFLAG_RDTUN, &ata_setmax, 0,
  	   "ATA disk set max native address");
 +#ifdef ATA_CAM
 +FEATURE(ata_cam, "ATA devices are accessed through the cam(4) driver");
 +#endif
  
  /*
   * newbus device interface related functions
 
 Modified: stable/9/usr.sbin/burncd/burncd.8
 ==============================================================================
 --- stable/9/usr.sbin/burncd/burncd.8	Wed Oct 26 16:11:49 2011	(r226799)
 +++ stable/9/usr.sbin/burncd/burncd.8	Wed Oct 26 17:04:26 2011	(r226800)
 @@ -27,12 +27,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd December 21, 2009
 +.Dd October 9, 2011
  .Dt BURNCD 8
  .Os
  .Sh NAME
  .Nm burncd
  .Nd control the ATAPI CD-R/RW driver
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Op Fl deFlmnpqtv
 @@ -211,6 +218,10 @@ The
  .Nm
  utility appeared in
  .Fx 4.0 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  The
  .Nm
 @@ -220,3 +231,19 @@ Denmark
  .Aq sos@FreeBSD.org .
  .Sh BUGS
  Probably, please report when found.
 +.Sh NOTES
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr cdrecord 1 ,
 +available in the
 +.Fx
 +Ports Collection as part of the
 +.Pa sysutils/cdrtools
 +port, must be used instead.
 +Refer to:
 +.Pp
 +http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD
 
 Modified: stable/9/usr.sbin/burncd/burncd.c
 ==============================================================================
 --- stable/9/usr.sbin/burncd/burncd.c	Wed Oct 26 16:11:49 2011	(r226799)
 +++ stable/9/usr.sbin/burncd/burncd.c	Wed Oct 26 17:04:26 2011	(r226800)
 @@ -82,6 +82,13 @@ main(int argc, char **argv)
  	int block_size = 0, block_type = 0, cdopen = 0, dvdrw = 0;
  	const char *dev, *env_speed;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Install the sysutils/cdrtools port and use cdrecord instead.\n\n"
 +		    "Please refer to:\n"
 +		    "http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD");
 +	}
 +
  	if ((dev = getenv("CDROM")) == NULL)
  		dev = "/dev/acd0";
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160979: commit references a PR
Date: Fri, 30 Mar 2012 23:49:02 +0000 (UTC)

 Author: marius
 Date: Fri Mar 30 23:48:15 2012
 New Revision: 233714
 URL: http://svn.freebsd.org/changeset/base/233714
 
 Log:
   MFC: r226179
   
   Add a "kern.features.ata_cam" sysctl in the kernel when the ATA_CAM kernel
   option is defined.  This sysctl can be queried by feature_present(3).
   
   Query for this feature in /sbin/atacontrol and /usr/sbin/burncd.
   If these utilities detect that ATA_CAM is enabled, then these utilities
   will error out.  These utilities are compatible with the old ATA
   driver, but are incomptible with the new ATA_CAM driver.  By erroring out,
   we give end-users an idea as to what remedies to use, and reduce the need for them
   to file PR's.  For atacontrol, camcontrol must be used instead,
   and for burncd, alternative utilties from the ports collection must be used
   such as sysutils/cdrtools.
   
   In future, maybe someone can re-write burncd to work with ATA_CAM,
   but at least for now, we give a somewhat useful error message to end users.
   
   PR:		160979
   Reviewed by:	jh, Arnaud Lacombe <lacombar at gmail dot com>
   Reported by:	Joe Barbish <fbsd8 at a1poweruser dot com>
 
 Modified:
   stable/8/sbin/atacontrol/atacontrol.8
   stable/8/sbin/atacontrol/atacontrol.c
   stable/8/sys/dev/ata/ata-all.c
   stable/8/usr.sbin/burncd/burncd.8
   stable/8/usr.sbin/burncd/burncd.c
 Directory Properties:
   stable/8/sbin/atacontrol/   (props changed)
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/boot/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/e1000/   (props changed)
   stable/8/sys/i386/conf/XENHVM   (props changed)
   stable/8/usr.sbin/burncd/   (props changed)
 
 Modified: stable/8/sbin/atacontrol/atacontrol.8
 ==============================================================================
 --- stable/8/sbin/atacontrol/atacontrol.8	Fri Mar 30 23:39:39 2012	(r233713)
 +++ stable/8/sbin/atacontrol/atacontrol.8	Fri Mar 30 23:48:15 2012	(r233714)
 @@ -25,12 +25,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd February 21, 2009
 +.Dd October 9, 2011
  .Dt ATACONTROL 8
  .Os
  .Sh NAME
  .Nm atacontrol
  .Nd ATA device driver control program
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Aq Ar command
 @@ -361,11 +368,17 @@ or syslog logging on it as the disk will
  up all the time.
  .Sh SEE ALSO
  .Xr ata 4
 +.Xr cam 4
 +.Xr camcontrol 8
  .Sh HISTORY
  The
  .Nm
  utility first appeared in
  .Fx 4.6 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  .An -nosplit
  The
 @@ -377,3 +390,16 @@ utility was written by
  This manual page was written by
  .An S\(/oren Schmidt
  .Aq sos@FreeBSD.org .
 +.Sh NOTES
 +The
 +.Nm
 +utility was deprecated in
 +.Fx 9.0 .
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr camcontrol 8
 +must be used instead.
 
 Modified: stable/8/sbin/atacontrol/atacontrol.c
 ==============================================================================
 --- stable/8/sbin/atacontrol/atacontrol.c	Fri Mar 30 23:39:39 2012	(r233713)
 +++ stable/8/sbin/atacontrol/atacontrol.c	Fri Mar 30 23:48:15 2012	(r233714)
 @@ -378,6 +378,11 @@ main(int argc, char **argv)
  {
  	int fd, mode, channel, array;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Please use camcontrol instead.");
 +	}
 +
  	if (argc < 2)
  		usage();
  
 
 Modified: stable/8/sys/dev/ata/ata-all.c
 ==============================================================================
 --- stable/8/sys/dev/ata/ata-all.c	Fri Mar 30 23:39:39 2012	(r233713)
 +++ stable/8/sys/dev/ata/ata-all.c	Fri Mar 30 23:48:15 2012	(r233714)
 @@ -119,6 +119,9 @@ SYSCTL_INT(_hw_ata, OID_AUTO, wc, CTLFLA
  TUNABLE_INT("hw.ata.setmax", &ata_setmax);
  SYSCTL_INT(_hw_ata, OID_AUTO, setmax, CTLFLAG_RDTUN, &ata_setmax, 0,
  	   "ATA disk set max native address");
 +#ifdef ATA_CAM
 +FEATURE(ata_cam, "ATA devices are accessed through the cam(4) driver");
 +#endif
  
  /*
   * newbus device interface related functions
 
 Modified: stable/8/usr.sbin/burncd/burncd.8
 ==============================================================================
 --- stable/8/usr.sbin/burncd/burncd.8	Fri Mar 30 23:39:39 2012	(r233713)
 +++ stable/8/usr.sbin/burncd/burncd.8	Fri Mar 30 23:48:15 2012	(r233714)
 @@ -27,12 +27,19 @@
  .\"
  .\" $FreeBSD$
  .\"
 -.Dd December 21, 2009
 +.Dd October 9, 2011
  .Dt BURNCD 8
  .Os
  .Sh NAME
  .Nm burncd
  .Nd control the ATAPI CD-R/RW driver
 +.Pp
 +This utility was
 +.Em deprecated
 +in
 +.Fx 9.0 .
 +See
 +.Sx NOTES .
  .Sh SYNOPSIS
  .Nm
  .Op Fl deFlmnpqtv
 @@ -213,6 +220,10 @@ The
  .Nm
  utility appeared in
  .Fx 4.0 .
 +.Pp
 +.Nm
 +was deprecated in
 +.Fx 9.0 .
  .Sh AUTHORS
  The
  .Nm
 @@ -222,3 +233,19 @@ Denmark
  .Aq sos@FreeBSD.org .
  .Sh BUGS
  Probably, please report when found.
 +.Sh NOTES
 +When
 +.Bd -ragged -offset indent
 +.Cd "options ATA_CAM"
 +.Ed
 +.Pp
 +is compiled into the kernel, then
 +.Xr cdrecord 1 ,
 +available in the
 +.Fx
 +Ports Collection as part of the
 +.Pa sysutils/cdrtools
 +port, must be used instead.
 +Refer to:
 +.Pp
 +http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD
 
 Modified: stable/8/usr.sbin/burncd/burncd.c
 ==============================================================================
 --- stable/8/usr.sbin/burncd/burncd.c	Fri Mar 30 23:39:39 2012	(r233713)
 +++ stable/8/usr.sbin/burncd/burncd.c	Fri Mar 30 23:48:15 2012	(r233714)
 @@ -82,6 +82,13 @@ main(int argc, char **argv)
  	int block_size = 0, block_type = 0, cdopen = 0, dvdrw = 0;
  	const char *dev, *env_speed;
  
 +	if (feature_present("ata_cam")) {
 +		errx(1, "\nATA_CAM option is enabled in kernel.\n"
 +		    "Install the sysutils/cdrtools port and use cdrecord instead.\n\n"
 +		    "Please refer to:\n"
 +		    "http://www.freebsd.org/doc/handbook/creating-cds.html#CDRECORD");
 +	}
 +
  	if ((dev = getenv("CDROM")) == NULL)
  		dev = "/dev/acd0";
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: marius 
State-Changed-When: Fri Mar 30 23:58:02 UTC 2012 
State-Changed-Why:  
Close; MFC'ed down to stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160979 
>Unformatted:
