From nobody@FreeBSD.org  Thu Sep 22 16:46:08 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F1955106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 16:46:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id C8A6E8FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 16:46:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8MGk8EP053275
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Sep 2011 16:46:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p8MGk8W8053274;
	Thu, 22 Sep 2011 16:46:08 GMT
	(envelope-from nobody)
Message-Id: <201109221646.p8MGk8W8053274@red.freebsd.org>
Date: Thu, 22 Sep 2011 16:46:08 GMT
From: Joe Barbish <fbsd8@a1poweruser.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: 9.0 bsdinstall unfriendly
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         160913
>Category:       bin
>Synopsis:       [patch] bsdinstall(8): 9.0 bsdinstall unfriendly
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-sysinstall
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 22 16:50:12 UTC 2011
>Closed-Date:    Sun Oct 23 15:20:16 UTC 2011
>Last-Modified:  Sun Oct 23 15:20:16 UTC 2011
>Originator:     Joe Barbish
>Release:        9.0 beta 2
>Organization:
none
>Environment:
>Description:
bsdinstall/auto script is very user unfriendly.

1. There is no information provided for keymap function about now to
   get the default used in previous releases. Added dailog about selecting
   the cancel button to get the default English Latin language keyboard.

2. The "finalconfig" logic defaulted to "add user". NO body wants to have
   to use the selection arrow to navagate to the last entry in list to
   exit. Changed order of options so "Exit" is the default so this dialog
   works just like all the other dailogs.

3. sysinstall ended with msgbox telling users to remove the install media
   cd/dvd/ before rebooting the new installed system. Added dailog to
   perform this same function.

A patch is provided.
  
>How-To-Repeat:

>Fix:
Use included patch

Patch attached with submission follows:

--- auto	2011-09-22 11:55:32.000000000 -0400
+++ auto.new	2011-09-22 12:06:37.000000000 -0400
@@ -45,6 +45,12 @@
 rm -rf $BSDINSTALL_TMPETC
 mkdir $BSDINSTALL_TMPETC
 
+dialog --backtitle "FreeBSD Installer" \
+       --title "Keyboard Localization" --msgbox \
+"You are about to exec the kbdmap command to customize Freebsd to use a \
+national language keyboard. Select the CANCEL button get the default English \
+Latin 101 keyboard used in previous releases." 0 0
+
 trap true SIGINT	# This section is optional
 bsdinstall keymap
 
@@ -156,18 +162,18 @@
     bsdinstall adduser
 
 finalconfig() {
-	exec 3>&1
+exec 3>&1
 	REVISIT=$(dialog --backtitle "FreeBSD Installer" \
 	    --title "Final Configuration" --no-cancel --menu \
 	    "Setup of your FreeBSD system is nearly complete. You can now modify your configuration choices or apply more complex changes using a shell." 0 0 0 \
+		"Exit" "Apply configuration and exit installer" \
 		"Add User" "Add a user to the system" \
 		"Root Password" "Change root password" \
 		"Hostname" "Set system hostname" \
 		"Network" "Networking configuration" \
 		"Services" "Set daemons to run on startup" \
 		"Time Zone" "Set system timezone" \
-		"Shell" "Open a shell in the new system" \
-		"Exit" "Apply configuration and exit installer" 2>&1 1>&3)
+		"Shell" "Open a shell in the new system" 2>&1 1>&3)
 	exec 3>&-
 
 	case "$REVISIT" in
@@ -221,3 +227,9 @@
 
 echo "Installation Completed at $(date)" >> $BSDINSTALL_LOG
 
+cdcontrol eject
+dialog --backtitle "FreeBSD Installer" --title "Install Completed" --msgbox \
+"Your new system is about to reboot. Remove your installation \
+media CD/DVD or USB memstick mow" 0 0
+
+


>Release-Note:
>Audit-Trail:

From: Garrett Cooper <yanegomi@gmail.com>
To: bug-followup@FreeBSD.org
Cc: fbsd8@a1poweruser.com
Subject: Re: bin/160913: [patch] bsdinstall(8): 9.0 bsdinstall unfriendly
Date: Sat, 24 Sep 2011 19:31:52 -0700 (PDT)

 1. Completely agree.
 2. I agree with, but please improve the indentation with the "Exit" label, 
 and don't remove the "Shell label".
 3. Don't agree with. If people setup their system properly, it shouldn't 
 autoboot via the CD (that and cdeject isn't standard.. I could reinvent 
 the wheel in a few lines to issue the actual ioctl, but it still seems 
 unnecessary and annoying as it would screw up geom, etc, in the event 
 that the installer thought it was finished, but it wasn't 100% completed.
 Thanks,
 -Garrett
Responsible-Changed-From-To: freebsd-bugs->freebsd-sysinstall 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Thu Oct 6 04:44:44 UTC 2011 
Responsible-Changed-Why:  

fix synopsys and assign 


http://www.freebsd.org/cgi/query-pr.cgi?pr=160913 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160913: commit references a PR
Date: Thu,  6 Oct 2011 14:22:51 +0000 (UTC)

 Author: nwhitehorn
 Date: Thu Oct  6 14:22:38 2011
 New Revision: 226058
 URL: http://svn.freebsd.org/changeset/base/226058
 
 Log:
   Ask if you want to set the keymap before invoking kdbmap to prevent
   confusion.
   
   PR:		bin/160913
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/bsdinstall/scripts/keymap
 
 Modified: head/usr.sbin/bsdinstall/scripts/keymap
 ==============================================================================
 --- head/usr.sbin/bsdinstall/scripts/keymap	Thu Oct  6 11:48:13 2011	(r226057)
 +++ head/usr.sbin/bsdinstall/scripts/keymap	Thu Oct  6 14:22:38 2011	(r226058)
 @@ -28,6 +28,8 @@
  
  kbdcontrol -d >/dev/null 2>&1
  if [ $? -eq 0 ]; then
 +	dialog --backtitle "FreeBSD Installer" --title "Keymap Selection" \
 +	    --yesno "Would you like to set a non-default key mapping for your keyboard?" 0 0 || exit 0
  	exec 3>&1
  	kbdmap 2>&1 1>&3 | grep 'keymap=' > $BSDINSTALL_TMPETC/rc.conf.keymap
  fi
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160913: commit references a PR
Date: Thu,  6 Oct 2011 14:24:45 +0000 (UTC)

 Author: nwhitehorn
 Date: Thu Oct  6 14:24:37 2011
 New Revision: 226059
 URL: http://svn.freebsd.org/changeset/base/226059
 
 Log:
   Move "Exit" to the first entry in the list, so that it is the default
   choice.
   
   PR:		bin/160913
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/bsdinstall/scripts/auto
 
 Modified: head/usr.sbin/bsdinstall/scripts/auto
 ==============================================================================
 --- head/usr.sbin/bsdinstall/scripts/auto	Thu Oct  6 14:22:38 2011	(r226058)
 +++ head/usr.sbin/bsdinstall/scripts/auto	Thu Oct  6 14:24:37 2011	(r226059)
 @@ -158,6 +158,7 @@ finalconfig() {
  	REVISIT=$(dialog --backtitle "FreeBSD Installer" \
  	    --title "Final Configuration" --no-cancel --menu \
  	    "Setup of your FreeBSD system is nearly complete. You can now modify your configuration choices or apply more complex changes using a shell." 0 0 0 \
 +		"Exit" "Apply configuration and exit installer"
  		"Add User" "Add a user to the system" \
  		"Root Password" "Change root password" \
  		"Hostname" "Set system hostname" \
 @@ -165,8 +166,7 @@ finalconfig() {
  		"Services" "Set daemons to run on startup" \
  		"Time Zone" "Set system timezone" \
  		"Handbook" "Install FreeBSD Handbook (requires network)" \
 -		"Shell" "Open a shell in the new system" \
 -		"Exit" "Apply configuration and exit installer" 2>&1 1>&3)
 +		"Shell" "Open a shell in the new system" 2>&1 1>&3)
  	exec 3>&-
  
  	case "$REVISIT" in
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160913: commit references a PR
Date: Mon, 10 Oct 2011 13:57:44 +0000 (UTC)

 Author: nwhitehorn
 Date: Mon Oct 10 13:57:35 2011
 New Revision: 226210
 URL: http://svn.freebsd.org/changeset/base/226210
 
 Log:
   MFC r226058:
   Ask if you want to set the keymap before invoking kdbmap to prevent
   confusion.
   
   PR:		bin/160913
   Approved by:	re (kib)
 
 Modified:
   stable/9/usr.sbin/bsdinstall/scripts/keymap
 Directory Properties:
   stable/9/usr.sbin/bsdinstall/   (props changed)
 
 Modified: stable/9/usr.sbin/bsdinstall/scripts/keymap
 ==============================================================================
 --- stable/9/usr.sbin/bsdinstall/scripts/keymap	Mon Oct 10 13:51:21 2011	(r226209)
 +++ stable/9/usr.sbin/bsdinstall/scripts/keymap	Mon Oct 10 13:57:35 2011	(r226210)
 @@ -28,6 +28,8 @@
  
  kbdcontrol -d >/dev/null 2>&1
  if [ $? -eq 0 ]; then
 +	dialog --backtitle "FreeBSD Installer" --title "Keymap Selection" \
 +	    --yesno "Would you like to set a non-default key mapping for your keyboard?" 0 0 || exit 0
  	exec 3>&1
  	kbdmap 2>&1 1>&3 | grep 'keymap=' > $BSDINSTALL_TMPETC/rc.conf.keymap
  fi
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/160913: commit references a PR
Date: Mon, 10 Oct 2011 13:58:42 +0000 (UTC)

 Author: nwhitehorn
 Date: Mon Oct 10 13:58:33 2011
 New Revision: 226211
 URL: http://svn.freebsd.org/changeset/base/226211
 
 Log:
   MFC r226059:
   Move "Exit" to the first entry in the list, so that it is the default
   choice.
   
   PR:		bin/160913
   Approved by:	re (kib)
 
 Modified:
   stable/9/usr.sbin/bsdinstall/scripts/auto
 Directory Properties:
   stable/9/usr.sbin/bsdinstall/   (props changed)
 
 Modified: stable/9/usr.sbin/bsdinstall/scripts/auto
 ==============================================================================
 --- stable/9/usr.sbin/bsdinstall/scripts/auto	Mon Oct 10 13:57:35 2011	(r226210)
 +++ stable/9/usr.sbin/bsdinstall/scripts/auto	Mon Oct 10 13:58:33 2011	(r226211)
 @@ -158,6 +158,7 @@ finalconfig() {
  	REVISIT=$(dialog --backtitle "FreeBSD Installer" \
  	    --title "Final Configuration" --no-cancel --menu \
  	    "Setup of your FreeBSD system is nearly complete. You can now modify your configuration choices or apply more complex changes using a shell." 0 0 0 \
 +		"Exit" "Apply configuration and exit installer"
  		"Add User" "Add a user to the system" \
  		"Root Password" "Change root password" \
  		"Hostname" "Set system hostname" \
 @@ -165,8 +166,7 @@ finalconfig() {
  		"Services" "Set daemons to run on startup" \
  		"Time Zone" "Set system timezone" \
  		"Handbook" "Install FreeBSD Handbook (requires network)" \
 -		"Shell" "Open a shell in the new system" \
 -		"Exit" "Apply configuration and exit installer" 2>&1 1>&3)
 +		"Shell" "Open a shell in the new system" 2>&1 1>&3)
  	exec 3>&-
  
  	case "$REVISIT" in
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: nwhitehorn 
State-Changed-When: Sun Oct 23 15:20:04 UTC 2011 
State-Changed-Why:  
Changes integrated. Thank you! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=160913 
>Unformatted:
