From nobody@FreeBSD.org  Sat Aug 13 17:26:04 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8FEBE106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Aug 2011 17:26:04 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 672488FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Aug 2011 17:26:04 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p7DHQ44P021295
	for <freebsd-gnats-submit@FreeBSD.org>; Sat, 13 Aug 2011 17:26:04 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p7DHQ4lw021294;
	Sat, 13 Aug 2011 17:26:04 GMT
	(envelope-from nobody)
Message-Id: <201108131726.p7DHQ4lw021294@red.freebsd.org>
Date: Sat, 13 Aug 2011 17:26:04 GMT
From: "Alex K." <c79@foxbsd.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] cat - incorrect output on fstat() failure
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         159746
>Category:       bin
>Synopsis:       [patch] cat(1) - incorrect output on fstat() failure
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 13 17:30:10 UTC 2011
>Closed-Date:    Wed Oct 31 17:06:07 UTC 2012
>Last-Modified:  Wed Oct 31 17:06:07 UTC 2012
>Originator:     Alex K.
>Release:        FreeBSD 8.2-RELEASE
>Organization:
>Environment:
FreeBSD system.foxbsd.org 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Incorrect output on fstat() failure.
>How-To-Repeat:

>Fix:
260c260
<                       err(1, "%s", filename);
---
>                       err(1, "stdout");

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Wed Jul 18 13:37:47 UTC 2012 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159746 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/159746: commit references a PR
Date: Fri, 20 Jul 2012 08:33:39 +0000 (UTC)

 Author: jh
 Date: Fri Jul 20 08:33:23 2012
 New Revision: 238653
 URL: http://svn.freebsd.org/changeset/base/238653
 
 Log:
   Use proper error message when fstat(2) fails on stdout.
   
   PR:		bin/159746
   Submitted by:	Alex K.
 
 Modified:
   head/bin/cat/cat.c
 
 Modified: head/bin/cat/cat.c
 ==============================================================================
 --- head/bin/cat/cat.c	Fri Jul 20 08:31:36 2012	(r238652)
 +++ head/bin/cat/cat.c	Fri Jul 20 08:33:23 2012	(r238653)
 @@ -260,7 +260,7 @@ raw_cat(int rfd)
  	wfd = fileno(stdout);
  	if (buf == NULL) {
  		if (fstat(wfd, &sbuf))
 -			err(1, "%s", filename);
 +			err(1, "stdout");
  		if (S_ISREG(sbuf.st_mode)) {
  			/* If there's plenty of RAM, use a large copy buffer */
  			if (sysconf(_SC_PHYS_PAGES) > PHYSPAGES_THRESHOLD)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Fri Jul 20 09:16:25 UTC 2012 
State-Changed-Why:  
Patched in head (r238653). Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159746 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/159746: commit references a PR
Date: Wed, 12 Sep 2012 16:02:10 +0000 (UTC)

 Author: jh
 Date: Wed Sep 12 16:01:48 2012
 New Revision: 240408
 URL: http://svn.freebsd.org/changeset/base/240408
 
 Log:
   MFC r238653: Use proper error message when fstat(2) fails on stdout.
   
   PR:		bin/159746
 
 Modified:
   stable/9/bin/cat/cat.c
 Directory Properties:
   stable/9/bin/cat/   (props changed)
 
 Modified: stable/9/bin/cat/cat.c
 ==============================================================================
 --- stable/9/bin/cat/cat.c	Wed Sep 12 15:59:03 2012	(r240407)
 +++ stable/9/bin/cat/cat.c	Wed Sep 12 16:01:48 2012	(r240408)
 @@ -260,7 +260,7 @@ raw_cat(int rfd)
  	wfd = fileno(stdout);
  	if (buf == NULL) {
  		if (fstat(wfd, &sbuf))
 -			err(1, "%s", filename);
 +			err(1, "stdout");
  		if (S_ISREG(sbuf.st_mode)) {
  			/* If there's plenty of RAM, use a large copy buffer */
  			if (sysconf(_SC_PHYS_PAGES) > PHYSPAGES_THRESHOLD)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Wed Oct 31 17:06:07 UTC 2012 
State-Changed-Why:  
Fixed in head, stable/9 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=159746 
>Unformatted:
