From naddy@bigeye.rhein-neckar.de  Wed Jan  5 06:02:34 2000
Return-Path: <naddy@bigeye.rhein-neckar.de>
Received: from news-ma.rhein-neckar.de (news-ma.rhein-neckar.de [193.197.90.3])
	by hub.freebsd.org (Postfix) with ESMTP id ED6B2151D0
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Jan 2000 06:02:31 -0800 (PST)
	(envelope-from naddy@bigeye.rhein-neckar.de)
Received: from bigeye.rhein-neckar.de (uucp@localhost)
	by news-ma.rhein-neckar.de (8.8.8/8.8.8) with bsmtp id PAA28145
	for FreeBSD-gnats-submit@freebsd.org; Wed, 5 Jan 2000 15:02:29 +0100 (CET)
	(envelope-from naddy@bigeye.rhein-neckar.de)
Received: (from naddy@localhost)
	by bigeye.rhein-neckar.de (8.9.3/8.9.3) id PAA48674;
	Wed, 5 Jan 2000 15:01:35 +0100 (CET)
	(envelope-from naddy)
Message-Id: <200001051401.PAA48674@bigeye.rhein-neckar.de>
Date: Wed, 5 Jan 2000 15:01:35 +0100 (CET)
From: Christian Weisgerber <naddy@mips.rhein-neckar.de>
Sender: naddy@bigeye.rhein-neckar.de
Reply-To: naddy@mips.rhein-neckar.de
To: FreeBSD-gnats-submit@freebsd.org
Subject: rcmd(3) prototype disagrees with definition
X-Send-Pr-Version: 3.2

>Number:         15906
>Category:       bin
>Synopsis:       rcmd(3) prototype disagrees with definition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan  5 06:10:01 PST 2000
>Closed-Date:    Wed Jan 5 18:27:33 PST 2000
>Last-Modified:  Wed Jan  5 18:27:50 PST 2000
>Originator:     Christian Weisgerber
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

>Description:

What's the type of rcmd(3)'s second parameter, int or u_short?

Man page:
    int
    rcmd(char **ahost, int inport, const char *locuser, const char *remuser,
         const char *cmd, int *fd2p)

Prototype in /usr/include/unistd.h:
    int rcmd __P((char **, int, const char *,
                  const char *, const char *, int *));

Actual definition in src/lib/libc/net/rcmd.c:
    int
    rcmd(ahost, rport, locuser, remuser, cmd, fd2p)
        char **ahost;
        u_short rport;
        const char *locuser, *remuser, *cmd;
        int *fd2p;

Which instances should be fixed?

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:

From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To: naddy@mips.rhein-neckar.de
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: bin/15906: rcmd(3) prototype disagrees with definition
Date: Wed, 5 Jan 2000 12:30:19 -0500 (EST)

 <<On Wed, 5 Jan 2000 15:01:35 +0100 (CET), Christian Weisgerber <naddy@mips.rhein-neckar.de> said:
 
 >> Synopsis:       rcmd(3) prototype disagrees with definition
 
 No, it does not.
 
 >     int rcmd __P((char **, int, const char *,
 >                   const char *, const char *, int *));
 
 This is the correct prototype for a declaration of the form:
 
 >     int
 >     rcmd(ahost, rport, locuser, remuser, cmd, fd2p)
 >         char **ahost;
 >         u_short rport;
 >         const char *locuser, *remuser, *cmd;
 >         int *fd2p;
 
 > Which instances should be fixed?
 
 Neither.  Please read a text on Standard C, such as K&R or H&S.
 
 -GAWollman
 
 

From: Christian Weisgerber <naddy@mips.rhein-neckar.de>
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/15906: rcmd(3) prototype disagrees with definition
Date: Thu, 6 Jan 2000 00:35:40 +0100

 Garrett Wollman:
 
 > >> Synopsis:       rcmd(3) prototype disagrees with definition
 > 
 > No, it does not.
 
 Indeed. Please close the PR. Sorry for wasting everybody's time.
 I should have noticed that this is all throughout the tree.
 
 > Please read a text on Standard C, such as K&R or H&S.
 
 Sigh. I found it, section A7.3.2 in K&Rv2. Integral promotion of
 integral type arguments and parameters for old style function
 declarations.
 
 -- 
 Christian "naddy" Weisgerber                  naddy@mips.rhein-neckar.de
 
State-Changed-From-To: open->closed 
State-Changed-By: steve 
State-Changed-When: Wed Jan 5 18:27:33 PST 2000 
State-Changed-Why:  
Closed at originator's request. 
>Unformatted:
