From brdean@mindspring.com  Sun Jan  2 12:59:43 2000
Return-Path: <brdean@mindspring.com>
Received: from smtp6.mindspring.com (smtp6.mindspring.com [207.69.200.110])
	by hub.freebsd.org (Postfix) with ESMTP id 5E18E150A0
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  2 Jan 2000 12:59:41 -0800 (PST)
	(envelope-from brdean@mindspring.com)
Received: from vger.foo.com (user-2ivf1a0.dialup.mindspring.com [165.247.133.64])
	by smtp6.mindspring.com (8.9.3/8.8.5) with ESMTP id PAA08648
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 2 Jan 2000 15:59:34 -0500 (EST)
Received: (from bsd@localhost)
	by vger.foo.com (8.9.3/8.9.3) id PAA30587;
	Sun, 2 Jan 2000 15:56:53 -0500 (EST)
	(envelope-from bsd)
Message-Id: <200001022056.PAA30587@vger.foo.com>
Date: Sun, 2 Jan 2000 15:56:53 -0500 (EST)
From: brdean@mindspring.com
Reply-To: brdean@mindspring.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: tip core dumps after transferring a file from local to remote
X-Send-Pr-Version: 3.2

>Number:         15847
>Category:       bin
>Synopsis:       tip core dumps after file transfer from local to remote
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan  2 13:00:00 PST 2000
>Closed-Date:    Mon Feb 21 18:59:26 PST 2000
>Last-Modified:  Mon Feb 21 19:00:31 PST 2000
>Originator:     Brian Dean
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

FreeBSD vger.foo.com 4.0-CURRENT FreeBSD 4.0-CURRENT #0: Wed Dec 29 23:30:55 EST 1999     bsd@vger.foo.com:/usr/src/sys/compile/VGER  i386

	Current sources as of December 23, 1999.


>Description:

	tip core dumps after tranferring a file to the remote system
	when no eof characters have been specified due to a NULL
	pointer dereference.

>How-To-Repeat:

	1) Use tip to connect to a remote system
	2) Set the remote system to receive a file
	3) Use the tip '~>' command to start a file transfer
	3) Enter the local filename to be transfered

>Fix:

Index: cmds.c
===================================================================
RCS file: /usr02/mirror/ncvs/src/usr.bin/tip/tip/cmds.c,v
retrieving revision 1.10
diff -u -r1.10 cmds.c
--- cmds.c      1999/08/28 01:06:32     1.10
+++ cmds.c      2000/01/02 20:46:56
@@ -513,7 +513,7 @@
 out:
        if (lastc != '\n' && !boolean(value(RAWFTP)))
                send('\r');
-       for (pc = eofchars; *pc; pc++)
+       for (pc = eofchars; pc && *pc; pc++)
                send(*pc);
        stop_t = time(0);
        fclose(fd);

>Release-Note:
>Audit-Trail:

From: Brian Dean <brdean@mindspring.com>
To: FreeBSD-gnats-submit@FreeBSD.org, brdean@mindspring.com
Cc:  
Subject: Re: bin/15847: tip core dumps after file transfer from local to remote
Date: Sun, 02 Jan 2000 16:29:11 -0500

 I accidentially submitted this twice (second one is pr bin/15848).  A
 mailer
 problem on my end caused me to think the first one did not go in. 
 Please
 disregard pr bin/15848.
 
 Thanks,
 -Brian
 -- 
 Brian Dean					brdean@mindspring.com
 
State-Changed-From-To: open->closed 
State-Changed-By: bsd 
State-Changed-When: Mon Feb 21 18:59:26 PST 2000 
State-Changed-Why:  
Fixed. 
>Unformatted:
