From jhs@berklix.com  Wed Jun  8 23:49:17 2011
Return-Path: <jhs@berklix.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 06196106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  8 Jun 2011 23:49:17 +0000 (UTC)
	(envelope-from jhs@berklix.com)
Received: from tower.berklix.org (tower.berklix.org [83.236.223.114])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E5978FC17
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  8 Jun 2011 23:49:15 +0000 (UTC)
Received: from park.js.berklix.net (p5DCBE060.dip.t-dialin.net [93.203.224.96])
	(authenticated bits=0)
	by tower.berklix.org (8.14.2/8.14.2) with ESMTP id p58NnBnP066854;
	Wed, 8 Jun 2011 23:49:13 GMT
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41])
	by park.js.berklix.net (8.13.8/8.13.8) with ESMTP id p58NmgWT015856;
	Thu, 9 Jun 2011 01:48:43 +0200 (CEST)
	(envelope-from jhs@berklix.com)
Received: from fire.js.berklix.net (localhost [127.0.0.1])
	by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id p58NmXrP081654;
	Wed, 8 Jun 2011 23:48:38 GMT
	(envelope-from jhs@fire.js.berklix.net)
Received: (from jhs@localhost)
	by fire.js.berklix.net (8.14.4/8.14.3/Submit) id p58NmB5o081648;
	Thu, 9 Jun 2011 01:48:11 +0200 (CEST)
	(envelope-from jhs)
Message-Id: <201106082348.p58NmB5o081648@fire.js.berklix.net>
Date: Thu, 9 Jun 2011 01:48:11 +0200 (CEST)
From: "Julian H. Stacey" <jhs@berklix.com>
Reply-To: "Julian H. Stacey" <jhs@berklix.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: <jhs@berklix.com>
Subject: input data trigers a core dump from calendar
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         157718
>Category:       bin
>Synopsis:       input data trigers a core dump from calendar(1) [regression]
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    edwin
>State:          patched
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 08 23:50:09 UTC 2011
>Closed-Date:    
>Last-Modified:  Wed Oct 05 14:35:52 UTC 2011
>Originator:     Julian H. Stacey
>Release:        FreeBSD 8.2-RELEASE amd64
>Organization:
http://berklix.com BSD Linux Unix Consultancy, Munich/Muenchen.
>Environment:
System: FreeBSD fire.js.berklix.net 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Jun 2 23:10:13 CEST 2011 jhs@blak.js.berklix.net:/ad6s4/release/8.2-RELEASE/src/sys/amd64/compile/FIRE64.small amd64

I have verified calendar core dumps on these:
	8.2-RELEASE amd64 
	8.2-RELEASE i386 
& not on these:
	4.11-RELEASE i386
	6.2-RELEASE i386
	6.3-RELEASE i386
	7.3-RELEASE i386
So there's a regression error to be found & corrected.

	
>Description:
	calendar should not core dump
>How-To-Repeat:
	
	fetch http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/core_dump_input.ignore
	fetch http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/core_dump_shell.ignore
	./core_dump_shell.ignore
	calendar -f  core_dump_input.ignore

	(BTW ignore my strange names ending .ignore, its just a prefix to
	  stop my customise shell installing things in my src/
>Fix:

	


>Release-Note:
>Audit-Trail:

From: Jaakko Heinonen <jh@FreeBSD.org>
To: "Julian H. Stacey" <jhs@berklix.com>
Cc: bug-followup@FreeBSD.org, edwin@FreeBSD.org
Subject: Re: bin/157718: input data trigers a core dump from calendar
Date: Thu, 9 Jun 2011 18:39:43 +0300

 On 2011-06-09, Julian H. Stacey wrote:
 > I have verified calendar core dumps on these:
 > 	8.2-RELEASE amd64 
 > 	8.2-RELEASE i386 
 > & not on these:
 > 	4.11-RELEASE i386
 > 	6.2-RELEASE i386
 > 	6.3-RELEASE i386
 > 	7.3-RELEASE i386
 > So there's a regression error to be found & corrected.
 
 It looks like this regression is caused by r212035:
 
 ------------------------------------------------------------------------
 r212035 | edwin | 2010-08-31 01:45:32 +0300 (Tue, 31 Aug 2010) | 3 lines
 
 For calendars which don't match the solar-based Gregorian calendar,
 be able to specify a year string in an entry.
 
 ------------------------------------------------------------------------
 
 edwin@ Cc'd.
 
 > >Description:
 > 	calendar should not core dump
 > >How-To-Repeat:
 > 	
 > 	fetch http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/core_dump_input.ignore
 > 	fetch http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/core_dump_shell.ignore
 > 	./core_dump_shell.ignore
 > 	calendar -f  core_dump_input.ignore
 > 
 > 	(BTW ignore my strange names ending .ignore, its just a prefix to
 > 	  stop my customise shell installing things in my src/
 
 -- 
 Jaakko


From: Edwin Groothuis <edwin@FreeBSD.org>
Subject: Re: bin/157718: input data trigers a core dump from calendar

 Happens with this input too:
 //<tab>foo

Responsible-Changed-From-To: freebsd-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jul 11 10:57:48 UTC 2011 
Responsible-Changed-Why:  
I'll chase it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157718 
State-Changed-From-To: open->patched 
State-Changed-By: edwin 
State-Changed-When: Mon Jul 11 22:02:12 UTC 2011 
State-Changed-Why:  
Fixed in head, MFC later. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157718 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/157718: commit references a PR
Date: Mon, 11 Jul 2011 22:01:54 +0000 (UTC)

 Author: edwin
 Date: Mon Jul 11 22:01:39 2011
 New Revision: 223939
 URL: http://svn.freebsd.org/changeset/base/223939
 
 Log:
   Fix run-time breakage when encoutering invalid input-data.
   
   PR:		bin/157718
 
 Modified:
   head/usr.bin/calendar/parsedata.c
 
 Modified: head/usr.bin/calendar/parsedata.c
 ==============================================================================
 --- head/usr.bin/calendar/parsedata.c	Mon Jul 11 20:43:59 2011	(r223938)
 +++ head/usr.bin/calendar/parsedata.c	Mon Jul 11 22:01:39 2011	(r223939)
 @@ -818,6 +818,8 @@ showflags(int flags)
  static const char *
  getmonthname(int i)
  {
 +	if (i <= 0 || i > 12)
 +		return ("");
  	if (nmonths[i - 1].len != 0 && nmonths[i - 1].name != NULL)
  		return (nmonths[i - 1].name);
  	return (months[i - 1]);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
