From nobody@FreeBSD.org  Mon Jun  6 15:46:31 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 15253106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Jun 2011 15:46:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 05CA48FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  6 Jun 2011 15:46:31 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p56FkUvB004146
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 6 Jun 2011 15:46:30 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p56FkUvU004145;
	Mon, 6 Jun 2011 15:46:30 GMT
	(envelope-from nobody)
Message-Id: <201106061546.p56FkUvU004145@red.freebsd.org>
Date: Mon, 6 Jun 2011 15:46:30 GMT
From: jason wright <jason@thought.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: kdump gets ptrace args wrong
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         157663
>Category:       bin
>Synopsis:       [patch] kdump(1) gets ptrace args wrong
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    dchagin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 06 15:50:08 UTC 2011
>Closed-Date:    Tue Jan 08 12:50:02 UTC 2013
>Last-Modified:  Tue Jan 08 12:50:02 UTC 2013
>Originator:     jason wright
>Release:        8.2
>Organization:
as if.
>Environment:
FreeBSD fbsd82-32.localdomain 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Fri Feb 18 02:24:46 UTC 2011     root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
Regex for grabbing ptrace flags for kdump is not inclusive enough.

Before fix:

CALL  ptrace(<invalid=5>, ...)

After fix:

CALL  ptrace(PT_WRITE_D, ...)


>How-To-Repeat:
ktrace something that uses ptrace(PT_WRITE_D,...) then use kdump to view results.

>Fix:
apply patch below.  It appears that no extraneous garbage is picked up by the modified regex (which just adds '_' is an additional character).



Patch attached with submission follows:

--- mksubr.old	2011-06-05 13:54:57.000000000 -0600
+++ mksubr	2011-06-05 13:57:21.000000000 -0600
@@ -343,7 +343,7 @@
 auto_if_type "sockipprotoname" "IPPROTO_[[:alnum:]]+[[:space:]]+" "netinet/in.h"
 auto_switch_type "sockoptname" "SO_[A-Z]+[[:space:]]+0x[0-9]+" "sys/socket.h"
 auto_switch_type "socktypename" "SOCK_[A-Z]+[[:space:]]+[1-9]+[0-9]*" "sys/socket.h"
-auto_switch_type "ptraceopname" "PT_[[:alnum:]]+[[:space:]]+[0-9]+" "sys/ptrace.h"
+auto_switch_type "ptraceopname" "PT_[[:alnum:]_]+[[:space:]]+[0-9]+" "sys/ptrace.h"
 
 cat <<_EOF_
 /*


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dchagin 
Responsible-Changed-By: dchagin 
Responsible-Changed-When: Mon Jun 6 19:04:39 UTC 2011 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157663 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/157663: commit references a PR
Date: Mon,  6 Jun 2011 19:01:01 +0000 (UTC)

 Author: dchagin
 Date: Mon Jun  6 19:00:38 2011
 New Revision: 222768
 URL: http://svn.freebsd.org/changeset/base/222768
 
 Log:
   Fix regex for ptraceopname().
   
   PR:		bin/157663
   Submitted by:	jason wright <jason@thought.net>
   MFC after:	10 days
 
 Modified:
   head/usr.bin/kdump/mksubr
 
 Modified: head/usr.bin/kdump/mksubr
 ==============================================================================
 --- head/usr.bin/kdump/mksubr	Mon Jun  6 18:40:01 2011	(r222767)
 +++ head/usr.bin/kdump/mksubr	Mon Jun  6 19:00:38 2011	(r222768)
 @@ -345,7 +345,7 @@ auto_if_type "sockfamilyname" "AF_[[:aln
  auto_if_type "sockipprotoname" "IPPROTO_[[:alnum:]]+[[:space:]]+" "netinet/in.h"
  auto_switch_type "sockoptname" "SO_[A-Z]+[[:space:]]+0x[0-9]+" "sys/socket.h"
  auto_switch_type "socktypename" "SOCK_[A-Z]+[[:space:]]+[1-9]+[0-9]*" "sys/socket.h"
 -auto_switch_type "ptraceopname" "PT_[[:alnum:]]+[[:space:]]+[0-9]+" "sys/ptrace.h"
 +auto_switch_type "ptraceopname" "PT_[[:alnum:]_]+[[:space:]]+[0-9]+" "sys/ptrace.h"
  
  cat <<_EOF_
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/157663: commit references a PR
Date: Fri, 17 Jun 2011 18:16:37 +0000 (UTC)

 Author: dchagin
 Date: Fri Jun 17 18:16:23 2011
 New Revision: 223194
 URL: http://svn.freebsd.org/changeset/base/223194
 
 Log:
   MFC r222768:
   
   Fix regex for ptraceopname().
   
   PR:		bin/157663
   Submitted by:	jason wright <jason@thought.net>
 
 Modified:
   stable/8/usr.bin/kdump/mksubr
 Directory Properties:
   stable/8/usr.bin/kdump/   (props changed)
 
 Modified: stable/8/usr.bin/kdump/mksubr
 ==============================================================================
 --- stable/8/usr.bin/kdump/mksubr	Fri Jun 17 17:55:37 2011	(r223193)
 +++ stable/8/usr.bin/kdump/mksubr	Fri Jun 17 18:16:23 2011	(r223194)
 @@ -343,7 +343,7 @@ auto_if_type "sockfamilyname" "AF_[[:aln
  auto_if_type "sockipprotoname" "IPPROTO_[[:alnum:]]+[[:space:]]+" "netinet/in.h"
  auto_switch_type "sockoptname" "SO_[A-Z]+[[:space:]]+0x[0-9]+" "sys/socket.h"
  auto_switch_type "socktypename" "SOCK_[A-Z]+[[:space:]]+[1-9]+[0-9]*" "sys/socket.h"
 -auto_switch_type "ptraceopname" "PT_[[:alnum:]]+[[:space:]]+[0-9]+" "sys/ptrace.h"
 +auto_switch_type "ptraceopname" "PT_[[:alnum:]_]+[[:space:]]+[0-9]+" "sys/ptrace.h"
  
  cat <<_EOF_
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: dchagin 
State-Changed-When: Sat Jun 18 08:41:22 UTC 2011 
State-Changed-Why:  
commited 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157663 
State-Changed-From-To: patched->closed 
State-Changed-By: dchagin 
State-Changed-When: Tue Jan 8 12:48:55 UTC 2013 
State-Changed-Why:  
Fixed! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=157663 
>Unformatted:
