From nobody@FreeBSD.org  Thu Mar 24 15:58:09 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E194106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Mar 2011 15:58:09 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 6EE838FC13
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Mar 2011 15:58:09 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2OFw9Jb046366
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 24 Mar 2011 15:58:09 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2OFw9OB046363;
	Thu, 24 Mar 2011 15:58:09 GMT
	(envelope-from nobody)
Message-Id: <201103241558.p2OFw9OB046363@red.freebsd.org>
Date: Thu, 24 Mar 2011 15:58:09 GMT
From: John Levine <hostmaster@iecc.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Buglet in calendar -a
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         155915
>Category:       bin
>Synopsis:       [patch] Buglet in calendar(1) -a
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    edwin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 24 16:00:05 UTC 2011
>Closed-Date:    Fri Jul 08 07:02:17 UTC 2011
>Last-Modified:  Fri Jul 08 07:02:17 UTC 2011
>Originator:     John Levine
>Release:        8.2-RELEASE
>Organization:
>Environment:
FreeBSD joyce.lan 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Sun Feb 27 16:46:46 EST 2011     johnl@joyce.lan:/usr/src/sys/amd64/compile/JOYCE  amd64

>Description:
When calendar -a sends out the daily mail summaries of calendar entries, it puts an extra null byte in the Subject line, confusing some mail programs.
>How-To-Repeat:
adjust /etc/mail/mailer.conf so sendmail saves output to a file, run calendar -a, look at the file
>Fix:
In /usr/src/usr.bin/calendar/io.c, line 349:


349c349
< 	write(pdes[1], ">\nSubject: ", 12);
---
> 	write(pdes[1], ">\nSubject: ", 11);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->edwin 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Thu Mar 24 18:17:16 UTC 2011 
Responsible-Changed-Why:  
Edwin, could you take a look at this PR? I believe this is your department? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155915 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/155915: commit references a PR
Date: Mon,  6 Jun 2011 13:50:39 +0000 (UTC)

 Author: jh
 Date: Mon Jun  6 13:50:29 2011
 New Revision: 222755
 URL: http://svn.freebsd.org/changeset/base/222755
 
 Log:
   Pass correct size to write(2).
   
   PR:		bin/155915
   Submitted by:	John Levine
   MFC after:	2 weeks
 
 Modified:
   head/usr.bin/calendar/io.c
 
 Modified: head/usr.bin/calendar/io.c
 ==============================================================================
 --- head/usr.bin/calendar/io.c	Mon Jun  6 13:24:54 2011	(r222754)
 +++ head/usr.bin/calendar/io.c	Mon Jun  6 13:50:29 2011	(r222755)
 @@ -346,7 +346,7 @@ closecal(FILE *fp)
  	write(pdes[1], pw->pw_name, strlen(pw->pw_name));
  	write(pdes[1], ">\nTo: <", 7);
  	write(pdes[1], pw->pw_name, strlen(pw->pw_name));
 -	write(pdes[1], ">\nSubject: ", 12);
 +	write(pdes[1], ">\nSubject: ", 11);
  	write(pdes[1], dayname, strlen(dayname));
  	write(pdes[1], "'s Calendar\nPrecedence: bulk\n\n", 30);
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Mon Jun 6 14:05:37 UTC 2011 
State-Changed-Why:  
Patched in head (r222755). Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155915 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/155915: commit references a PR
Date: Fri,  8 Jul 2011 06:28:47 +0000 (UTC)

 Author: jh
 Date: Fri Jul  8 06:28:35 2011
 New Revision: 223857
 URL: http://svn.freebsd.org/changeset/base/223857
 
 Log:
   MFC r222755: Pass correct size to write(2).
   
   PR:		bin/155915
 
 Modified:
   stable/8/usr.bin/calendar/io.c
 Directory Properties:
   stable/8/usr.bin/calendar/   (props changed)
 
 Modified: stable/8/usr.bin/calendar/io.c
 ==============================================================================
 --- stable/8/usr.bin/calendar/io.c	Fri Jul  8 03:21:28 2011	(r223856)
 +++ stable/8/usr.bin/calendar/io.c	Fri Jul  8 06:28:35 2011	(r223857)
 @@ -346,7 +346,7 @@ closecal(FILE *fp)
  	write(pdes[1], pw->pw_name, strlen(pw->pw_name));
  	write(pdes[1], ">\nTo: <", 7);
  	write(pdes[1], pw->pw_name, strlen(pw->pw_name));
 -	write(pdes[1], ">\nSubject: ", 12);
 +	write(pdes[1], ">\nSubject: ", 11);
  	write(pdes[1], dayname, strlen(dayname));
  	write(pdes[1], "'s Calendar\nPrecedence: bulk\n\n", 30);
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Fri Jul 8 07:02:16 UTC 2011 
State-Changed-Why:  
Fixed in head and stable/8. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155915 
>Unformatted:
