From dmahoney@repo.isc.org  Tue Mar 15 02:03:31 2011
Return-Path: <dmahoney@repo.isc.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F2D3A106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Mar 2011 02:03:31 +0000 (UTC)
	(envelope-from dmahoney@repo.isc.org)
Received: from repo.isc.org (repo.isc.org [IPv6:2001:4f8:0:2::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id E69D38FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Mar 2011 02:03:31 +0000 (UTC)
Received: by repo.isc.org (Postfix, from userid 10302)
	id 9685158C7CF; Tue, 15 Mar 2011 02:03:31 +0000 (UTC)
Message-Id: <20110315020331.9685158C7CF@repo.isc.org>
Date: Tue, 15 Mar 2011 02:03:31 +0000 (UTC)
From: Dan Mahoney <dmahoney@isc.org>
Reply-To: Dan Mahoney <dmahoney@isc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Patch to add -r tag:date to CVS
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         155567
>Category:       bin
>Synopsis:       [patch] cvs(1): add -r tag:date to CVS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    eadler
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 15 02:10:12 UTC 2011
>Closed-Date:    Fri May 11 22:45:11 UTC 2012
>Last-Modified:  Fri May 11 22:45:11 UTC 2012
>Originator:     Dan Mahoney
>Release:        FreeBSD 8.0-RELEASE-p3 amd64
>Organization:
ISC
>Environment:
System: FreeBSD repo.isc.org 8.0-RELEASE-p3 FreeBSD 8.0-RELEASE-p3 #0: Tue May 25 20:54:11 UTC 2010 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64


>Description:

Apple's cvs version supports '-r tag:date' which allows you
to specify a date on a branch and is version 1.12.13.

FreeBSD's cvs is 1.11.22.1-20080310-FreeBSD (1.11 vs 1.12)
and it doesn't support '-r tag:date'.

The attached patch is against 1.11.23 and adds support for
'-r tag:date'. It's base on the following but is just the
minimal changes required to add support. It splits the
revision string.

Note that the mainline CVS doesn't appear to have been updated in a while, so it makes more sense to submit at an OS level than 
upstream.

>How-To-Repeat:

See above.  This is an enhancement to bring the mainline tool in line with apple's mods.

>Fix:

The attached (small) patch will add this, was written here at ISC:

--- src/patch.c	2005-09-23 02:03:04.000000000 +0000
+++ src/patch.c	2011-01-27 03:50:27.000000000 +0000
@@ -119,10 +119,10 @@
 		if (rev2 != NULL || date2 != NULL)
 		    error (1, 0,
 		       "no more than two revisions/dates can be specified");
-		if (rev1 != NULL || date1 != NULL)
-		    rev2 = optarg;
+		if (rev1 || date1)
+		    parse_tagdate (&rev2, &date2, optarg);
 		else
-		    rev1 = optarg;
+		    parse_tagdate (&rev1, &date1, optarg);
 		break;
 	    case 'k':
 		if (options)


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->freebsd-bugs 
Responsible-Changed-By: pav 
Responsible-Changed-When: Thu Mar 17 13:28:21 UTC 2011 
Responsible-Changed-Why:  
Refile to bin/ as this deals with base system 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155567 
Responsible-Changed-From-To: freebsd-bugs->eadler 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Sun Apr 15 21:50:33 UTC 2012 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155567 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Fri May 11 22:45:09 UTC 2012 
State-Changed-Why:  
patch no longer applies, but if you mail me an updated patch I'll try 
and get it 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155567 
>Unformatted:
